Filtering gallery with if statement not allowing thisitem to return all fields

[Fess67]

Hi,

I am building an inspection app.  You can either complete a new inspection or, if there is a partially completed one already in progress then the gallery will be populated with that data.  To populate the gallery I am using an if statement which I thought was pretty basic but it is throwing me an error that I cannot solve.

Maybe I should just change my approach and use a form ????

My if statement brings in the expected data however there is an issue with returning the question number.  Without the question number I cannot patch the records properly.

If(
    LookUp(
        'WSI Completed Inspections',
        Status = "Saved" && Site = 'Site Name'.Text,
        true
    ),
    Filter(
        'WSI Completed Inspections',
        Section = Lbl_Sect1.Text,
        Site = 'Site Name'.Text
    ),
    Filter(
        'WSI Questions',
        Section = Lbl_Sect1.Text
    )
)

The following code in isolation returns the expected result for a new inspection but not within the if statement.

Filter(
        'WSI Questions',
        Section = Lbl_Sect1.Text
    )

Running this part of the code in isolation returns the correct saved data however I cannot get the QuestionNumber data to populate correctly.  It returns the Site information.  So for some reason ThisItem.QuestionNumber actually returns ThisItem.Site  but only if the code is executed on its own.  If I run it within the IF statement ThisItem.QuestionNumber throws a name isn't valid error, QuestionNumber is not recognised.

Filter(
        'WSI Completed Inspections',
        Section = Lbl_Sect1.Text,
        Site = 'Site Name'.Text
    )

The datasources are both SP lists.  Column names and column types are the same.  I can ThisItem.xxx all of the other columns, just not the Question Number.

I have renamed the columns a couple of times to see if that made a difference and it has not.  I have closed and reopened the Power App environment in case there is some odd cache issue.  Any all all thoughts appreciated.

[WarrenBelz]

Hi @Fess67 ,

I am not entirely clear of the logical outcome required, but is this what you are trying to do ?

With(
   {
      _NoMatch:
      IsBlank(
         LookUp(
            'WSI Completed Inspections',
            Status = "Saved" && Site = 'Site Name'.Text
         ).'Site Name'
      )
   },
   Filter(
      'WSI Completed Inspections',
      Section = Lbl_Sect1.Text &&
      (
         _NoMatch || 
         Status = "Saved" && Site = 'Site Name'.Text
      )
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[Fess67]

Hi @WarrenBelz

that gives the same result in that the field for the question number returns the field for Site.  The field is set to ThisItem.QuestionNumber but clearly returns the Site name. <edit>  I expect it to return the question number which in this case is from 1 to 9 as that is how many questions are in this section.  It returns the question text correctly for each question, just not the number

[WarrenBelz]

Hi @Fess67 ,

OK - I see the issue now - you cannot have a gallery with conditional data sources - if you do not get errors, it will likely have unexpected results as it needs consistent data on any output.

Also where are you located - your displayed city is interesting.

[Fess67]

@WarrenBelz 

I am trying to build what I thought was a simple audit app.  Basic principle is there are a number of questions to be answered so the user just needs to select a radio button and add a comment if appropriate for each question.

Due to other commitments it is highly unlikely that all questions will be answered in one session so there is a need to be able to save progress and return later (status = saved).  Only once all questions have been answered will the patch then save as submitted (status = submitted)

So what I thought I would do is simply patch via 2 buttons.  SAVE and SUBMIT.  Mutually exclusive Display modes, if all questions answered, SUBMIT, else SAVE.

There are 2 data sources.  1 for new inspections which is the list of questions, and one for saved inspections, which is the completed inspections list filtered for Status = saved.

I have 99% of it written but have come up against this issue.  Bugging me because I cannot see why the question number column would throw an error when the other columns in the list appear.  I have tried text and number column types but issue persists.

The inspection is broken into 9 sections and I am using containers to separate it all and make the GUI part of it more manageable.  Each section has it's own gallery of questions and I can make it all work with just the one data source but not with both which leads me to think the If statement is the issue yet it is a simple IF.

Moved from Brisbane to Sydney but look after all our sites on the east coast.

[WarrenBelz]

@Fess67 ,

OK - assuming all the fields in both lists are the same (and I cannot test this), but I am trying to get the alternative logic away from the main query.

With(
   {
      _Data:
      With(
         {
            _Insp:
            Filter(
               'WSI Completed Inspections',
               Section = Lbl_Sect1.Text &&
               Site = 'Site Name'.Text
            ),
            _Questions:
            Filter(
               'WSI Questions',
               Section = Lbl_Sect1.Text
            ),
            _Status:
            !IsBlank(
               LookUp(
                  'WSI Completed Inspections',
                  Status = "Saved" && Site = 'Site Name'.Text
               ).Status
            )
         },
         If(
            _Status,
            _Insp,
            _Questions
         )
      )
   },
   _Data
)

BTW I live in your target location.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[Fess67]

Thanks @WarrenBelz  for taking the time to help.  Yeah I knew you were around there - not the first time I have sought your help or used your other posts to solve issues  🙂

So this approach has resulted in the same odd behaviour where I cannot display the QuestionNumber in the gallery yet I can display all other SP list columns.  I am going to strip it back to basics, build it back up and see where it breaks  🙂

Thanks for your help though, I always take the approach that it must be an issue if people like yourself do not come up with the solution quickly  😄