ForAll function - Improve time of execution?

[JérômeLebon]

Hello all,

I created an app for the stock management of my company. 

I meet some problem to run it smoothy.

My function ForAll and patch take long time of execution. 

Do you have a trick to improve this ? 

ForAll(
Gallery6_1.AllItems;
Patch(
'Registre mouvement de stock';
{
Title: User().FullName;
Date:DateAdd( Now(); 1; Hours );
Item: Text(Item);
SAP: Text(SAP);
'Quantité in': Value(IN1.Text);
'Quantité out':Value(OUT1.Text);
Mouvement: If(IsBlank(Value(IN1.Text));"Sortie de stock";"Entrée de stock");
Commentaire:Text(TextInput5);
'Fichier annexe':UploadedImage1.Image
})
)
;;

ForAll(
Gallery6_1.AllItems;
Patch(
'Stock Flémalle';
LookUp('Stock Flémalle';Item = Intitulé);
{
'Stock Actuel':
If(IsBlank(Value('Quantité out'));LookUp('Stock Flémalle';Text(Item) = Intitulé;Value('Stock Actuel') + 'Quantité in')
;LookUp('Stock Flémalle';Text(Item) = Intitulé;Value('Stock Actuel') - 'Quantité out'))
}
)
)

Thank in advance!

[LaurensM]

Hi @JérômeLebon from a quick glance the ForAlls don't seem to be dependent on each other. Is this correct?

Should this be the case, you could run the ForAlls concurrently:

ForAll(
Gallery6_1.AllItems;
    Patch(
    'Registre mouvement de stock';
        {
        Title: User().FullName;
        Date:DateAdd( Now(); 1; Hours );
        Item: Text(Item);
        SAP: Text(SAP);
        'Quantité in': Value(IN1.Text);
        'Quantité out':Value(OUT1.Text);
        Mouvement: If(IsBlank(Value(IN1.Text));"Sortie de stock";"Entrée de stock");
        Commentaire:Text(TextInput5);
        'Fichier annexe':UploadedImage1.Image
        }
    );;
    Patch(
    'Stock Flémalle';
        LookUp('Stock Flémalle';Item = Intitulé);
        {
        'Stock Actuel':
        If(IsBlank(Value('Quantité out'));LookUp('Stock Flémalle';Text(Item) = 
        Intitulé;Value('Stock Actuel') + 'Quantité in')
        ;LookUp('Stock Flémalle';Text(Item) = Intitulé;Value('Stock Actuel') - 'Quantité out'))
        }
    )
)

I hope this helps!

[JérômeLebon]

Hi @LaurensM , thank for your answer! 

I have modified as you mentioned and it improved the execution time a bit, thanks!

There are nothing more to improve a bit more the process? 

Currently, the process lasts +-1min for 10 items.

[jefmeyer]

What's your data source?  Have you tried using Monitor to see where the delay is occurring?

[LaurensM]

@JérômeLebon 1min for 10 records does seem rather slow.

It might be worth looking into the reason of the delay: see Monitor or by manually removing fields (e.g. Image) and looking at the loading difference.

In case of bigger ForAll() statements or large bulk patching, I tend to go for Power Apps triggered flows. These flows can run in the back-end and don't impact the app as heavily (no delay for the user, no loading spinner, no performance impact in the app...).

[LaurensM]

@JérômeLebon now that I further analyse my previous code.

That was a good first step but true concurrency will be reached by the code below:

Concurrent(
    ForAll(
    Gallery6_1.AllItems;
        Patch(
        'Registre mouvement de stock';
            {
            Title: User().FullName;
            Date:DateAdd( Now(); 1; Hours );
            Item: Text(Item);
            SAP: Text(SAP);
            'Quantité in': Value(IN1.Text);
            'Quantité out':Value(OUT1.Text);
            Mouvement: If(IsBlank(Value(IN1.Text));"Sortie de stock";"Entrée de stock");
            Commentaire:Text(TextInput5);
            'Fichier annexe':UploadedImage1.Image
            }
        )
    );
    ForAll(
    Gallery6_1.AllItems;
        Patch(
        'Stock Flémalle';
        LookUp('Stock Flémalle';Item = Intitulé);
            {
            'Stock Actuel':
            If(IsBlank(Value('Quantité out'));LookUp('Stock Flémalle';Text(Item) = 
            Intitulé;Value('Stock Actuel') + 'Quantité in')
            ;LookUp('Stock Flémalle';Text(Item) = Intitulé;Value('Stock Actuel') - 'Quantité out'))
            }
        )
    )
)

What effect does this have on the performance?

[JérômeLebon]

Hello both, 

Thank you for the time you give it to me! 

@jefmeyer , I work only with sharepoint list. I never used the monitor (It's a new world for me 😁).
I have checked this and I'll launch a session with the main user to see delay and time of action (this afternoon or tomorrow).

@LaurensM I only do flow to send notifications. I didn't know that a flow can run a patch behind the app. I'll find out about it, thanks! 

I'm going to try your code and I keep you updated.

Thank you !!