ForAll patch Error handling

[Hasini]

Hello all,

I am creating bulk records from collections to target entity

when i am inserting each record to the target entity(InventorycountingJournalLines) if there is no error in each record insertion i will update the entity(CountingJournalItems) field value for each successfull insertion in target entity record

when there is an error , it needs to navigate the error screen without updating the countingJournalItems for that particular line

Below i have attached the code

ForAll(
    colSelectedItems,
    Patch(
        InventoryCountingJournalLines,
        Defaults(InventoryCountingJournalLines),
        {
            JournalNumber: cmbJournalHeader.Selected.Journal,
            ItemNumber: ItemId,
            WorkerPersonnelNumber: PersonnelNumber,
            InventorySiteId: InventSiteId,
            WarehouseId: InventLocationId,
            ProductColorId: InventColorId,
            ProductStyleId: InventStyleId,
            ProductSizeId: InventSizeId,
            ProductConfigurationId: configId,
            WarehouseLocationId: wMSLocationId,
            ItemBatchNumber: inventBatchId,
            ItemSerialNumber: inventSerialId,
            CountedQuantity: Counted,
            LineNumber: 0,
            dataAreaId: dataAreaId
        }
    );
    If(
        IsEmpty(Errors(InventoryCountingJournalLines)),
        Patch(
            CountingJournalItems,
            First(
                Filter(
                    CountingJournalItems,
                    LineNum = LineNum
                )
            ),
            {
                IsCreated: 1,
                JournalId: cmbJournalHeader.Selected.Journal
            }
        )
    );
    If(
        Not(IsEmpty(Errors(InventoryCountingJournalLines))),
        Navigate(
            ErrorScreen,
            ScreenTransition.None,
            {errorMessage: First(Errors(InventoryCountingJournalLines)).Message}
        )
    );
    
);

Consider the scenario

there are 2 records in collection . 1 st record contains error , 2nd record does not contain error

it navigates to error screen and creates the  2nd record in entity but the value is not updating in the countingJournalItems since it contains error

My need

Insert all the records into the target entity and updates the countingjournalItems entity  for each successful insertion of target entity

when there is an error it just navigates the error screen without updating the countingjournalitems for that particular line(record)

[Carsten_Growth]

A patch itself is always considered as a transaction. If there´s an error inside the transaction, the whole transaction is going to be reverted. If you combine your patch function inside a ForAll, you need to consider each of your patch items to be a single transaction only, so if error, only stop this transaction, but not the others. You can check what happens inside your ForAll(...) if you monitor the application using Monitor.

[v-siky-msft]

Hi @Carsten_Growth ,

You should navigate to error screen after the end of the ForAll loop, use a collection to store all error information during the ForAll loop. 

If you want to show the error message in error screen, just reference the values from the error collection. 

Please try this code:

Clear(ColErrors);
ForAll(
    colSelectedItems,
    Patch(
        InventoryCountingJournalLines,
        Defaults(InventoryCountingJournalLines),
        {
            JournalNumber: cmbJournalHeader.Selected.Journal,
            ItemNumber: ItemId,
            WorkerPersonnelNumber: PersonnelNumber,
            InventorySiteId: InventSiteId,
            WarehouseId: InventLocationId,
            ProductColorId: InventColorId,
            ProductStyleId: InventStyleId,
            ProductSizeId: InventSizeId,
            ProductConfigurationId: configId,
            WarehouseLocationId: wMSLocationId,
            ItemBatchNumber: inventBatchId,
            ItemSerialNumber: inventSerialId,
            CountedQuantity: Counted,
            LineNumber: 0,
            dataAreaId: dataAreaId
        }
    );
    If(
        IsEmpty(Errors(InventoryCountingJournalLines)),
        Patch(
            CountingJournalItems,
            First(
                Filter(
                    CountingJournalItems,
                    LineNum = LineNum
                )
            ),
            {
                IsCreated: 1,
                JournalId: cmbJournalHeader.Selected.Journal
            }
        ),
        Collect(ColErrors,First(Errors(InventoryCountingJournalLines)))
    )  
);
    If(
        Not(IsEmpty(ColErrors)),
        Navigate(
            ErrorScreen,
            ScreenTransition.None         
        )
    )

Hope this helps.

Sik

[Hasini]

Hi sik,

thanks for the reply

I have implemented the same code as you posted

Records are not updated in the entity countingJournalItems even if the record is inserted into the entity InventoryCountingjournalItems

[v-siky-msft]

Hi @Hasini ,

I got it, you should locate errors on specific records. If you don't specify the record, the Errors function returns errors for the entire data source.

Please try to use LookUp function to locate the error on just the patched record.

Code: 

Clear(ColErrors);
ForAll(
    colSelectedItems,
    Patch(
        InventoryCountingJournalLines,
        Defaults(InventoryCountingJournalLines),
        {
            JournalNumber: cmbJournalHeader.Selected.Journal,
            ItemNumber: ItemId,
            WorkerPersonnelNumber: PersonnelNumber,
            InventorySiteId: InventSiteId,
            WarehouseId: InventLocationId,
            ProductColorId: InventColorId,
            ProductStyleId: InventStyleId,
            ProductSizeId: InventSizeId,
            ProductConfigurationId: configId,
            WarehouseLocationId: wMSLocationId,
            ItemBatchNumber: inventBatchId,
            ItemSerialNumber: inventSerialId,
            CountedQuantity: Counted,
            LineNumber: 0,
            dataAreaId: dataAreaId
        }
    );
    If(
        IsEmpty(Errors(InventoryCountingJournalLines, LookUp(InventoryCountingJournalLines, ItemNumber=ItemId,WorkerPersonnelNumber= PersonnelNumber,ItemBatchNumber= inventBatchId,ItemSerialNumber= inventSerialId))),
        Patch(
            CountingJournalItems,
            First(
                Filter(
                    CountingJournalItems,
                    LineNum = LineNum
                )
            ),
            {
                IsCreated: 1,
                JournalId: cmbJournalHeader.Selected.Journal
            }
        ),
        Collect(ColErrors,First(Errors(InventoryCountingJournalLines, LookUp(InventoryCountingJournalLines, ItemNumber=ItemId,WorkerPersonnelNumber= PersonnelNumber,ItemBatchNumber= inventBatchId,ItemSerialNumber= inventSerialId))))
    ) 
);
    If(
        Not(IsEmpty(ColErrors)),
        Navigate(
            ErrorScreen,
            ScreenTransition.None        
        )
    )

Sik

[Hasini]

Hi sik,

Thanks for the reply

One more problem with the below If function is that when after inserting the record in InventoryCountingJournalLine and trying to update in CountingJournalItems 

In the if funciton does not takes the collect statement in the else part .The error is saying "Expecting record value" since we use patch in if part. so i moved the collect statment in separate condition. but where the error is not capturing

ForAll(
    colSelectedItems,
    Patch(
        InventoryCountingJournalLines,
        Defaults(InventoryCountingJournalLines),
        {
            JournalNumber: cmbJournalHeader.Selected.Journal,
            ItemNumber: ItemId,
            WorkerPersonnelNumber: PersonnelNumber,
            InventorySiteId: InventSiteId,
            WarehouseId: InventLocationId,
            ProductColorId: InventColorId,
            ProductStyleId: InventStyleId,
            ProductSizeId: InventSizeId,
            ProductConfigurationId: configId,
            WarehouseLocationId: wMSLocationId,
            ItemBatchNumber: inventBatchId,
            ItemSerialNumber: inventSerialId,
            CountedQuantity: Counted,
            LineNumber: 0,
            dataAreaId: dataAreaId
        }
    );
   If(IsEmpty(Errors(InventoryCountingJournalLines)),
    Patch(
           CountingJournalItems,
            First(
                Filter(
                    CountingJournalItems,
                    LineNum = colSelectedItems[@LineNum]
                )
            ),
            {
                IsCreated: "1",
                JournalId: cmbJournalHeader.Selected.Journal
            }
        
    ))//,Collect(ColErrors,First(Errors(InventoryCountingJournalLines))));
    If (
        Not(IsEmpty(Errors(InventoryCountingJournalLines))),
        Collect(
            ColErrors,
            First(Errors(InventoryCountingJournalLines)),colSelectedItems[@LineNum]
        )
    )
);
If(
    Not(IsEmpty(Errors(InventoryCountingJournalLines))),
    Navigate(
        ErrorScreen,
        ScreenTransition.None,
        {locErrorMessage: First(Errors(InventoryCountingJournalLines))}
    )
)

[v-siky-msft]

Hi @Hasini 

Maybe missing a semicolon.

Sik

[Hasini]

Hi sik,

Please refer the following screenshot

[v-siky-msft]

Hi @Hasini ,

Sik

[Hasini]

Hi Sik,

I am getting the same error even after removing the semicolon . no luck, its expecting record value