ForAlll iteration issues for each instance when using a dropdown

[rob468]

Hello All,

For some reason the code below doesn't update each instance of of the CheckedItems. Please take a look and let me know where you think I'm going wrong.

ForAll(CheckedItems As C,

Patch(BatchTrack, LookUp(BatchTrack, 'Batch ID'=DataCardValue16_2.Text && 'Wafer ID'= C.'Wafer ID'),
        {
        State: {Value: "TrackIn"},
        OpCode: Value(NextCount),
        Box: C.Box, //Boxdrop.Selected.Box,
        'Slot No': C.SlotNo, //SlotDown.Selected.SlotNumber,
        'Step Name': NextStep
        }
        ));

I think the issue might be referencing a drop down list for each instance within a gallery, I left comments next to the dropdown list to highlight my confusion. 

Thanks for your help.

Rob 

[rob468]

Hi @WarrenBelz 

Please see the screenshot below. The SlotDown list is used to select a number (but of type text). The SlotDown list is populated by SharePoint list named SlotNumber which has a text column also called SlotNumber. 

All columns are of type text (even if containing numbers). I couldn't get your suggestion of 'Slot No': C.SlotNo.Value to work.

Thank you

Rob

[WarrenBelz]

@rob468 ,

OK - this is getting confusing on what should be a very simple matching of data types. You have already said that both fields are Single Line of Text fields - so can you please confirm that 'Slot No' and Box are this field type in BatchTrack. The next thing is their structure in CheckedItems (I assume this is a Collection) - how do you collect this data ?

[rob468]

@WarrenBelz 

Thank you for pointing me in this direction. I've come to realize that the collection might be the problem. I currently have

Collect(CheckedItems,ThisItem) 

This is in the OnCheck action in the gallery checkbox.

After reviewing the collection in table format with two items checked, I can see that any ForAll only refers to the columns in the BatchTrack SharePoint list. My question becomes how to integrate the drop downs of Box and Slot No into the collection so each instance of the ForAll loop references the same line in the collection.

Thank you.

[WarrenBelz]

@rob468 ,

Firstly having a List and Field name the same is a recipe for Ambiguity and this may be part of your issue. You are correct that .Value is not appropriate for Text columns. Also what exactly is ThisItem you are sending to the collection ?

[rob468]

@WarrenBelz 

ThisItem references one line in the gallery where the tick check box is located. The gallery is filtered to show only Items with which meet a certain criterion. The gallery shows the WaferID field so the user can select the relevant wafers to be actioned, additional inputs are the drop-down lists. This creates the example gallery below.

If I make the BoxNo and SlotNo in BatchTrack a choice field will this aid the issue?

Thank you.

[rob468]

@WarrenBelz 

To add, I would prefer to use separate drop-downs as these are generated from SharePoint lists which can be easily modified without editing the app.

[WarrenBelz]

@rob468 ,

Assuming CheckedItems is a collection, can you please post a screenshot of the contents/structure

[rob468]

@WarrenBelz 

I replaced Box in BatchTrack to BoxColBT which is now a choice selection with the selections in a different SharePoint list named Box.

This is the collection for 2 selected items, not all fields are shown as there are many which have no value to this session.

Thank you.

[WarrenBelz · Accepted solution]

@rob468 ,

This is getting harder and I really need you to have a think about the structure of that collection. You have two fields (both tables) with Box in the name (but not called Box) and SlotNo has no values in it, so I do not know what type of field it is. You need to match the data structure of the collection with the correct field names to the target list you are patching to.

[SadFox]

hi @rob468 

can u try the updateif

ForAll(CheckedItems As C,

UpdateIf(BatchTrack,'Batch ID'=DataCardValue16_2.Text && 'Wafer ID'= C.'Wafer ID',
        {
        State: {Value: "TrackIn"},
        OpCode: Value(NextCount),
        Box: C.Box, //Boxdrop.Selected.Box,
        'Slot No': C.SlotNo, //SlotDown.Selected.SlotNumber,
        'Step Name': NextStep
        }
        ));