Functions after Forall Patch not working

[TheDonSimon]

I have a forall patch function in my app, I know its slow and not the best performance however, the fields i am updating require a lookup from a different database so this fits my purpose the best. the problem is, any functions after the forall result in the patch returning blank values. The below formula works fine however, as mentioned any functions added after it leads to the patch resulting in blank results. 

I have tried the forall patch by itself and not with concurrent and the same thing happens, any function after it seems to result in blank returns.

Concurrent(

        ForAll(

        StoreItems,Patch(

            'IM PowerApp Testing Data',ThisRecord,

            {

                Price: Value(

                    LookUp(

                        'catalogue_data',

                        itemcode = 'Item ID'

                    ).purchaseprice

                ),

                UOM: LookUp(

                    'catalogue_data',

                    itemcode = 'Item ID'

                ).uomdescription,

                QOM: Value(

                    LookUp(

                        'catalogue_data',

                        itemcode = 'Item ID'

                    ).qom

                ),

                Description: LookUp(

                    'catalogue_data',

                    itemcode = 'Item ID'

                ).description

            }

        )

    ),

    Patch(

        'IVM Transaction Log',

        Defaults('IVM Transaction Log'),

        {

            Title: "StoreNxsUpdate",

            User: User().FullName,

            TimeStamp: Now(),

            Reqpoint: First(ReqpointInfo).SelectedReqpoint,

            StoreID: varStore

        }

    )

)

If anyone has any help that would be much appreciated and any tips for performance as well or alternative methods. 

[rzuber]

Are you trying to patch to the IVM Transaction Log for each record in the ForAll() data source?

I'm a little confused about what the issue is. Can you clarify? Maybe provide some screenshots?

Her's a method to clean up that ForAll a bit..

ForAll(
    StoreItems,
    Patch(
        'IM PowerApp Testing Data',
        ThisRecord,
        With(
            {
                _catData: LookUp(
                    'catalogue_data',
                    itemcode = 'Item ID'
                )
            },
            {
                Price: Value(_catData.purchaseprice),
                UOM: _catData.uomdescription,
                QOM: Value(_catData.qom),
                Description: _catData.description
            }
        )
    )
)

If you're trying to patch both during the ForAll(), you want the Concurrent() inside the ForAll().. again, not sure here from your description.

ForAll(
    StoreItems,
    Concurrent(
        Patch(
            'IM PowerApp Testing Data',
            ThisRecord,
            With(
                {
                    _catData: LookUp(
                        'catalogue_data',
                        itemcode = 'Item ID'
                    )
                },
                {
                    Price: Value(_catData.purchaseprice),
                    UOM: _catData.uomdescription,
                    QOM: Value(_catData.qom),
                    Description: _catData.description
                }
            )
        ),
        Patch(
            'IVM Transaction Log',
            Defaults('IVM Transaction Log'),
            {
                Title: "StoreNxsUpdate",
                User: User().FullName,
                TimeStamp: Now(),
                Reqpoint: First(ReqpointInfo).SelectedReqpoint,
                StoreID: varStore
            }
        )
    )
)

After looking at this example, I can't see any reason why you would want to do it this way (unless ReqpointInfo is a column in StoreItems?).. but I am still confused. 😉

---

Or is this a situation where you need the second patch to happen after the ForAll?

If so, you probably want it like:

ForAll(
    StoreItems,
    Patch(
        'IM PowerApp Testing Data',
        ThisRecord,
        With(
            {
                _catData: LookUp(
                    'catalogue_data',
                    itemcode = 'Item ID'
                )
            },
            {
                Price: Value(_catData.purchaseprice),
                UOM: _catData.uomdescription,
                QOM: Value(_catData.qom),
                Description: _catData.description
            }
        )
    )
);
Patch(
    'IVM Transaction Log',
    Defaults('IVM Transaction Log'),
    {
        Title: "StoreNxsUpdate",
        User: User().FullName,
        TimeStamp: Now(),
        Reqpoint: First(ReqpointInfo).SelectedReqpoint,
        StoreID: varStore
    }
)

[TheDonSimon]

I apologise for not explaining this well initially. Here's some context:

In the database 'IM PowerApp Testing Data', which contains a list of products, I need to update certain fields like price and description using data from `catalogue_data`. Additionally, I need to track user actions, which is why I'm using a patch to the transaction log.

I initially thought using the `Concurrent` function would be faster since both patches (to the product data and the transaction log) don't need to be executed sequentially; they can run simultaneously.

However, I'm encountering a problem. When I place any function after the `ForAll` patch, the information patched to 'IM PowerApp Testing Data' returns blank. In contrast, if there is nothing after the `ForAll` patch, it works correctly.

My goal is to add a loading screen using the `UpdateContext` function to show and hide a loading spinner once the patch is completed. The final version should look like this:

UpdateContext({Loading:true});
Concurrent(
        ForAll(
        StoreItems,Patch(
            'IM PowerApp Testing Data',ThisRecord,
            {
                Price: Value(
                    LookUp(
                        'staging.nxs_catalogue_preprocessing',
                        itemcode = 'Item ID'
                    ).purchaseprice
                ),
                UOM: LookUp(
                    'staging.nxs_catalogue_preprocessing',
                    itemcode = 'Item ID'
                ).uomdescription,
                QOM: Value(
                    LookUp(
                        'staging.nxs_catalogue_preprocessing',
                        itemcode = 'Item ID'
                    ).qom
                ),
                Description: LookUp(
                    'staging.nxs_catalogue_preprocessing',
                    itemcode = 'Item ID'
                ).description
            }
        )
    ),
    Patch(
        'IVM Transaction Log',
        Defaults('IVM Transaction Log'),
        {
            Title: "StoreNxsUpdate",
            User: User().FullName,
            TimeStamp: Now(),
            Reqpoint: First(ReqpointInfo).SelectedReqpoint,
            StoreID: varStore
        }
    )
);UpdateContext({Loading:false})

But whenever I add anything after the `ForAll` patch, the data returned is blank, as shown:
Using the desired code this is the output

Before:

After:

Whereas if there is nothing after it, the data updates correctly if there was a price change:

Concurrent(
        ForAll(
        StoreItems,Patch(
            'IM PowerApp Testing Data',ThisRecord,
            {
                Price: Value(
                    LookUp(
                        'staging.nxs_catalogue_preprocessing',
                        itemcode = 'Item ID'
                    ).purchaseprice
                ),
                UOM: LookUp(
                    'staging.nxs_catalogue_preprocessing',
                    itemcode = 'Item ID'
                ).uomdescription,
                QOM: Value(
                    LookUp(
                        'staging.nxs_catalogue_preprocessing',
                        itemcode = 'Item ID'
                    ).qom
                ),
                Description: LookUp(
                    'staging.nxs_catalogue_preprocessing',
                    itemcode = 'Item ID'
                ).description
            }
        )
    ),
    Patch(
        'IVM Transaction Log',
        Defaults('IVM Transaction Log'),
        {
            Title: "StoreNxsUpdate",
            User: User().FullName,
            TimeStamp: Now(),
            Reqpoint: First(ReqpointInfo).SelectedReqpoint,
            StoreID: varStore
        }
    )
)

[TheDonSimon · Accepted solution]

I've solved the issue, though I'm not sure if it’s a bug or something related to the `patch` function. After isolating the code, I found that the problem was with how `lookup` was used within the `patch` function. It seems PowerApps didn't like using `lookup` with the format `).desired`. When I changed it to `,desired)`, it worked perfectly.

For some reason, when using `patch` and `lookup` with the `).desired` format, followed by another function after `patch`, the `lookup` result ended up being blank, even though `lookup` was correctly obtaining a value. This behavior is quite strange.