Gallery patch ends with additional line in sharepoint entry with blank info

[nchandran]

Hi, I'm having issues with gallery patching where whenever the user order the items and saved , the data gets saved into the share point list however there is an additional line item saved in the share point list which is empty. Before arriving to the screen where the shopping cart lies, the menu button leading to the screen has a clear collect syntax. Screenshots below.

[WarrenBelz]

@nchandran ,

There is something else wrong here - a Patch with Defaults() is a standard command that produces one record (and I have never seen it do anything else in thousands of records across multiple apps).

What is the exact code (please post in Text) that you are using on this Patch and if you are seeing these extra lines in a gallery, what are the Items of the gallery?

[nchandran]

@WarrenBelz 

So this screen contains one gallery and one form.

Code for Patch on the save button in the gallery is  (to create a new line item )  Patch(WDSConsumCollection,Defaults(WDSConsumCollection),{WDSWC:InputWC.Text, WDSBrand:InputBrand.Text, WDSPro:InputPro.Text, WDSFea:InputFea.Text, WDSShift:WDSGShiftDropdown.Selected.Value, WDSDay:WDSGDayDropdown.Selected.Value, WDSDate:InputDate.SelectedDate, WDSWPS:InputWPS.Text, WDSClass:InputWClass.Text, WDSDia:InputDia.Text, WDSHeat:InputHeat.Text, WDSFClass:InputFClass.Text, WDSMetal:WDSGMetalDropdown.Selected.Value,WDSFBrand:InputFBrand.Text, WDSFLotNo:InputFLotNo.Text, WDSPreTemp:InputPreTemp.Text, WDSInterTemp:InputTemp.Text, WDSGasType:WDSGTDropdown.Selected.Value, WDSGasFlow:InputGFlow.Text, WDSWLayer:InputWlayer.Text, WDSCurrent:InputCurrent.Text, WDSVolt:InputVolt.Text, WDSTravel:InputTravel.Text, WDSWFR:InputWFeedRate.Text, WDSHInput:WDSHeatInput.Text});Collect(WDSConsumCollection, {WDSWC:"", WDSBrand:"", WDSPro:"", WDSFea:"", WDSShift:"", WDSDay:"", WDSDate:"", WDSWPS:"", WDSClass:"", WDSMetal:"",WDSDia:"", WDSHeat:"", WDSFClass:"", WDSFBrand:"", WDSFLotNo:"", WDSPreTemp:"", WDSInterTemp:"", WDSGasType:"", WDSGasFlow:"", WDSWLayer:"", WDSCurrent:"", WDSVolt:"", WDSTravel:"", WDSWFR:"", WDSHInput:""})

Items on gallery -> WDSConsumCollection

After the user has click the save button(patch), he clicks on the submit button ,clicking the submit button executes the form On success property as shown below.

[WarrenBelz]

@nchandran ,

That code produces two new records in WDSConsumCollection - one with the input and a blank one - so your problem is right there.

I assume the user is completing the blank one then instead of saving that record, it produces two new ones, If you want to save the current one (blank one now filled out), put the save icon inside the gallery and refer to

Patch(
   WDSConsumCollection,
   ThisItem,
   { 
      . . . . .
      . . . . . 
   }
);
Collect( . . .  .

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[nchandran]

@WarrenBelz  Now the Patch Icon is inside the gallery and the code changed to what you have advised

, patched and then upon submitting now data is saved as one line item with data and one empty line item. 

Still getting one empty line item.

Do you think its got to do with the New form onsuccess property code? Datasource for the form is WDS the (primary sharepoint), the onsuccess property is also patching by taking the data from the WDSConsumCollection and patching into the secondary sharepoint list WDSOperation..im just explaining to help you understand and so could advise me. Here is the code for your reference, perhaps the clue is there.

ForAll(WDSConsumCollection, Patch(WDSOperations, Defaults(WDSOperations), {Workcentre:WDSWC, Brand:WDSBrand, WeldProcess:WDSPro, WeldFeature:WDSFea, Shift:WDSShift, DayNight:WDSDay, Date:Value(WDSDate), WPS:WDSWPS, WireClass:WDSClass, WeldMetal:WDSMetal, WireDiameter:WDSDia, WireHeat:WDSHeat, FluxesClass:WDSFClass, FluxesBrand:WDSFBrand,
FluxesLotno:WDSFLotNo, PreheatTemp:WDSPreTemp, InterpassTemp:WDSInterTemp, GasType:WDSGasType, GasFlowrate:WDSGasFlow, WeldLayer:WDSWLayer, Current:WDSCurrent, Volt:WDSVolt, TravelSpeed:WDSTravel,
WireFeedrate:WDSWFR, HeatInput:WDSHInput, MasterID:NewWDS.LastSubmit.ID}))

[WarrenBelz · Accepted solution]

@nchandran ,

The problem you have as is a logic one (not a coding problem) - you are always creating a new blank record (with the Collect function) each time a user saves a record, so when you patch the gallery to the list, you will always have one blank record. This however should work providing the field WDSWC always has input in it (if not choose a fields that will have)

ForAll(
   Filter(   
      WDSConsumCollection,
      WDSWC <> ""
   ), 
   Patch(
   WDSOperations,  
   Defaults(WDSOperations),
   {
      . . .  .
   }
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[nchandran]

@WarrenBelz Yes the solution works i've set it on the another field and we are not getting the empty records.

Thank you soo much for your time and god bless.