Gallery patch ends with additional line in sharepoint entry with blank info

[nchandran]

Hi, I'm having issues with gallery patching where whenever the user order the items and saved , the data gets saved into the share point list however there is an additional line item saved in the share point list which is empty. Before arriving to the screen where the shopping cart lies, the menu button leading to the screen has a clear collect syntax. Screenshots below.

[WarrenBelz]

Hi @nchandran ,

You seem to have three saving actions there - one on the end of the gallery item, another using ForAll on the Gallery and then a SubmitForm.

Can you please explain what you are doing with these.

[nchandran]

Warren i actually followed the example from shane young on the shopping cart example, 

the gallery item patch is to add items one by one. For all is after submitting the form it will patch all the fields.

The clear collect on the menu button was to create the fields and clear them before the shopping  cart screen.

I tried removing clearcollect feature on the menu button but the patch got broken so Im not sure how to fix it.

oh by the way, the form submits data to sharepoint list A and the patch submits data to sharepoint list B. Sharepoint list A contains the user information and B contains the ordered items. I'm seeing the additional but empty line in sharepoint list B.

[nchandran]

@WarrenBelz HI Warren, do you have any suggestions to fix this issue. 

[WarrenBelz]

@nchandran ,

Firstly, let's concentrate on just the problem - can you please post (in Text) all the code you use to Patch/Interact with List B. Also what does the Gallery look like just before you Patch.

[nchandran]

Hi Warren,

This is the code for the button leading to the gallery: NewForm(NewWDS); ClearCollect(WDSConsumCollection, {WDSWC:"", WDSBrand:"", WDSPro:"", WDSFea:"", WDSShift:"", WDSDay:"", WDSDate:"", WDSWPS:"", WDSClass:"", WDSDia:"", WDSHeat:"",WDSMetal:"", WDSFClass:"", WDSFBrand:"", WDSFLotNo:"", WDSPreTemp:"", WDSInterTemp:"", WDSGasType:"", WDSGasFlow:"", WDSWLayer:"", WDSCurrent:"", WDSVolt:"", WDSTravel:"", WDSWFR:"", WDSHInput:""});Navigate(WelderNewWDS,ScreenTransition.Fade)

This is the code for the save button to add the line item into the gallery(sharepoint list B). Patch(WDSConsumCollection, ThisItem, {WDSWC:InputWC.Text, WDSBrand:InputBrand.Text, WDSPro:InputPro.Text, WDSFea:InputFea.Text, WDSShift:WDSGShiftDropdown.Selected.Value, WDSDay:WDSGDayDropdown.Selected.Value, WDSDate:InputDate.SelectedDate, WDSWPS:InputWPS.Text, WDSClass:InputWClass.Text, WDSDia:InputDia.Text, WDSHeat:InputHeat.Text, WDSFClass:InputFClass.Text, WDSMetal:WDSGMetalDropdown.Selected.Value,WDSFBrand:InputFBrand.Text, WDSFLotNo:InputFLotNo.Text, WDSPreTemp:InputPreTemp.Text, WDSInterTemp:InputTemp.Text, WDSGasType:WDSGTDropdown.Selected.Value, WDSGasFlow:InputGFlow.Text, WDSWLayer:InputWlayer.Text, WDSCurrent:InputCurrent.Text, WDSVolt:InputVolt.Text, WDSTravel:InputTravel.Text, WDSWFR:InputWFeedRate.Text, WDSHInput:WDSHeatInput.Text});Collect(WDSConsumCollection, {WDSWC:"", WDSBrand:"", WDSPro:"", WDSFea:"", WDSShift:"", WDSDay:"", WDSDate:"", WDSWPS:"", WDSClass:"", WDSMetal:"",WDSDia:"", WDSHeat:"", WDSFClass:"", WDSFBrand:"", WDSFLotNo:"", WDSPreTemp:"", WDSInterTemp:"", WDSGasType:"", WDSGasFlow:"", WDSWLayer:"", WDSCurrent:"", WDSVolt:"", WDSTravel:"", WDSWFR:"", WDSHInput:""})

On success property of the form upon submission : ForAll(WDSConsumCollection, Patch(WDSOperations, Defaults(WDSOperations), {Workcentre:WDSWC, Brand:WDSBrand, WeldProcess:WDSPro, WeldFeature:WDSFea, Shift:WDSShift, DayNight:WDSDay, Date:Value(WDSDate), WPS:WDSWPS, WireClass:WDSClass, WeldMetal:WDSMetal, WireDiameter:WDSDia, WireHeat:WDSHeat, FluxesClass:WDSFClass, FluxesBrand:WDSFBrand,
FluxesLotno:WDSFLotNo, PreheatTemp:WDSPreTemp, InterpassTemp:WDSInterTemp, GasType:WDSGasType, GasFlowrate:WDSGasFlow, WeldLayer:WDSWLayer, Current:WDSCurrent, Volt:WDSVolt, TravelSpeed:WDSTravel,
WireFeedrate:WDSWFR, HeatInput:WDSHInput, MasterID:NewWDS.LastSubmit.ID}))

Before patching the screen looks like this below, bottom half is how  the gallery looks like, i hope this information clears the air.

after patching the line item, the gallery looks like this. Upon submit button the gallery resets to normal.

[WarrenBelz]

Hi @nchandran ,

On the second piece at the end, replace

Collect(
   WDSConsumCollection,
   . . . . .

with

ClearCollect(
   WDSConsumCollection,
   . . . . .

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[nchandran]

@WarrenBelz i've changed the code to clearcollect however this broke the save button function, it cant create a line item on the shopping cart and In fact it resets the data in the gallery fields.  when we click the save button it should patch the current line and create a another new empty line for submission like below.

[WarrenBelz]

HI @nchandran ,

Put it back to Collect then - I cannot see your data or workflow intentions so have to try a few things.

The problem is that your code is valid (so I do not have to fix anything) and you are getting an unusual result (an extra record on what appears to be a single Patch). I did however now notice you are using a NewForm (not simply unbound controls and then referring to ThisItem. Instead of this try

Patch(
   WDSConsumCollection,
   Defaults(WDSConsumCollection),
   {
      . . . .  . .

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[nchandran]

@WarrenBelz  After following your suggestion, applying the change caused the patch to create three line items - one without data, one with data and empty line...all under the same master id as reference.

strangely the top line item in the gallery looks filled up when we patch but the share point list appears empty for that corresponding line item.