Internal error in the ForALL function when patching image

[Waywei]

I built a audit result tracking system with SP list and power apps, patch image to SP list in create UI works fine. While i met error when i pull the list content and try to re-edit.

I pull the list data and store into a collection and display the collection in a gallery, when gallery content been modified, collection would be updated with the onchange function. While when i patch the gallery into SP again, i met error below.

When i remove the image patch part in above code (DPA Image: img_DPA_1.Image), Forall(Patch) function works well with all text information.

Any one knows why is that?

[WarrenBelz]

Hi @Waywei ,

Can you please remember to post your code in Text as it saves re-typing here. This code is OCR'd, so please watch spelling. I am surprised it works properly in the ForAll as you need to refer to each record in the gallery. I also assume that the Image is being patched to an Image field in SharePoint and a separate image is in each (I assume an Image control) record in the gallery. Firstly try this

ForAll(
   gaLDPA_reedit 1.Allltems As _Data,
   Patch(
      'DPA Audit Record',
      Defaults(‘DPA Audit Record),
      {
         'Report ID': _Data.varReportID,
         Location: _Data.txtDPAGal01_Location_1.Text,
         'Audit Date': _Data.DatePicker_reedit_1.SelectedDate,
         Platform: _Data.txtDPAGal02_platform_1.Text,
         'Sub-category': _Data.txtDPAGal03_subcat_1.Text,
         ODM: varODM,
         'Focus item': _Data.txtDPAGal0l_focus_l.Text.
         'Audit Finding': _Data.txtDPAGal05_finding_1.Text,
         Remark: _Data.txtDPAGal06_remark_1.Text,
         'Start Date': _Data.txtDPAGal07_startdate_1.Text,
         Aging: _Data.txtDPAGal08_agingnum_1.Text,
         'DPA Image': _Data.img_DPA 1.Image
      }
   )
);

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[Waywei]

Hi Warren @WarrenBelz , Thanks for your quick support, but looks like it is not fixing the bug.

Refer to below after i modified the code as you mentioned,

Original code:

ForAll(galDPA_reedit_1.AllItems,Patch('DPA Audit Record',Defaults('DPA Audit Record'),{'Report ID':varReportID,Location:txtDPAGal01_location_1.Text,'Audit Date':DatePicker_reedit_1.SelectedDate,Platform:txtDPAGal02_platform_1.Text,'Sub-category':txtDPAGal03_subcat_1.Text,ODM:varODM,'Focus item':txtDPAGal04_focus_1.Text,'Audit Finding':txtDPAGal05_finding_1.Text,Remark:txtDPAGal06_remark_1.Text,'Start Date':txtDPAGal07_startdate_1.Text,Aging:txtDPAGal08_agingnum_1.Text,'DPA Image':img_DPA_1.Image}))

Further explain of the logic:

The collection relationship with gallery see below, i tried to patch pure text, the code works well, but met error when add image in forall-patch.

i use a AddMedia control to update the collection image, when the AddMediaButton_reDPA_1 been changed, the updateif will work to update the collection ReDPA_pic cell.

I got a same logic page to create DPA audit records, code is same, works fine, i dont know why it is not working when i do Re-edit.

UpdateIf(colreedit_DPA,ReDPA_ID=ThisItem.ReDPA_ID,{ReDPA_pic:UploadedImage_reDPA_1.Image})

Create Code for reference:

If(CountRows(DPA_2SPRaw)>0,ForAll(galDPA.AllItems,Patch('DPA Audit Record',Defaults('DPA Audit Record'),{'Report ID':lblReportID.Text,Location:txtDPAGal01_location.Text,Platform:txtDPAGal02_platform.Text,'Sub-category':txtDPAGal03_subcat.Text,ODM:drp_ODMselect.Selected.Value,'Focus item':txtDPAGal04_focus.Text,'Audit Finding':txtDPAGal05_finding.Text,Remark:txtDPAGal06_remark.Text,'Start Date':DTPkr_DPAGal07_SDt.SelectedDate,Aging:txtDPAGal08_agingnum.Text,'DPA Image':img_DPAupload.Image,'Audit Date':DatePicker_main.SelectedDate})));

[Waywei]

@WarrenBelz  I think i found a clue, although no matter i create or re-edit the patch send the image from a image control to SP image column.

But when i check the location where the image stored, they are different.

Create collection:

Re-edit:

[WarrenBelz]

Hi @Waywei ,

Firstly in a ForAll Patch, you need to refer to each record in the gallery - I have use an As statement with the variable _Data (you can call that whatever you want), but each control in the gallery needs to use it. You can also use ThisRecord here, but I have found As completely reliable. I have assumed ODM and the Date Picker are outside the gallery. I also note that the Image control in the gallery is RePDA_Pic (not IMG_DPAupload). You will note a different structure as well Patch(ForAll) instead of ForAll(Patch) - this is far more efficient performance wise.

If(
   CountRows(DPA_2SPRaw) > 0,
   Patch(
      'DPA Audit Record',
      ForAll(
         galDPA.AllItems As _Data,
         {
            'Report ID': _Data.lblReportID.Text,
            Location: _Data.txtDPAGal01_location.Text,
            Platform: _Data.txtDPAGal02_platform.Text,
            'Sub-category': _Data.txtDPAGal03_subcat.Text,
            ODM: drp_ODMselect.Selected.Value,
            'Focus item': _Data.txtDPAGal04_focus.Text,
            'Audit Finding': _Data.txtDPAGal05_finding.Text,
            Remark: _Data.txtDPAGal06_remark.Text,
            'Start Date': _Data.DTPkr_DPAGal07_SDt.SelectedDate,
            Aging: _Data.txtDPAGal08_agingnum.Text,
            'DPA Image': _Data.ReDPA_pic.Image,
            'Audit Date': DatePicker_main.SelectedDate
         }
      )
   )
);

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps