Lookup not working properly in ForAll?

[tundaka]

Hello everyone, I am fairly new in PowerApps so now, I don't know it's limitation or I just haven't found the solution.

I have a simple app that I want to do, basically it's a bulk upload tool of salary. My idea was to put it in a delimited text, and then delimit it in a gallery.

Here's my code in the upload button :

ForAll(
Gallery2.AllItems,
Patch(
'Salary Series',
Defaults('Salary Series'),
{'Employee ID':
LookUp(
Employees,
'Employee ID' = txt_employeeID.Text
)
},
{Value: Value(txt_Value.Text)}
)
)

it works, but it doesn't lookup the employee id, it only does it in the first row. (Employee ID is a Lookup column to Employees table). Hopefully someone could help me.

[TheRobRush]

ForAll( @RandyHayes  ) Randy is very good at explaining the ForAll loop in PowerApps. Hopefully he can drop by and provide the in depth explanation, but at the simplest level it is being used backwards here

[Gelos]

ForAll(
Gallery2.AllItems,
Patch(
'Salary Series',
Defaults('Salary Series'),
{'Employee ID':
LookUp(
Employees,
'Employee ID' = txt_employeeID.Text,(Give column name of emplyees yout want)
)
},
{Value: Value(txt_Value.Text)}
)
)

[Gelos]

I understand you  fetch employee id for employees  table. Am I correct. If I am correct. that above code will work.

[tundaka]

Yes, that is correct, I am fetching the employee id from the employee table. But sorry, what do you exactly mean by 

(Give column name of employees you want)

any column name or column coming from employee table? 

[RandyHayes]

@tundaka 

As @TheRobRush mentioned...

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  It is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance.

Your formula given should be the following:

Patch('Salary Series',
    ForAll(Gallery2.AllItems,
        {'Employee ID': LookUp(Employees, 'Employee ID' = txt_employeeID.Text, EmployeeID),
         Value: Value(txt_Value.Text)
        }
    )
)

Now, I am not entirely sure what it is that you want to do with delimiting the text in the Gallery...can you explain more about that?

[Gelos]

Sorry. I didn't notice properly. randy give the answer try it. It will work

[RandyHayes]

@Gelos 

Actually noticing that the Lookup is not specifying a value in the formula I provided.  It is corrected above and repeated here for clarity:

Patch('Salary Series',
    ForAll(Gallery2.AllItems,
        {'Employee ID': LookUp(Employees, 'Employee ID' = txt_employeeID.Text, EmployeeID),
         Value: Value(txt_Value.Text)
        }
    )
)

EmployeeID should be replaced with the name of the actual column with the information.

However, there is still the question of delimiting and the purpose thereof.

[tundaka]

Thank you for clarifying, yes I was actually thinking for the longest time that it works similarly as a For Loop.

The idea behind is we are looking for a solution for the client to bulk upload the employee salary in the easiest way. Some few options we had before was to have an excel file with a live connection, other one is just to teach them directly sql. But we are currently looking at this approach, where they concatenate the employee ID and the salary, paste it in the text box, then delimit, and then upload. 

I tried btw your code, it works, but same result as mine, it only does the look up for the first row. 

[Gelos]

Hi @RandyHayes  glad to meet you.

ForAll(
Gallery2.AllItems,
Patch(
'Salary Series',
Defaults('Salary Series'),
{'Employee ID':
LookUp(
Employees,
'Employee ID' = txt_employeeID.Text
)
},
{Value: Value(txt_Value.Text)}
)
)

he mentioned {value:value(txt_value.Text)} I thought it is second parameter so I write following code

ForAll(
Gallery2.AllItems,
Patch(
'Salary Series',
Defaults('Salary Series'),
{'Employee ID':
LookUp(
Employees,
'Employee ID' = txt_employeeID.Text,(coulumn of employeeid from employess table)
)
},
{Value: Value(txt_Value.Text)}
)
)

Please tell weather it is correct or not