Power Apps collection Patch creates duplicate rows in the sharepoint list with data from the last row of the collection

[cpill1220]

Newbie.  Confused.  Collection Creation:

NewForm(Form1);ClearCollect(ActionDetails, {Action: "", State: "", ItemType: "", ItemCode: "", Pieces: 0, SFBFt: 0, From: "", To: "", Remarks: "", ShowSave: true});Navigate(NewActivity,ScreenTransition.Cover)

Collection:

OnSuccess of Form1:

ForAll(ActionDetails, Patch(DailyActivityDetails, Defaults(DailyActivityDetails), {Action: ddAction.Selected, State: ddState.SelectedText, ItemType: ddIType.SelectedText, ItemCode: ddICode.SelectedText, Pieces: Value(tPieces.Text), SFBFt: Value(tSFBFt.Text), From: cbFrom.Selected.location, To: cbTo.Selected.location, Remarks: tRemarks.Text, MasterID: Form1.LastSubmit.ID}))

SharePoint List:

Could someone help me? Is this enough info to tell what I did wrong to cause the SharePoint list to create the exact number of rows from my collection, but with duplicate data from the last row/record of the Collection?

I GREATLY appreciate any help.

[RandyHayes]

@cpill1220 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  ForAll is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance - sorry there is no For Loop in PowerApps - that would be development!

Also - you are using SelectedText in your formula - this is a deprecated property and should be avoided.  Instead use the .Selected and the proper column name form your Selected record.  For the rest of the formula shown below, I will assume a Value column.

So your formula would be:

Patch(DailyActivityDetails, 
    ForAll(ActionDetails, 
       {Action: ddAction.Selected, 
        State: ddState.Selected.Value, 
        ItemType: ddIType.Selected.Value, 
        ItemCode: ddICode.Selected.Value, 
        Pieces: Value(tPieces.Text), 
        SFBFt: Value(tSFBFt.Text), 
        From: cbFrom.Selected.location, 
        To: cbTo.Selected.location, 
        Remarks: tRemarks.Text, 
        MasterID: Self.LastSubmit.ID
      }
   )
)

NEXT - are you stating that exactly prior to doing a SubmitForm(Form1), the Collection only has the two rows you showed and that after that, your list has three rows?

Also - What is your Submit formula?

Questions, questions 😁

[cpill1220]

Bless you so much Randy.  Very educational and helpful.  

The the number of records created after SubmitForm(Form1) in the List is always the same as the number of rows in the Collection.  The the data in all the created List records matches the last row of the Collection.  So I'll have 3 unique records in the Collection, and 3 duplicate records in the List that match the 3rd record of the Collection.

[RandyHayes]

@cpill1220 

Where are these values coming from?

In second look at your formula - it really doesn't make must sense as you are iterating in the ForAll on the collection, but all of your record values are referencing controls (i.e. ddAction).  Where are those controls??

I am guessing a gallery, but please confirm.

[cpill1220]

Yes, all the controls except MasterID are in a gallery.  

-ddAction is a dropdown with choices defined in the Items property

-ddState dropdown choices come from a sharepoint list with Items property:

Ungroup(
Table(
{Value: Blank()},
{Value: Distinct(Daily_Sheet_Filters, STATE)}
),
"Value"
)

-ddIType and ddICode choices come from same sharepoint list and have a 'cascading' items property formula

-tPieces, tSFBft, tRemarks ...single and multiline text inputs

-cbFrom and cbTo are combobox controls with a SQL connector datasource

I changed the order of Patch and ForAll in the OnSuccess formula with no error, but when I try to Selected.Value or Selected.Result on the State, there's an "Invalid argument type (Table). Expecting a Record Value." error

Same error on ItemType.  Here's the ddItemType control Items property formula:

Ungroup(
Table(
{Value: Blank()},
{Value: Distinct(
Filter(
Daily_Sheet_Filters,
STATE = ddState.Selected.Result
),
ITYPE
)}
),
"Value"
)

[RandyHayes]

@cpill1220 

So what is the collection???  If this is coming from a Gallery, there is no need for a collection!

Yes, you are going to get those errors because your formulas on the Items properties are not correct!

Your ddState control Items should be:

Ungroup(
    Table({Value: Table({Result: Blank()}) },
          {Value: Distinct(Daily_Sheet_Filters, STATE)}
    ),
    "Value"
)

Your previous formula making Value a Record AND a Table.  They both need to be tables to ungroup properly.

Then your ddItemType Items property should also be fixed:

Ungroup(
    Table({Value: Table({Result: Blank()}) },
          {Value: Distinct(Filter(Daily_Sheet_Filters, STATE = ddState.Selected.Result), ITYPE)}
    ),
    "Value"
)

You have to provide table to table with column to column records being identical, or else the Upgroup to add a Blank is not going to work properly.

However...before introducing these changes into the your Patch formula...I need to know about the Gallery and what part the collection plays in anything you are doing.

[cpill1220]

Need users to enter data into the below form.  The top 5 entries will populate a master sharepoint list when Form1 is submitted, with a unique record id.  The gallery entries need to populate the details sharepoint list, all with the same 'master id' that's generated Form1 submission.  

Thank you so much for the help.

[RandyHayes · Accepted solution]

@cpill1220 

Okay, so the collection is only needed as a basic "base" for the gallery.  You don't need to do anything special with it.  It just needs to have the primary key (ID) of the records in it (or blank if none).  Patch will do the rest.

So. this means you are referencing the wrong data when you Patch!

You are referencing the controls in the gallery in your Patch.  When you do that out of context of the gallery, all you will get is the last selected item in the gallery...THIS explains why you are seeing the same records repeated.

Your Formula needs the context of the Gallery!!

It should be:

Patch(DailyActivityDetails, 
    ForAll(yourGallery.AllItems, 
       {ID: ID, 
        Action: ddAction.Selected, 
        State: ddState.Selected.Value, 
        ItemType: ddIType.Selected.Value, 
        ItemCode: ddICode.Selected.Value, 
        Pieces: Value(tPieces.Text), 
        SFBFt: Value(tSFBFt.Text), 
        From: cbFrom.Selected.location, 
        To: cbTo.Selected.location, 
        Remarks: tRemarks.Text, 
        MasterID: Self.LastSubmit.ID
      }
   )
)

That is it!

Now, I notice you have some provisions for delete in your gallery - That needs to be addressed separately.  

[cpill1220]

YOU.HAVE.CHANGED.MY.LIFE!! 

Thank you Sir.

[RandyHayes]

@cpill1220 

LOL...happy to help!! 

There is still one "gotcha" in your scenario.  You have a delete icon in your gallery.  There needs to be some special actions to make that happen properly (i.e. remove from your datasource).  If the gallery is just showing what would be new records (i.e. you're not editing existing records), then all is good.  Otherwise, there are some other steps for that to work properly.

If that becomes an issue...just let me know!