Powerapp slow performance

[Ashok2]

I am writing below formula on icon of gallery , if multiple checkbox are checked it will update multiple item status as per last status , but if I click it , will take long  time to update item and get item invisible from gallery 

ForAll(
    RenameColumns(Filter(Scope_1.AllItems,Checkbox3_1.Value),"ID","ID1"),
    Patch(
        Scopes,
        LookUp(Scopes,ID=ID1),{ awrWFInProgress:true,
        Status:{Value:
            Switch(
                LookUp(Scopes,ID=ID1).Status.Value,
           "Submitted", "Supported by Manager",
                "Supported by  Manager", "Supported by L2",
                "Pending with L2","Supported by L2",
                 "Supported by L2","Supported by L3","Not Supported by L2","Supported by L3","Reviewed by L4","Supported by L3"
            )
        }

       
        }
    )
)

And same for below formulae where I am updating forms this also take around 16 seconds to update an navigate back to gallery 

Refresh(Scopes); If(
    !Form1Section.Valid,
// Then
    SubmitForm(Form1Section),     !Form1Section_2.Valid,
// Then
    SubmitForm(Form1Section_2),
// Else
    Patch(
        Scopes, SelectedItem, AddSingleForm_1.Updates, Form1Section.Updates, Form1Section_2.Updates
    );
   Navigate(MyItemsView)
);

Any help on this to make performance much better

[WarrenBelz]

Hi @Ashok2 ,

You are submitting a lot of data in both of these - in the first a lot of Patches and in the second two submits and a Patch.

The time taken will be subject to bandwidth available to the user's PC at the time and also the Server load at the other end.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Ashok2]

I am able to optimize my second Expression for submission of forms but how can I optimize first patch expression to increase performance ?

[WarrenBelz]

Hi @Ashok2 .

Yes, looking at the second one I now see it is actually three options so it is good you can improve it further.

In the first one, you are doing a Lookup and RenameColumns call to the data source every time you Patch. Assuming you always have less than 2000 items to patch (and you have set the limit to this if necessary) try this - you might possibly have to clean up some commas and brackets, but I am sure you will see the idea.

ClearCollect(
   colScopes,   
   RenameColumns(
      Scopes,
      "ID",
      "ID1"
   )
);
UpdateContext(
   {
      vValue:
      LookUp(
         Scopes,
         ID=ID1
      ).Status.Value
   }
);

ForAll(
   colScopes,
   Patch(
      Scopes,
      LookUp(Scopes,ID=ID1),
      { 
         awrWFInProgress:true,
         Status:
         {
            Value:
            Switch(
               vValue,
               "Submitted", "Supported by Manager",
               "Supported by  Manager", "Supported by L2",
               "Pending with L2","Supported by L2",
               "Supported by L2", "Supported by L3",
               "Not Supported by L2","Supported by L3",
               "Reviewed by L4","Supported by L3"
            )
         }
      }
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Ashok2]

I Tried this but getting error in filter statement  attached is screenshot

Filter(
Scopes,
Scope_1.AllItems,Checkbox3_1.Value
),
"ID","ID1"
)

[WarrenBelz]

Hi @Ashok2 ,

Sorry slight flaw in my logic. Do you have less than 2000 items in your list?

[Ashok2]

Yes it less then 2000

[WarrenBelz]

OK @Ashok2 ,

I will also amend original post so as to not confuse people reading it - ensure setting is changed to 2000 in Advanced Settings then 

ClearCollect(
   colScopes,   
   RenameColumns(
      Scopes,
      "ID",
      "ID1"
   )
);
UpdateContext(
   {
      vValue:
      LookUp(
         Scopes,
         ID=ID1
      ).Status.Value
   }
);

ForAll(
   colScopes,
   Patch(
      Scopes,
      LookUp(Scopes,ID=ID1),
      { 
         awrWFInProgress:true,
         Status:
         {
            Value:
            Switch(
               vValue,
               "Submitted", "Supported by Manager",
               "Supported by  Manager", "Supported by L2",
               "Pending with L2","Supported by L2",
               "Supported by L2", "Supported by L3",
               "Not Supported by L2","Supported by L3",
               "Reviewed by L4","Supported by L3"
            )
         }
      }
   )
)

- also check second variable - I cannot test it and cannot see your data. I am just trying to minimize the server calls by setting single values that do not require calling the data before Patching each cycle.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Ashok2]

yes i am getting error below ID1 , name isnt valid :this identifier recognized and i am also want to patch only items who are checked in check
UpdateContext(
{
vValue:
LookUp(
Scopes,
ID=ID1
).Status.Value

[WarrenBelz]

OK @Ashok2 ,

Without your code to test this on, I am "flying a bit blind" - I normally write "from inside out", testing each component as I go. What I am trying to do is see what can be done once instead of on each Patch. Looking at the complexity of what you are doing now, I believe possibly only the renaming can be done as below. Firstly, below I have not changed any of your code except this and you should now be querying a Collection and not the data source each time.

ClearCollect(
   colScopes,   
   RenameColumns(
      Scopes,
      "ID",
      "ID1"
   )
);

ForAll(
   colScopes,
   Patch(
      Scopes,
      LookUp(
         Scopes,
         ID=colScopes.ID1,
      ),
      { 
         awrWFInProgress:true,
         Status:
         {
            Value:
            Switch(
               LookUp(
               Scopes,ID=colScopes.ID1
               ).Status.Value,
               "Submitted", "Supported by Manager",
               "Supported by  Manager", "Supported by L2",
               "Pending with L2","Supported by L2",
               "Supported by L2","Supported by L3",
               "Not Supported by L2","Supported by L3",
               "Reviewed by L4","Supported by L3"
            )
         }
      }
   )
)

Second thought - not sure this for reasons above, but try this as well

ForAll(
   colScopes,
   Patch(
      Scopes,
      LookUp(
         Scopes,
         ID=colScopes.ID1,
      ),
      { 
         awrWFInProgress:true,
         Status:
         {
            Value:
            Switch(
               colScopes.Status.Value,
               "Submitted", "Supported by Manager",
               "Supported by  Manager", "Supported by L2",
               "Pending with L2","Supported by L2",
               "Supported by L2","Supported by L3",
               "Not Supported by L2","Supported by L3",
               "Reviewed by L4","Supported by L3"
            )
         }
      }
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.