Powerapp slow performance

[Ashok2]

I am writing below formula on icon of gallery , if multiple checkbox are checked it will update multiple item status as per last status , but if I click it , will take long  time to update item and get item invisible from gallery 

ForAll(
    RenameColumns(Filter(Scope_1.AllItems,Checkbox3_1.Value),"ID","ID1"),
    Patch(
        Scopes,
        LookUp(Scopes,ID=ID1),{ awrWFInProgress:true,
        Status:{Value:
            Switch(
                LookUp(Scopes,ID=ID1).Status.Value,
           "Submitted", "Supported by Manager",
                "Supported by  Manager", "Supported by L2",
                "Pending with L2","Supported by L2",
                 "Supported by L2","Supported by L3","Not Supported by L2","Supported by L3","Reviewed by L4","Supported by L3"
            )
        }

       
        }
    )
)

And same for below formulae where I am updating forms this also take around 16 seconds to update an navigate back to gallery 

Refresh(Scopes); If(
    !Form1Section.Valid,
// Then
    SubmitForm(Form1Section),     !Form1Section_2.Valid,
// Then
    SubmitForm(Form1Section_2),
// Else
    Patch(
        Scopes, SelectedItem, AddSingleForm_1.Updates, Form1Section.Updates, Form1Section_2.Updates
    );
   Navigate(MyItemsView)
);

Any help on this to make performance much better

[Ashok2]

@WarrenBelz 

Thanks but still error are there in for all , patch , but i got your way and trying to optimize it , 

the actual scenario is i have multiple items in gallery and against each i have one check box where user can select all check box or few of them and once submit it will update status as per switch for all checked items,

But thanks for given idea to how to optimize it using collection 

[WarrenBelz · Accepted solution]

No problem @Ashok2 ,

That was what I was trying to do - show you the principle of minimizing server calls and Collections and Variables are always the best way of doing this. As we both have discovered, trying to write code of this complexity without being able to see the data structure to test it is always challenging, particularly when one does things in a different manner.

On that subject, I will leave you with one thought - if you can make a Collection, even if it is done in a couple of stages that will directly Patch the data source "record for record", it will run very quickly and is actually the way I approach all filtering/renaming/field choosing for everything from Galleries to ComboBoxes and Patches, although I will add that this is not necessarily everyone's preference.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Ashok2]

Thanks @WarrenBelz  new lesson learned thanks for you help 🙂

[Anonymous]

Hello,

I had an app the loads slow, this is what's on the On Visible, any suggestion to enhance the performance?

Thank you!, appreciate the help.

Set(Ad, 1); Set(Cd, 2); Set(Fd, 3);
ClearCollect(PipCollect, SortByColumns('[dbo].[PipData]', "PipName"));
If(IsBlank(varUser),
Set(varUser, LookUp(PipCollect, Upper(EmailAddress) = Upper(User().Email))));
Switch(varUser.KeyID,
Ad, ClearCollect(ActivePip, LookUp(PipCollect, PipID = varUser.PipID)),
Cd, ClearCollect(ActivePip, Filter(PipCollect, CdID = varUser.PipID)),
Fd, ClearCollect(ActivePip, PipCollect))

Refresh('[dbo].[PipData]');PipID)

[WarrenBelz]

Hi @Anonymous ,

Other than dropping the Variables, you cannot use any Concurrent here as you have cascading dependencies. Also there seems to be a stray bit at the end.

ClearCollect(
   PipCollect, 
   SortByColumns(
      '[dbo].[PipData]', 
      "PipName"
   )
);
Set(
   varUser, 
   LookUp(
	  PipCollect, 
	  Upper(EmailAddress) = Upper(User().Email)
   )
);
Switch(
   varUser.KeyID,
   1, 
   ClearCollect(
      ActivePip, 
      LookUp(
         PipCollect, 
         PipID = varUser.PipID
      )
   ),
   2, 
   ClearCollect(
      ActivePip, 
      Filter(
         PipCollect, 
         CdID = varUser.PipID
      )
   ),
   3, 
   ClearCollect(
      ActivePip, 
      PipCollect
   )
)
Refresh('[dbo].[PipData]');
PipID)     //What is this on the end??

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Anonymous]

Hi @WarrenBelz.
Thanks for the reply. My bad, i forgot to remove the stray. The last two lines on my On Visible is these, 

Refresh('[dbo].[PipData]');
ClearCollect(PipCollect, Filter('[dbo].[PipData]', Upper(PipStatus) = "ACTIVE" And PipID in ActivePip.PipID));

Do you think the "in" operator may have cause delay on loading. Is there any alternative i could use instead?

Thank you!

[WarrenBelz]

Hi @Anonymous ,

Please note I am flying a bit blind to your requirement logic, but will the below work - note the question on refreshing.

ClearCollect(
   PipCollect, 
   SortByColumns(
      '[dbo].[PipData]', 
      "PipName"
   )
);
Set(
   varUser, 
   LookUp(
	  PipCollect, 
	  Upper(EmailAddress) = Upper(User().Email)
   )
);
Refresh('[dbo].[PipData]');    //why is this being refreshed?
Concurrent(
   Switch(
      varUser.KeyID,
      1, 
      ClearCollect(
         ActivePip, 
         LookUp(
            PipCollect, 
            PipID = varUser.PipID
         )
      ),
      2, 
      ClearCollect(
         ActivePip, 
         Filter(
            PipCollect, 
            CdID = varUser.PipID
         )
      ),
      3, 
      ClearCollect(
         ActivePip, 
         PipCollect
      )
   ),
   ClearCollect(
      PipCollect, 
      Filter('[dbo].[PipData]', 
         Upper(PipStatus) = "ACTIVE" &&
         PipID = ActivePip.PipID
      )
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

[Anonymous]

Hi @WarrenBelz. The gallery that uses the collection don't get updated on load so the Refresh was added and it does seem to help. Thanks for the suggestion, however it keeps throwing an error "The function Concurrent has some invalid argument".