Problem with patch-function

[sami_harjunen]

I am creating an app that initially generates a unique "AuID" ID number and inputs the information retrieved from WeeklyGallery into a list called "Vastaukset - Viikkoauditointi, radio". When testing the app on the computer, everything works well. The popupVisibleStartAudit, which contains buttons for starting and returning back, appears at the right time when the preliminary data has been patched. If I use the app on a mobile phone, sometimes the patching process doesn't complete fully, and the popupVisibleStartAudit appears on the screen too early, with not all the data from the patch function transferred to the SharePoint list. However, the next time it might work well. I haven't faced this issue on PC. What could help?

Thank you, I will try to give you all information needed. 

Set(
popupVisibleOpeningWait,
true
);

Set(
varAuID,
Patch(
'Käyttäjät',
Defaults('Käyttäjät'),
{User: varUser}
).ID
);

ForAll(
WeeklyGallery.AllItems,
Patch(
'Vastaukset - Viikkoauditointi, radio',
Defaults('Vastaukset - Viikkoauditointi, radio'),
{
AuID: varAuID,
AqID: AqID,
Date: varNow,
Sawmill: ComboboxSawmill.Selected.name,
Department: ComboboxDepartment.Selected.Value,
Auditors: ComboboxAuditors.SelectedItems,
Question: Question,
'Other auditors': OtherAuditorsTextInput.Text,
Info: Info,
'Audit type': "Viikkokierros"
}
)
);

Set(
popupVisibleStartAudit,
true
)

[NPPlatform]

Hi @sami_harjunen , weird that this issue only happens on mobile. You could try the solutions proposed in this post: https://powerusers.microsoft.com/t5/Building-Power-Apps/How-to-wait-for-Patch-to-finish-before-Navig...

[sami_harjunen]

Thanks for advice, I will try this next!

[WarrenBelz · Accepted solution]

Hi @sami_harjunen ,

Your problem could possibly be ambiguity in the Patch with identically-names fields. Try this - I am assuming that every item I have _Data in front of is in the gallery - if not, remove this reference.

Set(
   popupVisibleOpeningWait,
   true
);
Set(
   varAuID,
   Patch(
      'Käyttäjät',
      Defaults('Käyttäjät'),
      {User: varUser}
   ).ID
);
Patch(
   'Vastaukset - Viikkoauditointi, radio',
   ForAll(
      WeeklyGallery.AllItems As _Data,
      {
         AuID: varAuID,
         AqID: _Data.AqID,
         Date: varNow,
         Sawmill: _Data.ComboboxSawmill.Selected.name,
         Department: _Data.ComboboxDepartment.Selected.Value,
         Auditors: _Data.ComboboxAuditors.SelectedItems,
         Question: _Data.Question,
         'Other auditors': _Data.OtherAuditorsTextInput.Text,
         Info: _Data.Info,
         'Audit type': "Viikkokierros"
      }
   )
);
Set(
   popupVisibleStartAudit,
   true
)

Please also note that ForAll() is not designed to be a Loop, although it can work this way with considerable performance penalty as it does an individual Patch for each record. ForAll() creates a Table, which can be patched in one action provided its content is correct. For new records, this is simply a Table with field names and field types matching the list.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[sami_harjunen]

Thank you, I will try this as well! And for your information, this same problem also occurred when using the app via PC .

[sami_harjunen]

@WarrenBelz. I tried your solution without the _Data. annotation. Everything works fine and faster than before. For some strange reason, when I release a new version of the application, the first Patch function doesn't work. When I try again, it works normally. Just a moment ago, on the first attempt, the Patch function only created one row in the database, even though it should create its own row for each item in WeeklyGallery. If I tried it again during the same session, it worked normally again. Thank you!

[WarrenBelz]

Hi @sami_harjunen ,

You will find that the As disambiguation operator is a good thing to use. You can call _Data whatever you want, but it is better to specifically refer to which dataset you are referring to in a ForAll Patch.

[sami_harjunen]

Thanks for your help! I didn't get it to work with Patch-function. But now it works with this UpdateIf-function. So I'm happy now with this solution.

Set(
popupVisibleOpeningWait,
true
);

Set(
varAuID,
Patch(
'Käyttäjät',
Defaults('Käyttäjät'),
{User: varUser}
).ID
);

ClearCollect(
WeeklyDataCollection,
ShowColumns(
'Kysymykset - Viikkokierros',
"AqID",
"AuID",
"Audittype",
"Date",
"Auditors",
"Otherauditors",
"Sawmill",
"Department",
"Info",
"Question"

)
);

ForAll(
WeeklyGallery.AllItems,
UpdateIf(
WeeklyDataCollection,
AqID = Value(AqIDFieldAnswers.Text),
{
Date: varNow,
AuID: varAuID,
'Audit type': "Viikkokierros",
Sawmill: ComboboxSawmill.Selected.name,
Department: ComboboxDepartment.Selected.Value,
Auditors: ComboboxAuditors.SelectedItems,
'Other auditors': Text(OtherAuditorsTextInput.Text),
Info: Text(NotVisibleInfoText.Text),
Question: Text(QuestionFieldAnswers.Text)
}
)
);

Collect(
'Auditointivastaukset', WeeklyDataCollection);

ClearCollect(
WeeklyDataCollection, 'Kysymykset - Viikkokierros');

Set(
popupVisibleStartAudit,
true)