Sharepoint custom form won’t save 4th form in edit mode

[Nation3li]

I have a SharePoint list which I am using a custom power apps form for. This has worked in the past with a patch to save the multiple pages I use (out of necessity, please don’t suggest to put all fields in one form). Now it isn’t working.

What is driving me nuts is that although the whole thing saves fine in new mode, it does not want to save the 4th (last) form on the app in edit mode UNLESS I navigate away from that page when saving. To reiterate, I can save all changes for the 1st, 2nd, 3rd and 4th forms when pressing save on forms 1, 2 and 3 but cannot save changes made to form 4 when pressing save on form 4 - unless I navigate away to form 1, 2 or 3.

As you can imagine, my users will likely be pressing save a lot on the last page of the app! Form 4 is a page to update numbers and text only, with one data card at the top that is only on view mode so can’t be edited and would already be populated at edit mode. This data card in view mode is on page 2 and 3 so I don’t think it’s the issue.

This is the patch I’m using in the OnSave section in SharePointIntegration:

If(IsBlank(DataCardValue19. SelectedDate) || IsBlank(DataCardValue20. Text) || IsBlank(DataCardValue5_1.Selected), Notify("Please check the form for required missing information. These are marked with an asterisk (*).", NotificationType.Error, 10000), If (SharePointForm1_1. Mode=FormMode.New, Patch('DATASOURCE', Defaults('DATASOURCE'), SharePointForm1_1.Updates, SharePointForm1_2.Updates, SharePointForm1_3.Updates, SharePointForm1_4.Updates); RequestHide(); , SubmitForm (SharePointForm1_1); SubmitForm(SharePointForm1_2) ;

SubmitForm (SharePointForm1_3); submitForm (SharePointForm1_4);

RequestHide() ;))

I did have ResetForm for all forms after the “.Updates” ones but took them out after looking at some other user’s posts on here. I have also tried putting in Refresh(data source) In the OnSuccess section for all the forms and then only the one which wasn’t saving.

A weird thing that started happening during me trying to fix this is that the condition that brings up an error message for those required fields now comes up randomly when I try to save when those required fields are indeed filled out. If I navigate to another page and then back again and press save it works so this is the least of my worries when compared to the above main issue. This may help in figuring out what it is though!

I really am losing my mind over this and have been doing overtime to fix since my team can’t help and I know it could be something so simple like it has been in the past. Can anyone help me please?!

[WarrenBelz · Accepted solution]

HI @Nation3li ,

You are correct in that the particular error is not making a lot of sense, however firstly please try this

If(
   IsBlank(DataCardValue19.SelectedDate) || 
   IsBlank(DataCardValue20.Text) || 
   IsBlank(DataCardValue5_1.Selected), 
   Notify(
      "Please check the form for required missing information. These are marked with an asterisk (*).", 
      NotificationType.Error, 
      10000
   ), 
   Patch(
      'DATASOURCE', 
      If(
         SharePointForm1_1.Mode = FormMode.New, 
         Defaults('DATASOURCE'),
         {ID: SharePointIntegration.SelectedListItemID}
      ),
      SharePointForm1_1.Updates, 
      SharePointForm1_2.Updates, 
      SharePointForm1_3.Updates, 
      SharePointForm1_4.Updates
   )
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[Nation3li · Accepted solution]

Hi @WarrenBelz, thank you for your response and time spent on this issue, you’ve saved me such a headache this week!

All I changed was putting ;requesthide() between the two last close brackets to make sure my forms disappeared after saving. This sorted the saving issue, thank you!

If you have any ideas as to why the form sometimes ignores the required fields rule and shows the error message then I could still do with some help on that! It seems to just ignore it randomly.

[WarrenBelz · Accepted solution]

@Nation3li ,

A more accurate test (I am assuming the Combo Box output here) could be

If(
   Value(DataCardValue19.SelectedDate) < 1 || 
   Len(DataCardValue20.Text) = 0 || 
   Len(DataCardValue5_1.Selected.Value) = 0
   Notify(
      "Please check the form for required missing information. These are marked with an asterisk (*).", 
      NotificationType.Error, 
      10000
   ), 

As controls are not always blank, but can contain an empty string or in the case of dates, date 0

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications)   Visit my blog Practical Power Apps

[Nation3li]

@WarrenBelz Thank you so much, this has helped solve all the issues I’ve had so far  🙂

I’ve seen your name pop up in many threads and didn’t expect to see it here - thank you for coming to the rescue, you’re amazing!