SubmitForm fails on second submit (using a edit form control) and unselects the selected value in gallery

[Anonymous_Hippo]

Hello All,

I have a gallery control which is linked to a sharepoint list. The user would first select an item to edit by clicking on the gallery item and this loads the selected data on the Form control. I have a submit button on the from which submits and patches information to a sharepoint list

Gallery1.default=varRecord

Gallery1.TemplateFill=If(ThisItem.IsSelected,LightGray,RGBA(0, 0, 0, 0))

Form1.item=varRecord

I notice that after the submit button is clicked the gallery unselects the selected value - How can i avoid doing this

OnSelect of the submit button is given below. I notice that whenever i try to submit the second time - the submitform() function fails - possibly since the gallery.selected item is reset. For the form to submit correctly i need to reselect the item in the gallery... how can i fix this issue. Thanks alot for your help

Set(
    VarLastselected,
    varRecord
);
If(
    IsBlank(MilestoneField) || IsBlank(CommentsInput) || IsBlank('BucketedReason for Early or late submission') || IsBlank('BucketedReason for Early or late Approval') || IsBlank('Additional Details for Early/Late Submission') || IsBlank('Additional Details for Early/Late Approval'),
    Set(
        RequiredFieldsComplete,
        false
    ),
    Set(
        RequiredFieldsComplete,
        true
    )
);
SubmitForm(Form1);
//always submit the form in this way if there are any validation errors it will give an error message
If(
    Admin && !IsBlank(CommentsInput),
    (Set(
        varRecord,
        Patch(
            Regional,
            LookUp(Regional,ID=varRecord.ID),
            {
                'Running Notes (History of Changes)': User().FullName & " : " & Proper(
                    Text(
                        Now(),
                        "d-mmm-yyy hh:mm"
                    )
                ) & If(
                    Hour(Now()) < 12,
                    " AM",
                    " PM"
                ) & " : " & CommentsInput.Text & Char(10) & Char(10) & RunningNotes123.Text,
                Response: ""
            }
        )
    ))
);
If(
    !Admin && RequiredFieldsComplete,
    (Set(
        varRecord,
        Patch(
            Regional,
            ThisItem,
            {
                'Running Notes (History of Changes)': User().FullName & " : " & Proper(
                    Text(
                        Now(),
                        "d-mmm-yyy hh:mm"
                    )
                ) & If(
                    Hour(Now()) < 12,
                    " AM",
                    " PM"
                ) & " : " & CommentsInput.Text & Char(10) & Char(10) & RunningNotes123.Text,
                Response: ""
            }
        )
    ))
)

[Alex_10]

@Anonymous_Hippo 

....... your code before submit here

SubmitForm(Form1);
Set(varRecord, Form1.LastSubmit);

...... your code after submit here

[Anonymous_Hippo]

@Alex_10  Thank you for looking into this. So this code works only when i remove the patch() code after. Looks like patch is causing the issue.

Weird part is that if i remove the code after submit it is working like expected but if i don't remove it - both the patch and submit functions don't work. Any idea on how to fix this ? thanks alot

[Alex_10]

@Anonymous_Hippo 

do you patch to the same datasourse as the form (Regional list)?

CommentsInput and RunningNotes123 inputs are inside the form? if yes, what column names they are saved in?

your form1.OnSuccess is empty?

[Anonymous_Hippo]

@Alex_10 

---

do you patch to the same datasourse as the form (Regional list)?

---

Yes, I am patching to the same sharepoint list item if there is some value inside the CommentsInput field.

CommentsInput and RunningNotes123 inputs are inside the form? if yes, what column names they are saved in?

---

Yes, CommentsInput is saved in "Response" column and RunningNotes123 is saved in "Running Notes (History of Changes)" column

My form1.OnSuccess has Notify("Your feedback was saved successfully",Success,10)

[Alex_10]

@Anonymous_Hippo 

assuming that all input fields that used for setting RequiredFieldsComplete variable are text ones.

Set(VarLastselected, varRecord);

If(
    IsBlank(MilestoneField.Text) || 
    IsBlank(CommentsInput.Text) || 
    IsBlank('BucketedReason for Early or late submission'.Text) || 
    IsBlank('BucketedReason for Early or late Approval'.Text) || 
    IsBlank('Additional Details for Early/Late Submission'.Text) || 
    IsBlank('Additional Details for Early/Late Approval'.Text),
        Set( RequiredFieldsComplete, false ),
        Set( RequiredFieldsComplete, true )
);

SubmitForm(Form1);
Set(varRecord, Form1.LastSubmit);

If(
    ( Admin && !IsBlank(varRecord.Response) ) || 
    ( !Admin && RequiredFieldsComplete ),
        Set( varRecord,
            Patch(Regional, LookUp(Regional, ID = varRecord.ID),
                {
                'Running Notes (History of Changes)': 
                    User().FullName & " : " & Proper(Text( Now(), "d-mmm-yyy hh:mm" )) & 
                    If( Hour(Now()) < 12, " AM", " PM") & " : " & 
                    varRecord.Response & Char(10) & Char(10) & 
                    varRecord.'Running Notes (History of Changes)',
                Response: ""
                }
            )
        )
);

Edited: added a comma

[Anonymous_Hippo]

@Alex_10 

Sorry for the late reply !

Unfortunately this does not work either. For some reason the submitform() is failing. Like i mentioned before, everything seems to be working if i remove the patch function. Any idea on why this is not working

I feel that this error is because after the first submit, the record gets unselected i wonder if this has anything to do with this issue

[Alex_10 · Accepted solution]

@Anonymous_Hippo 

just to confirm:

Regional is your SharePoint list.

"Response" column is a single line text column in the SharePoint list 

"Running Notes (History of Changes)" column is a multi line text columns in the SharePoint list 

Gallery1.Items = Regional

Gallery1.OnSelect = Set(varRecord, ThisItem)     <----and no other code here

Gallery1.Default  = varRecord

Form1.DataSource = Regional

Form1.Item = varRecord

if all yes, need to test your patch():

submitButton.OnSelect = 
If(
    IsBlank(MilestoneField.Text) || 
    IsBlank(CommentsInput.Text) || 
    IsBlank('BucketedReason for Early or late submission'.Text) || 
    IsBlank('BucketedReason for Early or late Approval'.Text) || 
    IsBlank('Additional Details for Early/Late Submission'.Text) || 
    IsBlank('Additional Details for Early/Late Approval'.Text),
        Set( RequiredFieldsComplete, false ),
        Set( RequiredFieldsComplete, true )
);
SubmitForm(Form1);


Form1.OnSuccess = 
Set(varRecord, Form1.LastSubmit);
Set( varRecord,
    Patch(Regional, LookUp(Regional, ID = varRecord.ID),
        {
        'Running Notes (History of Changes)': "test running notes " & Text(Second(Now())),
        Response: "test response " & Text(Second(Now()))
        }
    )
)

that should patch every time you press the submit button. each time it patches the current time second value is added, so you can see different numbers in REsponse and Running Notes columns.

[Anonymous_Hippo]

@Alex_10 

just to confirm:

Regional is your SharePoint list.

"Response" column is a single line text column in the SharePoint list 

"Running Notes (History of Changes)" column is a multi line text columns in the SharePoint list 

Gallery1.Items = Regional

Gallery1.OnSelect = Set(varRecord, ThisItem)     <----and no other code here

Gallery1.Default  = varRecord

Form1.DataSource = Regional

Form1.Item = varRecord

if all yes, need to test your patch():

---

Everything above is correct only thing different is the response field which happens to be a multi line field. But i think that should not have any problems

There was a breakthrough using this method. I am getting the submit fail message along with this error message

So the first time i save. Everything works fine. But if i change something and try to save it again then it throws this error all the time. How can i fix it ?

By the way thank you so much for your incredible patience and awesome help 🙂

[Alex_10]

@Anonymous_Hippo 

do you have required columns in SP list? if yes, try to make all of them not required first and test the app.