The Patch not updating the first item

[esjimenezp]

Hello Community, I have the next issue, I use the next formula to update a SharePoint items from Gallery

ForAll(
    Gallery2.AllItems,
    Patch(
        BDCMEX,
        varRecord,
        {Movimientos: varRecord.Movimientos + cmb_Cantidad.Selected.Value}
    );
    Patch(
        MovMaterials,
        Defaults(MovMaterials),
        {
            Item: ThisRecord.Item.Item,
            Cantidad: ThisRecord.cmb_Cantidad.Selected.Value,
            Fecha: date_Fecha.SelectedDate,
            Project: cmb_Project.Selected.Project,
            Destinatario: {
                '@odata.type': "#Microsoft.Azure.Connectors.SharePoint.SPListExpandedReference",
                Claims: cmb_DestinationUser.Selected.Email,
                Department: "",
                DisplayName: cmb_DestinationUser.Selected.DisplayName,
                Email: cmb_DestinationUser.Selected.Email,
                JobTitle: "",
                Picture: ""
            }
        }
    )
);
Reset(date_Fecha);
Reset(cmb_DestinationUser);
Reset(cmb_Project);

The Patch only update the second item not the first one, there are missing something?

In the first Gallery I use the next formula into the arrow icon

Collect(colMaterials, {ID: ThisItem.ID, Item: ThisItem, Cantidad: ThisItem.Cantidad}); Set(varRecord, ThisItem); Set(varShowForm, true);

Any ideas I would appreciate your help, thanks in advance.

Kind regards 👋

[RandyHayes]

@esjimenezp 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  ForAll is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance.

Your formula should be:

Patch(BDCMEX,
     varRecord,
     {Movimientos: varRecord.Movimientos + cmb_Cantidad.Selected.Value}
);


Patch(
    MovMaterials,
    ForAll(Gallery2.AllItems,
        {
            Item: Item.Item,
            Cantidad: cmb_Cantidad.Selected.Value,
            Fecha: date_Fecha.SelectedDate,
            Project: cmb_Project.Selected.Project,
            Destinatario: 
            { 
	       Claims:"i:0#.f|membership|" & Lower(cmb_DestinationUser.Selected.Email), 
	       Department:"", 
	       DisplayName: cmb_DestinationUser.Selected.DisplayName, 
	       Email: cmb_DestinationUser.Selected.Email, 
	       JobTitle: "", 
	       Picture: ""
            }
        }
    )
);

Reset(date_Fecha);
Reset(cmb_DestinationUser);
Reset(cmb_Project);

I am not sure of your use of the varRecord, but you are resetting that on each click from your first gallery.  So that is not going to be unique to each record.  It appears you are using that to specify the record for a form...which is fine.

However, you are using varRecord in your formula, and that is only ever going to be one static snapshot, it is not changing from what I see in your formula. 

Try to avoid the variables in this case and use the gallery as it is a collection/table of all the data you need...work from it instead of variables.

I hope this is helpful for you.

[esjimenezp]

Thanks @RandyHayes I used the variable varRecord to execute a calculation to do this (if I'm crazy please let me know 😎)

ThisItem.Cantidad - ThisItem.Movimientos

To show the user the current available items

So, in the Gallery1 I use the next formula into the arrow icon to select the current Item and passed to the Gallery2

Collect(colMaterials, {ID: ThisItem.ID, Item: ThisItem, Cantidad: ThisItem.Cantidad}); Set(varRecord, ThisItem); Set(varShowForm, true);

Then, into the Gallery2 is for select the quantity of the current Item, I use the next formula into the ComboBox

Sequence(varRecord.Cantidad - varRecord.Movimientos)

I used your code example and it continues updating only the second item not the first one, again, thank you so much for your help.

Kind regards 👋

[RandyHayes]

@esjimenezp 

So let's dig into this...

You say that only the second item is being updated - BUT, your formula is not to update records, it is to create records.  So there would be nothing updated.

I am a little confused on that point from what you are stating, so perhaps you can clarify a little more.

For the other patch statement, is it that you are trying to update the original record to reflect the amount to be what was there minus the amount specified by the user?  If this is where you are going, then no, there is no need for a variable (and variables will not be helpful with a gallery/table of items anyway).

But, let me know what you are trying to do with that part.

[esjimenezp]

Thanks @RandyHayes let me dig in to explore with Collections instead of two Galleries, I'll back soon and I let you know, again thank you.

Kind regards 👋

[esjimenezp]

Hi @RandyHayes,

This is what I have, I need to update the Movements field in list A (contains the materials) when the user writes the quantity number of materials the quantity should be updated (reduce the quantity)

I use two Galleries, one to show the fields of list A and another Gallery to show the data of the collection.

This is the code I use into the OnSelect Property of the Gallery1 into the Add icon to added into the Gallery2

Collect(
    colMaterials,
    {
        ID: ThisItem.ID,
        Item: ThisItem.Item,
        Cantidad: ThisItem.Cantidad
    }
);

The collection show me this information, which is fine

Then, into the Gallery2 I just need to add the TextInput to user puts the number of quantity, then hits Save to update the Movements field into the list A then the Gallery2 it Patch in another custom list, so, how can I update the field when the user adding the number of quantity field, I hope I don't confuse you anymore.

This video help me a lot, but instead of use dropdown I would like to use Text Input and added multiple items.

Again, thank you for your help.

Kind regards 

[esjimenezp]

I made those changes into my code, into the OnChange property 

ForAll(
    Gallery2.AllItems As aPatch,
    Patch(
        BDCMEX,
        {ID: aPatch.ID},
        {Cantidad: aPatch.Cantidad - Value(txt_QTY.Text)}
    )
)

it update the specific column but when I added a few items and changes automatically but when I added more than 3 fields it happens this

Thanks again for the support.

Kind regards 👋

[esjimenezp]

Hi Community,

The above code has some issues and I modified with this

ForAll(
    Gallery2.AllItems As aPatch,
    Patch(
        BDCMEX,
        {ID: aPatch.ID},
        {Cantidad: aPatch.Cantidad - Value(aPatch.txt_QTY.Text)}
    )
);

And it works very properly, thanks for all the support.

Kind regards 👋

[RandyHayes · Accepted solution]

@esjimenezp 

Sorry to drop getting back to you on your prior responses.

Your formula still is using the ForAll table function incorrectly!

Your formula should be:

Patch(BDCMEX,
    ForAll(Gallery2.AllItems,
        {ID: ID},
        {Cantidad: Cantidad - Value(txt_QTY.Text)}
    )
);

If you use the ForAll backward, you will suffer high performance issues.  ForAll is a function that produces a Table, not a for loop.

Again, sorry for the delay in response!

[esjimenezp]

I really appreciate your help @RandyHayes  many thanks to you 😎👋🚀

Kind regards 👋