'Do until' unwanted exit

[Craig_Lawrie]

I have a flow for document approval which waits for the document file lock to be released (and the 'Set content approval' block to succeed) before continuing.  I use a simple 'Do until' loop which implements the following...

documentLocked flag set to true

do until documentLocked is false (or timeout after 60 x 4 hours) {

    try to set approval status {  // this may take up to 15 minutes to return a result

        if fail { wait 2 minutes }

        if ‘wait is skipped’ /* indicating approval status success */ {  documentLocked flag set to false }

    }

}

if 'do until' failed or timed out send failure email
if 'failure email' skipped, send success email

I've recently had flows complete successfully but not apply the approval.  The flow exits the do until loop without satisfying the exit conditions.  Below is an example:

The do until loop is set to timeout after 60 attempts or 4 hours.

This run appeared to try 17 times to set content approval (and failed each time) which then exceeded the 4 hour flow limit.

(as an aside, can anyone tell me why can take so long for file locks in SharePoint to release after having documents open in desktop apps - Word in this instance???).

So the outcome of this 'do while' should have been 'timeout' which should have caused my next block to execute but it was skipped...

That apply to each sends a failure notification and is set to execute if the do until block 'has failed' or 'has timed out'.

I don't understand why the Apply to each was skipped and the 'success' email notification was sent instead.

Any help is greatly appreciated.

Craig

[Craig_Lawrie]

Apologies - I've just realised what the issue is with the failure email - the 'run after' applies to the final block in the loop, not to the loop itself and as the final block is always skipped (if the document never unlocks), the failure email is also skipped.

I'd still like some thoughts on why documents are locked for such a long time (after being closed by all users).