Overcomplicating a flow

[ksullivan2]

My flow works okay, but I feel like I'm way overcomplicating the process. I'm going to just post my flow and expressions and can post more info later if what I'm trying to accomplish doesn't make sense. I'd like feedback on how I can simplify this. I'm still pretty new to Power automate and it would be very helpful to explain any suggestions you might have. Thanks so much:)

[grantjenkins]

Are you able to write out exactly what your flow is trying to do in bullet points, etc.?

[ksullivan2]

@grantjenkins Absolutely, let me know if this diagram helps. 

OnModification:

- When Status is set to OnDesign, OnQuote, Manufacturing Process, Email Responsible User

- When status is set to OnPackingList, Email PM

- When Status is set to Shipped, Email CreatedBy & PM

- When Status is set to OnDesign, OnQuote, Manufacturing Process, or OnPackingList

• Is 7 days prior to the Date Needed value, then email Responsible
• Is 1 day overdue to the Date Needed value, then email Responsible

I also have a separate flow for OnNew:

-When an item is created, Email PM

I tried to figure out how to combine the two, but was having a hard time the When an item is created OR modified trigger

[wskinnermctc]

Impressive organized work for sure.

The only thing I don't like is the Delay steps. I'm not sure the datetime ranges you are using, but I wouldn't want a flow sitting and waiting for days or weeks. It probably works and specific to what you are doing. But I would find a way to make a status or something, then have a daily recurring flow that checks and does what you want.

That's more of a process design change than a single flow improvement.

There could also be away to use Solutions which allows you to make separate flows and call on them with a parent flow. So you would have smaller individual flows that are called for specific reasons.

[ksullivan2]

@wskinnermctc  Thanks for those suggestions. I am clueless when it comes to best practice in power automate, but I wondered about the delay until and the wait period and how it might effect everything else. 

I haven't created parent/child flows yet, but I like that idea. I also realized that I could have created a form and coded notifications with html. I'm a little better at writing functions in power apps that I am at building flows

[wskinnermctc]

I don't think there is really a right way or wrong way so long as it works. Obviously if you can make something more efficient then go for it.

My primary orientation is simplicity or transparency.

I think it is important putting notes on the steps, using descriptive naming for steps, putting a description on the overall flow, and having a organized flow name will help most in the long run. You already seem to have external documentation like your diagram which helps get you to the flow you need to look at. 

The internal flow notes and descriptions help when you go back and look at something in 7 months when it breaks and don't have a clue what you were trying to do. It's even worse if you inherit a broken flow.

I will put a compose step in the top of the flow and basically write anything I think is important or summary of what is going on.

Here are some steps from a big flow I made.

Scopes OverviewSteps Detail

I put different things into scopes so it is clear what is going on. Try to label them in order. And put notes on steps.

[ksullivan2]

This is good to know, I wasn't familiar with scopes. I'm going to start using that. Thanks.