Adding New Line to Gallery Issue

[johnnykalsi]

Building a simple timesheet app...

Items of Gallery: 

colTimesheetLines

Code for Adding New Line in Timesheet: 

Collect(
    colTimesheetLines,
    Defaults('Timesheet Lines')
)

Code for Total Hours:

 Coalesce(
    Sum(
        Value(txt_Sunday.Text),
        Value(txt_Monday.Text),
        Value(txt_Tuesday.Text),
        Value(txt_Wednesday.Text),
        Value(txt_Thursday.Text),
        Value(txt_Friday.Text),
        Value(txt_Saturday.Text)
    ),
    0
)

When Adding New Line, all hours are zero/blank, but total hours are automatically copied over from line above

I cant seem to get the New Line to be 0

[LaurensM]

Hi @johnnykalsi,

I was able to recreate the issue by using an empty string as Default value (""). The following 2 options fixed the issue on my end.

Option 1 - Remove the Default value (keep it blank instead of double quotes)

Option 2 - Set the Default to 0 instead of using HintText

If this solves your question, would you be so kind as to accept it as a solution & give it a thumbs up.

Thanks!

[johnnykalsi]

Hi Laurens

I need the default of the fields to be thisitem.xxxx...for example

ThisItem.Monday

for cases when user loads saved timesheet

[johnnykalsi · Accepted solution]

I changed default values to 

If(!IsBlank(ThisItem.ID),ThisItem.Monday, 0)

 It worked with that..

[LaurensM · Accepted solution]

@johnnykalsi thanks for giving the extra info and update! 😊

As a small improvement you could use the following, shorter code:

Coalesce(ThisItem.Monday, 0)

I hope this helps!

[johnnykalsi]

awesome...Would you be able to look @ this new issue? or should i open a new thread?

I have the following code for the Delete Line

Remove(
    colTimesheetLines,
    ThisItem
);
  If(
    !IsBlank(ThisItem.ID),
    Collect(
        colDeleteTimesheetLines,
        ThisItem
    )
)

The issue is that it deletes the 1st line

For example

I click on Delete Icon for 26 hours

It will Delete the 1st line with 2 hours

[LaurensM · Accepted solution]

@johnnykalsi,

Are all lines newly added lines by any chance? This issue often occurs due to empty lines being added in a collection (which Defaults(Datasource) does) and then trying to delete one of those lines.

Power Apps needs a way to distinguish each line via some sort of unique identifier. If multiple lines are completely similar (e.g. all columns are blank) then the app does not know which row to delete so it defaults to the first occurrence. A way to avoid this is to temporarily add a column to serve as a unique ID for locally created records.

Instead of adding a row by using Collect(Defaults()) use:

Collect(colTimesheetLines, {TempId: CountIf(colTimesheetLines, ID = Blank()) + 1})

As long as you still have a ClearCollect reference to your Datasource (e.g. to fetch the saved TimeSheet lines), your Datasource columns should still be available. Should the only reference to your DataSource schema have been the Collect(Defaults()) we just adjusted, write the following code in the OnVisible of that screen:

Collect(colTimesheetLines, Defaults('Timesheet Lines')); 
Clear(colTimesheetLines)

Our AddColumns may cause an error in your save code should you use Patch(DataSource, Collection). Should an error appear, you will have to drop the temporary column before patching in order to match your Datasource schema:

DropColumns(
    colTimesheetLines,
    "TempId"
)

In regards to your delete code, you will have to run the If statement before removing the record:

If(
    !IsBlank(ThisItem.ID),
    Collect(
        colDeleteTimesheetLines,
        ThisItem
    )
);
Remove(
    colTimesheetLines,
    ThisItem
)

If this solves your question, would you be so kind as to accept it as a solution & give it a thumbs up.

Thanks!

[johnnykalsi]

I need to re read this couple times to understand this...but thank you for the detailed write up....

[Agenor26]

Hello there, Im running with the same issue, and trying to go step by step with you solution, but I'm facing an issue with the save button:

// Collection to update timesheet lines
ClearCollect(
colUpdateTimesheetLines,
ForAll(
gal_TimesheetLines.AllItems,
'Timesheet Lines'@{
TempId:TempId,
ID: ID,
TimesheetID: gblTimesheetCurrent.ID, // <----- NEW CODE
'Network Code':Text(drp_NetworkCode.Selected.'Network Code'),
'Project Name-Scope of Work': Text(txt_ProjectName2.Text),
Sunday: Value(txt_Sunday.Text),
Monday: Value(txt_Monday.Text),
Tuesday: Value(txt_Tuesday.Text),
Wednesday: Value(txt_Wednesday.Text),
Thursday: Value(txt_Thursday.Text),
Friday: Value(txt_Friday.Text),
Saturday: Value(txt_Saturday.Text)
}
)
);

// Manually patch 'Network Code' and 'Project Name-Scope of Work'
ForAll(
colUpdateTimesheetLines,
Patch(
'Timesheet Lines',
LookUp(
gal_TimesheetLines.AllItems,
ID = ThisRecord.ID
),
{
'Network Code': Text(drp_NetworkCode.Selected.'Network Code'),
'Project Name-Scope of Work': Text(txt_ProjectName2.Text)
}
)
);

// Drop the temporary column "TempId"
DropColumns(
colUpdateTimesheetLines,
"TempId"
);

// Update timesheet lines and store the results
ClearCollect(
colTimesheetLines,
Patch(
'Timesheet Lines',
gal_TimesheetLines.AllItems,
colUpdateTimesheetLines
)
);

// Delete timesheet lines
ForAll(
colDeleteTimesheetLines,
Remove(
'Timesheet Lines',
ThisRecord
)
);
Clear(colDeleteTimesheetLines);

// Update total hours on timesheet record
Set(
gblTimesheetCurrent,
Patch(
Timesheets,
gblTimesheetCurrent,
{
TotalHours: Sum(
colUpdateTimesheetLines,
Sunday
) + Sum(
colUpdateTimesheetLines,
Monday
) + Sum(
colUpdateTimesheetLines,
Tuesday
) + Sum(
colUpdateTimesheetLines,
Wednesday
) + Sum(
colUpdateTimesheetLines,
Thursday
) + Sum(
colUpdateTimesheetLines,
Friday
) + Sum(
colUpdateTimesheetLines,
Saturday
)
}
)
);

// Notify the user
Notify("Your Data has been saved", NotificationType.Information)