Append new values to collection, appends only last values

[Aionik]

Hi all,

I want to append IDs for all items which don't have an ID in SharePoint in a ForAll Loop.

The users creates many new Manufacturer in his collection without ID.

Create Item ID Manufacturer and save the new Items in a collection.

ClearCollect(colNewManufacturer;
ForAll(Filter(colManufacturer; 
Not(!IsBlank(ID)));
Patch(ManufacturerLib;
Defaults(ManufacturerLib);{
    Title:Last(ManufacturerLib).ID+1;
    Manufacturer:Manufacturer;
    New_entry: true;
    Dummy: MachineNumber
})
));;

I want now to append the returned IDs to the collection of Manufacturers:

//Append all ID and Value in Collection to upload 
ForAll(colNewManufacturer;
Update(colManufacturer;
LookUp( colManufacturer;!IsBlank(MachineNumber));
        { 
        ID: ID;
        Title: Title;
        Manufacturer: Manufacturer;
        Unit: MachineNumber
        }   
));;

If I have two or more entries, only the last one is taken into account in the code above.

How to solve this mystery? 

Thank you!

[Hassan_SZ_365]

Hi @Aionik ,
To append the new IDs to the existing collection without missing any entries, you'll want to update each item with its corresponding new ID. Here's a simplified step-by-step solution:

1. Patch New Items: Instead of ClearCollect, use Collect to add new items to ManufacturerLib and simultaneously collect their IDs.

2. Collect Returned IDs: Store the result of Patch in a temporary collection to keep the newly created IDs.

3. Update Original Collection: Iterate over the original collection and update the ID field where it's blank, using the temporary collection of new IDs.

Here’s an updated version of your code:

// Step 1: Patch new Manufacturers and collect their IDs
Collect(colNewIDs, 
    ForAll(Filter(colManufacturer, IsBlank(ID)),
        Patch(ManufacturerLib, Defaults(ManufacturerLib), {
            Title: Last(ManufacturerLib).ID + 1,
            Manufacturer: Manufacturer,
            New_entry: true,
            Dummy: MachineNumber
        })
    )
);

// Step 2: Update original collection with new IDs
ForAll(colManufacturer as ManufacturerItem,
    If(IsBlank(ManufacturerItem.ID),
        UpdateIf(colManufacturer, 
            ManufacturerItem = Manufacturer,
            {ID: LookUp(colNewIDs, Manufacturer = ManufacturerItem.Manufacturer).ID}
        )
    )
);

This approach uses UpdateIf to update the ID field in colManufacturer where it's blank with the corresponding ID from colNewIDs.

Make sure the lookup condition uniquely identifies the item in both collections. If MachineNumber is unique for each item, you can use it in the LookUp function to match the correct IDs.

Best Regards,
Hassan Raza

[Aionik]

Thank you for the in-depth description of your provided solution. 

Following observation:

Step 2: The reference "as ManufacturerItem" doesn't work in my code enviroment,  I corrected it with "As".

When I want to add one value, it does not attach the field ID from colNewID in the field ID of the collection colManufacturer. The unique value is the Manufacturer, the MachineNumber is needed for the bulk upload with more data in reference to the Unit.

Best Regards

[Aionik]

Any ideas someone? The code seems right based on doc and @Hassan_SZ_365 answers. But still the appending of ID does not work. 

[Hassan_SZ_365 · Accepted solution]

Hi @Aionik ,

To resolve the issue where only the last entry's ID is being appended to the colManufacturer collection, you can use the following method:

1. After creating new items in ManufacturerLib, collect their IDs in a separate collection.
2. Use a ForAll loop with UpdateIf to iterate through colManufacturer and update the ID for each item that lacks one, based on a unique identifier.

Here's a revised version of the code that should work: 

// Collect new Manufacturers and their IDs
ForAll(
    Filter(colManufacturer, IsBlank(ID)),
    Collect(
        colNewIDs,
        Patch(
            ManufacturerLib,
            Defaults(ManufacturerLib),
            {
                Title: Text(Last(ManufacturerLib).ID + 1),
                Manufacturer: Manufacturer,
                New_entry: true,
                Dummy: MachineNumber
            }
        )
    )
);

// Update colManufacturer with new IDs
ForAll(
    colManufacturer,
    If(
        IsBlank(ID),
        UpdateIf(
            colManufacturer,
            Manufacturer = ManufacturerItem.Manufacturer,
            {
                ID: LookUp(colNewIDs, Manufacturer = ManufacturerItem.Manufacturer).ID
            }
        )
    )
);

Make sure to replace ManufacturerItem.Manufacturer with the actual unique identifier for the manufacturer items.

The As keyword should be used when you want to reference the current item in the ForAll loop and when the UpdateIf function targets the correct condition. Make sure Manufacturer is the unique value used to link items between colManufacturer and colNewIDs. If Manufacturer is not unique, you'll need to find a unique property to match the items correctly.

Best Regards,
Hassan Raza