Combine Multiple IF Conditions- Power App

[ramyara]

Hi all,

This is my second app build and excited about Power app:)

Wondering if my IF formula used to combine 2 conditions are accurate for DisplayMode. Looking to make it read only once it is Approved or Rejected. (or Should I use Switch?)

This is for a ticket review screen.

1. If it is ABC or XYZ who is reviewing

2. If ABC or XYZ choose Approved or Rejected, then make the fields as view only, else they should be editable.

my formula:

If(User().Email="abc@12345.com" || "xyz@12345.com" && ThisItem.'Lead Review Status'.Value="Approved"||ThisItem.'Lead Review Status'.Value="Rejected", Parent.DisplayMode.Edit, Parent.DisplayMode.View)

PLEASE LET ME KNOW!

Best!

[iAm_ManCat]

Heya!

Yeah you were so close 🙂

The way you currently ahve it as one long && || means that if Any of the Ors are true then the rest are ignored, but not to worry, we can wrap them in brackets and that will help separate them into sections of logic:

If(
   // (If User is X or Y) AND (status is not approved/rejected) then make it edit
   (User().Email="abc@12345.com" || User().Email="xyz@12345.com")
   && 
   !(ThisItem.'Lead Review Status'.Value="Approved"||ThisItem.'Lead Review Status'.Value="Rejected")
   ,
   Parent.DisplayMode.Edit,
   // (If user is Not X or Y) OR (status is approved/rejected) then make it view
   Parent.DisplayMode.View
)

Cheers,

Sancho

[ramyara]

Hi @iAm_ManCat  thanks for the super quick response.

However it still doesn't work for me 😞  The formula makes the field view only.🤔

If((User().Email="abc@12345.com" ||User().Email="xyz@12345.com" && !(ThisItem.'Lead Review Status'.Value="Approved"||ThisItem.'Lead Review Status'.Value="Rejected"), Parent.DisplayMode.Edit, Parent.DisplayMode.View)

The Lead Review Status for this example was "Unassigned". So it should have let me edit it cosnidering I am abc@12345.com 😶

Thanks

[iAm_ManCat]

You are missing a closing bracket closing after the xyz email in the above formula,

also my apologies, I didn't see you had referenced parent for displaymode, which you did not need to and the checking of email addresses is case-sensitive so if you are Abc@ but we are comparing abc@ then that will return false, so I have included wrapping the email address in the Lower function (assuming that you will replace abc@ with a lowercase email representation of your email addresss)

If(
   // (If User is X or Y) AND (status is not approved/rejected) then make it edit
   (
     Lower(User().Email)="abc@12345.com" || Lower(User().Email)="xyz@12345.com"
   )
   && 
   !(
     ThisItem.'Lead Review Status'.Value="Approved" || ThisItem.'Lead Review Status'.Value="Rejected"
   )
   ,
   DisplayMode.Edit,
   // (If user is Not X or Y) OR (status is approved/rejected) then make it view
   DisplayMode.View
)

[ramyara]

Hi @iAm_ManCat  thanks for the response! But, unfortunately it still doesn't work for some reason. I also created a collection of the individuals and tried combining, but to no avail. 😞 Also used Switch function. Nothing works .

If((CountRows(Filter(LeadAppCol,Approvers.Email = CurrUser.Mail))>0) && !(ThisItem.'Lead Review Status'.Value="Approved" ||ThisItem.'Lead Review Status'.Value="Rejected"), Parent.DisplayMode.Edit, Parent.DisplayMode.View)

also tried this:

Switch((User().Email="abc@12345.com"||"xyz@12345.com")) && (ThisItem.'Lead Review Status'.Value="Unassigned"||ThisItem.'Lead Review Status'.Value="Review in progress"), Parent.DisplayMode.Edit, Parent.DisplayMode.View)

[iAm_ManCat]

Switch function wouldn't apply in this case and the parameters are wrong in the example you gave anyway.

Let's take a step back and look at the issue.

Make a label, make it's text value:

User().Email

Make another label, make it's text value:

"abc@12345.com" (or whatever you are checking)

Now a third label:

User().Email="abc@12345.com"

and if that is false, then that is the issue, as I likely think that your User Principal Name for your account (ie the name you log into your computer/office365) is different from your primary SMTP email address.

[ramyara]

Hi @iAm_ManCat  You're right. there are 2 diff email domains my co uses. 

To solve that:

1) I created this in the App on Start Function and created a collection of Lead Reviewers separately (abc@12345.com +xyz@ 12345.com)

Set(CurrUser,Office365Users.MyProfile());
ClearCollect(IdeaAppCol,'Project team Approvers');
ClearCollect(LeadAppCol,'Lead Approvers')

2) For my Review Screen, I tried this: 

please let me know where I'm going wrong, I'd like to correct it and learn pls

If(
    (CurrUser.Mail = "abc@12345.com" ||CurrUser.Mail = "xyz@12345.com" ) 
&& (ThisItem.'Lead Review Status'.Value = "Approved" || ThisItem.'Lead Review Status'.Value = "Rejected"),
    Parent.DisplayMode.View,
    Parent.DisplayMode.Edit
)

[iAm_ManCat · Accepted solution]

Ok, yes that's good, that should cover that, now you are checking for a static email address so we need to make sure case-sensitivity is not an issue, as Abc@ and abc@ are two different cases and would not be considered equal, so we use the Lower() function to convert all of them to lowercase only.

Additionally, you have changed your status conditions again, so let's be clear on this and add another condition, as the way it currently is, if anyone else but abc/xyz is looking at it, they will be able to edit, so we can update it as follows:

If(
   // If status, then make it view only
   (ThisItem.'Lead Review Status'.Value = "Approved" || ThisItem.'Lead Review Status'.Value = "Rejected"),
   DisplayMode.View,

   //if approver and status is not one of the two statuses, then edit
   (Lower(CurrUser.Mail) = Lower("abc@12345.com") || Lower(CurrUser.Mail) = Lower("xyz@12345.com") ) 
&& Not(ThisItem.'Lead Review Status'.Value = "Approved" || ThisItem.'Lead Review Status'.Value = "Rejected"),
    DisplayMode.Edit,

    // otherwise, under all other conditions make it view-only
    DisplayMode.View
)

[ramyara]

Hi @iAm_ManCat  unfortunately it still doesn't work.  This logic should be working but it isnt 😞 I'll try again and confirm if I get the desired result. Thanks for your inputs

[iAm_ManCat]

Could you copy paste what you have currently so that I can try and help?