Disabling button

[ADumith]

Hello everyone,

I have a button with the following formula:

************************************************************************

Set(
varElid,
LookUp(
'mytable',
varElid.'recordid' = 'recordid'
)
);
Patch(
'mytable',
varElid,
{
'EL Status': 'EL Status Choice'.'Filed',
'CS EL Status': 'CS Choice'.'N/A',
'Status Date': Today()
}
);
ButtonCanvas4.DisplayMode.Disabled;
Notify(
"Record's status has been updated",
NotificationType.Success,
5000
)

************************************************************************

This formula is in the OnSelect property, so after the user clicks the button should deactivate, but for that to happen I have noticed that the user has to click twice and I don't understand why.

Additionally in the DisplayMode property of the button I have the following formula:

************************************************************************

If(varElid.'EL Status' = 'EL Status Choice'.'Waiting to be filed' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify not found' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify incomplete',
DisplayMode.Edit,
DisplayMode.Disabled)

************************************************************************

Is it possible that this formula is affecting the other one?

My goal is that as soon as the user clicks on the button it is immediately disabled. Instead of do it twice.

Any idea?

Thank you very much in advance.

[Amik · Accepted solution]

@ADumith - regarding this line:

ButtonCanvas4.DisplayMode.Disabled

I suspect you think this is actually going to do something (e.g. disable the Button). All this line will do is return the DisplayMode property of that Button. If you apply that line to the Text property of a Label control for example, the Text property will return the DisplayMode ("disabled", "edit", "view").

I would suggest you remove that line and replace it with: 

UpdateContext({ctx_disable_button: true})

And then apply the below to the DisplayMode property of your Button:

If(
    ctx_disable_button,
    DisplayMode.Disabled,
    DisplayMode.Edit
)

[ADumith]

Hello @Amik ,

I added the line:

UpdateContext({varButtonDisabled: true});

and on the DisplayMode property I added the variable with others conditions as follow:

If(
varButtonDisabled || varElid.'EL Status' = 'EL Status Choice'.'Waiting to be filed' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify not found' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify incomplete' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify wrong letter',
DisplayMode.Edit,
DisplayMode.Disabled
)

But it didn't work. Actually before at least when I double clicked, the button was deactivated now not even that.

Did I did something wrong?

Thank you, 

[Amik]

@ADumith - Your Button was being disabled purely because you patched the variable. This line "ButtonCanvas4.DisplayMode.Disabled" had no impact at all - as mentioned, it doesn't do anything.

Notice in the suggested formula I gave you that the Button will be disabled if the output of the "ctx_disable_button" is true.

If(
    ctx_disable_button,
    DisplayMode.Disabled,
    DisplayMode.Edit
)

Your formula on the other hand has got this the other way around.

I would take a step back and refocus on what you're trying to do.

What should happen to that Button if varElid.'EL Status'  field equals any of your parameters? Should that Button be enabled? Even if the user clicks the Button?

[ADumith]

@Amik I got you and you right. 

I think the error is in the formula conditions, this is the formula:

If(

    !varButtonDisabled || varElid.'EL Status' = 'EL Status Choice'.'Waiting to be filed' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify not found' || varElid.'EL Status' = 'Engagement Letter Status Choice'.'Unable to verify incomplete',

    DisplayMode.Edit,

    DisplayMode.Disabled

)

This formula is indicating that if the varButtonDisabled variable is not true or the varElid register contains a state equal to any of those mentioned then the button is enabled, otherwise it must be disabled. That is to say, if the variable is true and the state of the varElid register is different from any of those then the button will be disabled.

I just did the test and to disable it I have to double click, so it doesn't work.

Any other idea?

Thank you,

[Amik]

@ADumith - again, what you are trying to do?

What should happen to that Button if varElid.'EL Status'  field equals any of your parameters? Should that Button be enabled even if the user clicks the Button?

[ADumith]

Hi @Amik 

Thank you for your help.

Let me explain, the record originally has the status "Waiting to be filed", this status changes to "I have filed it" when the user presses the button because pressing it updates the record's status, and after that, the button cannot be enabled again.

**************

Set(

    varElid,

    LookUp(

        'mytable',

        varElid.'mytable' = 'mytable'

    )

);

Patch(

    'mytable',

    varElid,

    {

        'EL Status': 'EL Status Choice'.'Filed awaiting verification',

        'CSEL Status': 'Client Signed Choice'.'N/A',

        'Status Date': Today()

    }

);

UpdateContext({varButtonDisabled: true});

Notify(

    "Record's status has been updated",

    NotificationType.Success,

    5000

)

************

That's why I'm evaluating the value of the status in the DisplayMode property, so that if the status is equal to any of those states, the button should be disabled.

************

If(

    !varButtonDisabled || varElid.'EL Status' = 'EL Status Status Choice'.'Waiting to be filed' || varElid.'EL Status' = 'EL Status Choice'.'Unable to verify not found' || varElid.'EL Status ' = 'EL Status Choice'.'Unable to verify incomplete',

    DisplayMode.Edit,

    DisplayMode.Disabled

)

************

Does this make sense to you?

Again, THANK YOU!

[ADumith]

Good morning @Amik ,

I know what is happening.

Let me explain:

The `varElid` variable is loaded when the record is searched in `mytable`. Then, when the button is clicked, it updates the value of the `Status` field in `mytable`. However, the value of the status in the variable remains the same as before, meaning it was not updated with the new status.

Therefore, when I verify the `DisplayMode` property, it's validating against a variable whose field was not updated. So, logically, the next step would be to update `varElid` again and then make the context change so that the button is deactivated.

The final formula would be:

Set(
    varElid,
    LookUp(
        ‘mytable’,
        varElid.' mytable ' = ' mytable '
    )
);
Patch(
    ‘mytable’,
    varElid,
    {
        'EL Status': 'Engagement Letter Status Choice'.'Filed awaiting verification',
        'CSEL Status': 'Client Signed Choice'.'Filed awaiting verification',
        'Status Date': Today()
    }
);
Set(
    varElid,
    LookUp(
        ‘mytable’,
        varElid.' mytable ' = ' mytable '
    )
);
UpdateContext({varButtonDisabled: true});
Notify(
    "Record's status has been updated",
    NotificationType.Success,
    5000
)

Now my question would be is this the best way to do it or do you think there is a better way?

Thanks again for your help,

[ADumith]

Hello @Amik ,

I have rewritten the formula in this way in order to decrease the number of look ups:

Set(
    varElid,
    Patch(
        'mytable',
        LookUp(
            'mytable',
            varElid.mytable = mytable
        ),
		{
			'ELS': 'ELS Choice'.'Unable to verify incomplete',
			'SC ELS': 'Client Signed Choice'.'Unable to verify incomplete',
			'Status Date': Today()
		}
    )
);
UpdateContext({varButtonDisabled: true});
Notify(
    "Record's status has been updated",
    NotificationType.Success,
    5000
)

This solved the problem and makes the formula more effective.

However, I will give your proposal as the solution.

Thanks again.

[Amik]

@ADumith - I never did get an answer from you on what should happen to that Button if varElid.'EL Status'  field equals any of your parameters and if the Patch Button is executed, but I am glad have found a workable solution.

When you say that pressing the Button changes the status choice field to "I have filed it", I assume you do not mean this literally, because I cannot see "I have filed it" in your Patch statement. 

The Patch statement looks fine to me, but it not a good idea to include a success notification within the Patch (you cannot assume this is always going to be successful).

@mdevaney has produced created a useful guide on this topic:

https://www.matthewdevaney.com/power-apps-patch-function-error-handling/