Duplicate items being made and I don't know why

[Mojpage]

I'm going to be as thorough as I can with this, because I'm completely lost why it's happening.

Here's my app and how it should look

You can see there's only one item in the top gallery (red circle just shows there's no scroll bar), which reflects this List with one item in it:

All the cells have the same instruction for OnChange - Select(Parent), which selects the gallery.

The gallery OnSelect instruction is below, which should patch the changes to the collection.

This is the OnSelect command for the save button, which should then save the changes in the Collection back to the list:

The problem is that I update any of those cells, it duplicates that cell several times. See the scroll bar now appears to show more items.

Now at this point, those new entries aren't showing in the SP List. This must have something to do with the fact that I'm using a collection. So the gallery is actually showing the Collection of the List, rather than the list itself. But the next time I make a change and save it back to the list, those new entries will also be added:

You'll see that only the top entry has the latest amend, the others are duplicates of the older data.

But each time I save from then on, the duplicate entries will snowball and add more and more.

It feels like I've got something set up slightly wrong somewhere but I don't know what. All help very much appreciated.

Thanks!

[KeithAtherton]

Hi @Mojpage,

The gallery OnSelect Patch() function may be adding a new record to ColGridData1 instead of updating the single existing entry, resulting in the duplicate entries.

I would suggest either changing the Patch() function call to update the First() record in ColGridData1, or consider changing that code to call ClearCollect() so it guarantees a clear-collection-and-add-one-record approach.

Patch function reference: https://learn.microsoft.com/en-us/power-platform/power-fx/reference/function-patch

ClearCollect function reference: https://learn.microsoft.com/en-us/power-platform/power-fx/reference/function-clear-collect-clearcoll...

---

If I have answered your question, please mark your post as Solved.
If you like my response, please give it a Thumbs Up.

[Mojpage]

Thanks very much for the suggestion. I could certainly see the logic in ClearCollect to add just one item at a time (as that list will be populated by lots of items, but only ever one will be selected in that top gallery). BUT, I changed the code as suggested to:

And when I made a change, it still made a duplicate AND the edit would continually flash between the old and new data. I deleted the word 'help' and then it just flashes Help on and off consinuously, as does the duplicate entry below it. It felt quite fitting, but not good!

I just want to flag that the save button when selected also selects a hidden button (after patching or (now)clear/collecting), which has this code in it: ClearCollect(ColGridData1,ThirdBuildHandoverForm). I don't know if that's messing with it in some way?

Just want to provide all the details!

[KeithAtherton · Accepted solution]

Thanks, good to know about the hidden button - it's likely this call which causes the collection to store multiple records.

If you select the ThirdBuildHandoverForm table in the formula bar, it should show the records that that table contains. Hopefully that highlights the source of the records for collection ColGridData1.

---

If I have answered your question, please mark your post as Solved.
If you like my response, please give it a Thumbs Up.

[Mojpage]

Thanks @KeithAtherton ,

I removed the selecting of the hidden button and it stopped the duplication. I've found a workaround to refresh showing the data source - taking them to a 'successfully updated' screen and then when they go back to the original screen it reloads on visible. 

Really appreciate your help!

About to post a new thread about my next problem now!

[KeithAtherton]

My pleasure! Glad it helped you resolve the issue. Thanks for the update.

---

If I have answered your question, please mark your post as Solved.
If you like my response, please give it a Thumbs Up.