Every time, I am trying to save the record using below code getting runtime error " The data source supplied to the function is invalid" Please suggest here. I am trying to bind the value into to collection rather than directly into data source to in order to increase the performance of app.

[GavsApps]

Set(
varAuditReq,
Patch(
colProviders,
Defaults(colProviders),
{Provider: ComboBox4.Selected.Result},
{Center: DataCardValue2.Text},
{DateOfAudit: DataCardValue44.SelectedDate},
{OverallScore: Value(lblChronicCumulative.Text)},
{Patient: DataCardValue18.Text},
{DOB: DataCardValue20.SelectedDate},
{DateOfService: DataCardValue22.SelectedDate},
{TCMTOCPatient: DataCardValue56.Text},
{TCMTOCDOB: DataCardValue58.SelectedDate},
{TCMTOCDateOfService: DataCardValue59.SelectedDate},
{AcutePatient: DataCardValue68.Text},
{AcuteDOB: DataCardValue70.SelectedDate},
{AcuteDateOfService: DataCardValue71.SelectedDate},
{HealthMainPatient: DataCardValue80.Text},
{HealthMainDOB: DataCardValue82.SelectedDate},
{HealthMainDateOfService: DataCardValue83.SelectedDate}
)
);

ForAll(
galChronic.AllItems,
Patch(
colChronicResults,
{
ProviderID:varAuditReq.ID,
ElementsHeader: Label6.Text,
Elements: Title2_4.Text,
Y_x002f_N: RadioChronicYesNoOther.Selected.Answer,
Comments: txtComments_4.Text,
Score: Value(txtChronicScoreYesNoOther.Text),
CategoryScore: Value(lblChronicCategory.Text),
WeightedScore: Value(lblChronicWeighted.Text),
CumulativeScore: Value(lblChronicCumulative.Text)
}
)
);

[BrianS · Accepted solution]

I could be wrong but I would try the syntax in the second Patch for both of them. In the first you are setting every field off in {} I think you should just use the {} around the grouping as you have in the second one.

[WarrenBelz]

Hi @GavsApps ,

Your problem is that a collection has neither Defaults nor an ID (automatically anyway). However you can increase the performance of your Patch enormously by Patching the Table created by ForAll() rather than looping though with multiple patch instances. Example only below - you would have to create the ID somewhere - this would create new records in the data source

Patch(
   DataSource,
   ForAll(
      galChronic.AllItems,
      {
         ProviderID: ????
         ElementsHeader: Label6.Text,
         Elements: Title2_4.Text,
         Y_x002f_N: RadioChronicYesNoOther.Selected.Answer,
         Comments: txtComments_4.Text,
         Score: Value(txtChronicScoreYesNoOther.Text),
         CategoryScore: Value(lblChronicCategory.Text),
         WeightedScore: Value(lblChronicWeighted.Text),
         CumulativeScore: Value(lblChronicCumulative.Text)
      }
   )
);

also for the first piece of code to add new records to a Collection

Collect(
   colProviders,
   {
      Provider: ComboBox4.Selected.Result,
      Center: DataCardValue2.Text,
      DateOfAudit: DataCardValue44.SelectedDate,
      OverallScore: Value(lblChronicCumulative.Text),
      Patient: DataCardValue18.Text,
      DOB: DataCardValue20.SelectedDate,
      DateOfService: DataCardValue22.SelectedDate,
      TCMTOCPatient: DataCardValue56.Text,
      TCMTOCDOB: DataCardValue58.SelectedDate,
      TCMTOCDateOfService: DataCardValue59.SelectedDate,
      AcutePatient: DataCardValue68.Text,
      AcuteDOB: DataCardValue70.SelectedDate,
      AcuteDateOfService: DataCardValue71.SelectedDate,
      HealthMainPatient: DataCardValue80.Text,
      HealthMainDOB: DataCardValue82.SelectedDate,
      HealthMainDateOfService: DataCardValue83.SelectedDate
   }
);

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

[WarrenBelz]

Hi @GavsApps ,

Just checking if you got the result you were looking for on this thread. Happy to help further if not.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

[GavsApps]

@WarrenBelz Thank you for checking, issue still persists. As per my use case(Questionnaire App using SharePoint as datasource ) I need to pass ProviderID of first patch which I am storing in variable (varAuditReq) and using it all the places where ever I need. I am still facing the same issue. 

[WarrenBelz]

@GavsApps ,

I would have thought you just need varAuditReq where I have ???? in the code I posted.

[GavsApps]

@WarrenBelz I used varAuditReq in place of ??? and also using varAuditReq as reference to piece of code for different SP list however it didn't work. 

[WarrenBelz]

@GavsApps ,

I will admit, I am having more than a little difficulty visualising exactly what you are doing from what you have posted especially when the error is at data source connection rather than code level. From what I can see however, you simply need to retrieve the value to be patched into ProviderID  but you have not told me sufficient about this item to understand where you are getting this from. You are updating your Data Source with the contents of a gallery and adding this value to the relevant field. If you are storing this in a Variable, why is it not working (are you getting any errors in the code or errors following the Patch ?

[GavsApps]

My bad, I have not explained the complete context and use case. Now, I am sharing the part of logic to give you more insight. Also sharing the screenshot of error.

Set(
varAuditReq,
Collect(

colProviders,

Defaults(colProviders),
{Provider: ComboBox4.Selected.Result},
{Center: DataCardValue2.Text},
{DateOfAudit: DataCardValue44.SelectedDate},
{OverallScore: Value(lblChronicCumulative.Text)},
{Patient: DataCardValue18.Text},
{DOB: DataCardValue20.SelectedDate},
{DateOfService: DataCardValue22.SelectedDate},
{TCMTOCPatient: DataCardValue56.Text},
{TCMTOCDOB: DataCardValue58.SelectedDate},
{TCMTOCDateOfService: DataCardValue59.SelectedDate},
{AcutePatient: DataCardValue68.Text},
{AcuteDOB: DataCardValue70.SelectedDate},
{AcuteDateOfService: DataCardValue71.SelectedDate},
{HealthMainPatient: DataCardValue80.Text},
{HealthMainDOB: DataCardValue82.SelectedDate},
{HealthMainDateOfService: DataCardValue83.SelectedDate}
)
);

Patch(
colChronicResults,
//Defaults(colChronicResults),
ForAll(
galChronic.AllItems,
{
ProviderID: varAuditReq.ID,
ElementsHeader: Label6.Text,
Elements: Title2_4.Text,
Y_x002f_N: RadioChronicYesNoOther.Selected.Answer,
Comments: txtComments_4.Text,
Score: Value(txtChronicScoreYesNoOther.Text),
CategoryScore: Value(lblChronicCategory.Text),
WeightedScore: Value(lblChronicWeighted.Text),
CumulativeScore: Value(lblChronicCumulative.Text)
}
)
);

ForAll(
RenameColumns(
galTCM_TOC_1.AllItems,
"ID",
"ID2"
),
Patch(
//tblTCM_TOCResults,
colTCM_TOCResults,
//Defaults(tblTCM_TOCResults),
Defaults(colTCM_TOCResults),
{ProviderID: varAuditReq.ID},
{ElementsHeader: Label9.Text},
{Elements: Title2_6.Text},
{Y_x002f_N: RadioTCMYesNoOther.Selected.Answer},
{Comments: txtComments_6.Text},
{Score: Value(txtTCMScoreYesNoOther.Text)},
{CategoryScore: Value(LabelTCMCategory.Text)},
{WeightedScore: Value(lblTCMWeighted.Text)},
{CumulativeScore: Value(LabelTCMCumulative.Text)}
)
);
ForAll(
RenameColumns(
galAcute_1.AllItems,
"ID",
"ID3"
),
Patch(
//tblAcuteResults,
colAcuteResults,
//Defaults(tblAcuteResults),
Defaults(colAcuteResults),
{ProviderID: varAuditReq.ID},
{ElementsHeader: Label11.Text},
{Elements: Title2_7.Text},
{Y_x002f_N: RadioAcuteYesNoOther.Selected.Answer},
{Score: Value(txtAcuteScoreYesNoOther.Text)},
{CategoryScore: Value(lblAcuteCategory.Text)},
{WeightedScore: Value(lblAcuteWeighted.Text)},
{CumulativeScore: Value(lblAcuteCumulative.Text)}
)
);

[GavsApps]

Error - Invalid argument type(Table). expecting a record instead.
The function patch has some invalid arguments.