Formula error for submitting button

[vjnvinod]

Hi Experts,

I am getting the below error in my formula, not sure what i am missing here

Patch('VarianceData',First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,Comments:txt_comments.Text});
 
UpdateContext({showsuccess:true});

Navigate(Screen2)

[shoog]

You're updating the Comments field two times with different values within your patch function, that's not allowed.

You probably intend to update two different fields.

[poweractivate]

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text)) 
   {        
         Comments:drp_Comments.Selected.Value
        ,Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

1. In the above, you have Comments defined twice, you can't do that, change it to

    {        
         Comments:drp_Comments.Selected.Value
        ,Another_Comments:txt_comments.Text
    }

Replace Another_Comments above as appropriate or use Comments: only once, e.g.

    {        
         Comments:drp_Comments.Selected.Value
    }

[poweractivate]

@vjnvinod 

I also recommend rewriting the formula like this:

Patch
(
   'VarianceData'
   ,LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) 
   ,{        
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

or even better, like this:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
       'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

If 'VarianceData' is not a standard SharePoint List. then replace ID in the above with the primary column of your 'VarianceData' data source. The primary column or primary key uniquely identifies all the Records in a Table.

If you don't like the With formula, you can do it like this:

Patch
(
    'VarianceData'   
   ,{     
        ID:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).ID 
        Comments:txt_comments.Text
    }
); 
UpdateContext({showsuccess:true});
Navigate(Screen2)

However, if you'll use any other fields from the LookUp I recommend keeping the With version, for example:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,Patch
   (
      'VarianceData'   
      ,{     
           ID:_myRecord.ID   
           Comments:txt_comments.Text
       }
   ); 
   UpdateContext({showsuccess:true});
   UpdateContext({currentRecordColumn3:_myRecord.Column3}); 
   //The With avoids having to repeat the LookUp formula again - without the With you have to write the above line as //UpdateContext({currentRecordColumn3:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text).Column3}); 
   Navigate(Screen2)
)

See if this helps as well @vjnvinod 

Note that in both the version you gave, and the above, a new record is created if the Filter, LookUp, etc. has no match. If this is intended behavior, then that is fine.

If that is not intended behavior,

then you may want to do this instead if you want to avoid creating a new record in case of no match:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
              ID:_myRecord.ID   
              Comments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)​

[vjnvinod]

@poweractivate  @shoog 

i am still getting the error, when hoover its says some unexpected character

see the formula below, basically i have one dropdown and 1 text comment for users to click on submitt button

Patch
(
'VarianceData'
,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
{
Comments:drp_Comments.Selected.Value
,OtherComments:txt_comments.Text
}
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

[vjnvinod]

@shoog 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

 please note that Comments is a dropdown combo box

and Othercomments is a text box

[poweractivate]

@vjnvinod 

Missing a comma before the opening curly brace

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.Selected.Value
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)

 Note that the above only works without error if OtherComments exists as a column in VarianceData

[vjnvinod]

@poweractivate 

see the error below, there is some issue with txt_comments

here is what i have used based on above thread

Patch(VarianceData,First(Filter(VarianceData,EmailAdress=lbl_useremail.Text)),{Comments:drp_Comments.Selected.Value,OtherComments:txt_comments.Text});
UpdateContext({showsuccess:true});
Navigate(Screen2)

[poweractivate]

---

@vjnvinod wrote:

@shoog 

yes below are the 2 fields in sharepoint list which i intend to update, can you recommend a formula?

 please note that Comments is a dropdown combo box

and Othercomments is a text box

---

A Drop down Control and a Combo box Control are not the same thing.

If Comments is a Combo box control mapped to a SharePoint Choice Column that allows multiple selections you may want to use drp_Comments.SelectedItems  if you want all selected choices rather than only the last selected choice:

Patch
(
   'VarianceData'
   ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
   ,{
       Comments:drp_Comments.SelectedItems
      ,OtherComments:txt_comments.Text
   }
);
UpdateContext({showsuccess:true});
Navigate(Screen2)​

If you get an error, replace drp_Comments.SelectedItems  with drp_Comments.Selected.Value - maybe it's just a Drop down control so it can have only one Selected value anyway then if it's a Drop down control.

If it's a SharePoint List I recommend writing like this if possible:

With
(
    {_myRecord:LookUp('VarianceData','EmailAdress'=lbl_useremail.Text)}
   ,Patch
   (
      'VarianceData'
      ,First(Filter('VarianceData','EmailAdress'=lbl_useremail.Text))
      ,{
          ID:_myRecord.ID
         ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
         ,OtherComments:txt_comments.Text
      }
   );
   UpdateContext({showsuccess:true});
   Navigate(Screen2)​​
)

To avoid creating new values ever, do this instead:

With
(
    {_myRecord: LookUp('VarianceData','EmailAdress'=lbl_useremail.Text) }
   ,If
    ( 
       IsBlank(_myRecord)
      ,Notify("No VarianceData found with email address " & lbl_useremail.Text,Error) 
      ,Patch
      (
           'VarianceData'   
          ,{     
               ID:_myRecord.ID
              ,Comments:drp_Comments.SelectedItems //or use drp_Comments.Selected.Value
              ,OtherComments:txt_comments.Text
           }
       ); 
   )
   UpdateContext({showsuccess:true});
   Navigate(Screen2)
)

 See if it helps @vjnvinod 

[poweractivate]

---

@vjnvinod wrote:

@poweractivate 

OtherComments:txt_comments.Text

---

txt_comments may not exist as a name of a Control in your app.

Double check it.