Issue patching into a SharePoint list

[DarkShadows117]

Hi,

I've been stuck on this for quite some time and almost got it working, but am slightly off. Can someone please help.
I'm currently experiencing an issue when patching into my SharePoint list. It's patching incorrectly and only performing 5 patches (assuming due to my if statement causing this issue).

Currently my app operates like so:

1. You select a staff member from a gallery to provide feedback on the screen "SelectGroupMember". The arrow in the gallery sets a variable here too, so that on the following screen ("FeedbackForm"), that staff member who is being evaluated is carried over. (Refer to PatchIssue1 image/attachment for code and reference of the screen).

2. The arrow on the "SelectGroupMember" screen navigates to the screen"FeedbackForm". This screen allows the staff member to choose an option for feedback on the radio buttons (Refer to PatchIssue2 image/attachment for code and reference of the screen). The code for the patch when clicking the "Submit Form" button is like so:

If(
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit1 = User().Email
        )
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            {ID: varGroupMemEd.ID}
        ),
        {
            Q1a: Q1Radio.Selected.Value,
            UserSubmit1: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit2 = User().Email
        )
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            {ID: varGroupMemEd.ID}
        ),
        {
            Q1b: Q1Radio.Selected.Value,
            UserSubmit2: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit3 = User().Email
        )
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            {ID: varGroupMemEd.ID}
        ),
        {
            Q1c: Q1Radio.Selected.Value,
            UserSubmit3: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit4 = User().Email
        )
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            {ID: varGroupMemEd.ID}
        ),
        {
            Q1d: Q1Radio.Selected.Value,
            UserSubmit4: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit5 = User().Email
        )
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            {ID: varGroupMemEd.ID}
        ),
        {
            Q1e: Q1Radio.Selected.Value,
            UserSubmit5: User().Email
        }
    )
);

The code patches into the SharePoint list but the issue unfortunately is that the patch occurs ascending across the columns. (Refer to PatchIssue3 image/attachment for SharePoint patching). In the image (PatchIssue3) I've highlighted the errors with red boxes and used arrows to indicate where they should have patched. You can see based on the patching, I patched the users in this order (John Doe -> Susan Young -> Nicola Johnson -> Scott Parker -> James Freeman) and it won't let me do a sixth patch (due to the code - but I think this issue will be mitigated if I can fix the location of the patches).

John Doe's patch entered correctly, however, the following patches should only ever patch in the following columns if the previous columns have been populated with data. Meaning the patches for Susan, Nicola, Scott & James are incorrect and need to go in the same 2 columns where John's patch occurred as these columns are blank (where the arrows are indicating).

Essentially, the patch needs to check if that column for that user is blank, if not patch in the next column (so it should check in order like so: if Q1a&Usersubmit1 is blank, then if Q1b&Usersubmit2 is blank, then if Q1c&Usersubmit3 is blank, then if Q1d&Usersubmit4 is blank, then if Q1e&Usersubmit5 is blank, and only patch on the first encountered blank column). So for example, for John's case, let's say I've provided feedback and then Nicola went to provide feedback to John after me, her patch should go into Q1b & UserSubmit2 as data already exists for Q1a & UserSubmit1 from my patch.

I believe this information is concise and covers all that is needed to know, but I'm happy to edit this post and provide any additional information if it isn't 100% clear.

[iAm_ManCat]

Hey @DarkShadows117

Could you try using this - we replace the ID section with an actual lookup to a record, and then we do the IsBlank checks against an actual specified column value (this prevents Power Apps guessing which column in the lookup it should be checking for a blank, as a record can have multiple columns)

If(
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit1 = User().Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            )
        ),
        {
            Q1a: Q1Radio.Selected.Value,
            UserSubmit1: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit2 = User().Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            )
        ),
        {
            Q1b: Q1Radio.Selected.Value,
            UserSubmit2: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit3 = User().Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            )
        ),
        {
            Q1c: Q1Radio.Selected.Value,
            UserSubmit3: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit4 = User().Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            )
        ),
        {
            Q1d: Q1Radio.Selected.Value,
            UserSubmit4: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit5 = User().Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            )
        ),
        {
            Q1e: Q1Radio.Selected.Value,
            UserSubmit5: User().Email
        }
    )
);

Cheers,

Sancho

[DarkShadows117]

Hey @iAm_ManCat,
I really appreciate the response. But, I just tried out the provided code and it unfortunately patches the same as before encountering the same issues. Any other ideas?

[iAm_ManCat]

Based on your code, this should only happen if 

varGroupMemEd.ID

is blank

what is the value for varGroupMemEd.ID?

[DarkShadows117]

@iAm_ManCat, so in the SharePoint list all the data for First Name, Last Name & email are prefilled. However, the 10 columns, being Q1x and UserSubmitx, are blank.
varGroupMemEd.ID is used to the patch the selected user from the previous screen. 
Does this make sense and/or are there any issues with this?

[iAm_ManCat]

Sorry I meant what is the value for varGroupMemEd.ID at the point that you are patching? because it looks like its trying to patch all different rows, instead of one singular row where ID = varGroupMemEd.ID

[DarkShadows117]

@iAm_ManCat Ahh right, my apologies. I hope this makes sense. So, the value for the patch is one of the 4 options in the radio button (refer to PatchIssue2). It is technically patching different rows, as each user is a different row in the SP list.

To provide some insight into the process:
Let's say I am the user providing feedback to the 6 different people in my team, I run through that same form 6 times executing the same patch function for each different user. So I would choose the 1st person and provide feedback (patch the selected radio button), then it reverts back to the previous screen where I choose the next person and do the same thing, until each person has been been provided with feedback.

[iAm_ManCat]

Ok, so we don't have anywhere in our patch that defines what the row is when we are checking so it will jump to the next column for each as its looking at the first row it find with a value in the first then assuming we now must be dealing with the second question Q1b etc etc

If(
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit1 = User().Email
            //we want it to patch the column for that selected email address
            &&
            EmailAddress=GalleryName.Selected.Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
            )
        ),
        {
            Q1a: Q1Radio.Selected.Value,
            UserSubmit1: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit2 = User().Email
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID

            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
            )
        ),
        {
            Q1b: Q1Radio.Selected.Value,
            UserSubmit2: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit3 = User().Email
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
            )
        ),
        {
            Q1c: Q1Radio.Selected.Value,
            UserSubmit3: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit4 = User().Email
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            //we want it to patch the column for that selected email address
            && EmailAddress=GalleryName.Selected.Email
            )
        ),
        {
            Q1d: Q1Radio.Selected.Value,
            UserSubmit4: User().Email
        }
    ),
    IsBlank(
        LookUp(
            CharterProjectSP,
            UserSubmit5 = User().Email
            //we want it to patch the column for that selected email address
            &&
            EmailAddress=GalleryName.Selected.Email
        ).FirstName
    ),
    Patch(
        CharterProjectSP,
        If(
            IsBlank(varGroupMemEd.ID),
            Defaults(CharterProjectSP),
            LookUp(
            CharterProjectSP,
            ID= varGroupMemEd.ID
            //we want it to patch the column for that selected email address
            &&
            EmailAddress=GalleryName.Selected.Email
            )
        ),
        {
            Q1e: Q1Radio.Selected.Value,
            UserSubmit5: User().Email
        }
    )
);

[DarkShadows117]

@iAm_ManCat you bloody legend! You've done it!
Thank you so very much man. I really appreciate all the time and effort you put into helping me with this conundrum. Wish I could do more than kudos and accept as solution. Seriously, thanks again!! 😁

[DarkShadows117]

Sorry to be the bearer of bad news. But there actually is still one issue. The patch is overriding data.
For example, I patched Q1a and UserSubmit1 with my email. Then tested it with a second email and it patched straight over my submission from my primary email overwriting Q1a and UserSubmit1 (when it should patch to Q1b and UserSubmit 2). Do you know why this would be happening @iAm_ManCat??