Multi Select Combobox options for filtered SharePoint choice field not saving all on Edit

[Louise-Marie]

Would appreciate suggestions as to why this works on initial save but not on edit.

I have a list in SharePoint named Milestones and chose to 'Customize forms'

In this list I have a choice field named Predecessors for Milestone set to allow multiple selections in SharePoint

In Power Apps this choice field is filtered to show the milestone numbers already input into the current list of milestones for that project where the project id is the selected project id (project title lookup field at the top of the form).

The items property for the predecessors for milestone combo box is as below. Datacardvalue1 is the project title lookup field

Filter(Milestones,'Project Title'.Id=DataCardValue1.Selected.Id)

For example enter 11 as the current Milestone Ref in a text field then select 9 and 10 as predecessors in the combo box.

Saves fine on initial save but not edit, would like to know why.  Does save on edit, saves other fields but only saves the last value entered in the combo box (set to allow multiple selections in the SharePoint list). All values are displayed in the combo box when you click to save the form.

Combo box update property is below (DataCardValue4 is the combo box)

ForAll(DatacardValue4.SelectedItems, {Value: 'Milestone Ref (1-10, etc.)'})

Milestone Ref (1-10, etc.) is the name of the field used for the list options in the combo box

Combo box options below

SharePoint Integration on Edit

EditForm(MilestoneEditForm); Navigate(EditScreen)

There is a separate edit form/ screen to the new form/screen but other than fields in the appropriate form being referenced, formulas are the same.

Plan to name things better just getting functionality sorted first thanks

Many thanks

[v-jefferni]

Could you please share more details about your scenario? What is the field 'Milestone Ref (1-10, etc.)'? Have you already changed the Choices column name? Would you like to update the selected milestone values to the Choices column?

If so, I made a test in which Choices column name assumed as ‘Predecessors for Milestone’:

1. On NewForm Screen and EditForm Screen, set both Combo Boxes Items to:

If(IsBlank(First(First(Filter(Milestones,'Project Title'.Value=DataCardValue1.Selected.Value).MilestonePredecessors). ‘Predecessors for Milestone’.Value)),Choices(Milestones.MilestonePredecessors),Filter(Choices(Milestones.MilestonePredecessors),Value in Ungroup(Filter(Milestones,MilestonePredecessors.Value=DataCardValue1.Selected.Value)," MilestonePredecessors").Value))

2. Set Update of ‘Predecessors for Milestone’ DataCard to:

DataCardValue4.SelectedItems    
//In Edit screen
&
DataCardValue4_1.SelectedItems  
//In New screen. Assuming DataCardValue4_1 is the name of combo box in NewForm Screen

Why using Value instead of Id in the Filter functions? If you use Id of a LookUp field, it is non-delegable which would make the choices less then there should be if there are more than 2000 records in the list.

I also added a condition which would check if the project is selected the first time, if true then there is no choice in the list so make the selections to be default that including every choices.

Hope this helps.

Best regards,

Community Support Team _ Jeffer Ni
If this post helps, then please consider Accept it as the solution to help the other members find it.

[Louise-Marie]

Hi thanks for taking a look. Of course, the field 'Milestone Ref (1-10, etc.)' is a single line of text.
Yes, the internal name of the 'predecessors for milestone' field is MilestonePredecessors and I'd like to update the selected milestones values in the combo box to the 'predecessors for milestone' choices column which has 1 2 3 etc specified as the options in the column settings in SharePoint

This is what I get when I enter the following into the items property of the combo box of the new form
If(IsBlank(First(First(Filter(Milestones,'Project Title'.Value=DataCardValue1.Selected.Value).choice1). ‘Predecessors for Milestone’.Value)),Choices(Milestones.‘Predecessors for Milestone’),Filter(Choices(Milestones.‘Predecessors for Milestone’),Value in Ungroup(Filter(Milestones,'Project Title'.Value=DataCardValue1.Selected.Value)," ‘Predecessors for Milestone’").Value))

Thanks for your help @v-jefferni 

[v-jefferni]

Hi @Louise-Marie ,

I have edited codes in my last post so that other users would not be misled.

Please try again and modify those column names based on your own list columns.

Best regards,

Community Support Team _ Jeffer Ni
If this post helps, then please consider Accept it as the solution to help the other members find it.

[Louise-Marie]

Thanks very much @v-jefferni, I've amended the code as below in the items property of the combo box and also updated the update property as suggested.  I'm getting invalid argument type as below and no options in the predecessor for milestones...

[v-jefferni]

Hi @Louise-Marie ,

My bad..

Since the dropdown allows multiple selections, need to replace the equal sign with "in".

Please try it.

Best regards,

Community Support Team _ Jeffer Ni
If this post helps, then please consider Accept it as the solution to help the other members find it.

[Louise-Marie]

@v-jefferni thanks for looking at this. I've changed the equals sign to in and am now getting the below - 'Invalid argument type. Cannot use table values in this context. '

[v-jefferni]

Hi @Louise-Marie ,

Sorry for the late. Have you resolve the issue?

There is a typo in my formula that MilestonePredecessors.Value should be 'Project Title'.Value:

If(IsBlank(First(First(Filter(Milestones,'Project Title'.Value=DataCardValue1.Selected.Value).MilestonePredecessors). ‘Predecessors for Milestone’.Value)),Choices(Milestones.MilestonePredecessors),Filter(Choices(Milestones.MilestonePredecessors),Value in Ungroup(Filter(Milestones,'Project Title'.Value=DataCardValue1.Selected.Value)," MilestonePredecessors").Value))

Please try again if the issue persists.

Best regards,

Community Support Team _ Jeffer Ni
If this post helps, then please consider Accept it as the solution to help the other members find it.

[Louise-Marie]

Hello @v-jefferni thanks again. I've amended the code and don't get any error messages but the milestone predecessors multi select combo box is no longer filtered for the selected project title as it was before (all options are displayed). It will save but when you edit the form, if you select an additional predecessor it still only saves the last one you have selected, options already selected are removed. 

[Louise-Marie]

Hi @v-jefferni I forgot to add the code to the edit form also!  When editing it saves all selection items not just the most recently added in the milestone predecessors combo box which is great. In both new and edit forms however, the milestone predecessors combo box isn't correctly filtered for the selected project, it shows all choices in the list settings although you can select multiple and save. 

Items property for the milestone predecessors combo box
(If(IsBlank(First(First(Filter(Milestones,'Project Title'.Value = DataCardValue1.Selected.Value).MilestonePredecessors).'Predecessors for Milestone'.Value)),Choices(Milestones.MilestonePredecessors),Filter(Choices(Milestones.MilestonePredecessors),Value in Ungroup(Filter(Milestones, 'Project Title' .Value = DataCardValue1.Selected.Value),"MilestonePredecessors").Value)))

Update property of the datacard
DataCardValue4.SelectedItems

Appreciate your help, thanks