New Date Calculation issue

[scottmcnitt]

I am trying to count 180 days from now with the issue that the end date calculation cannot land on a weekend or a holiday.  i have a collection for my holidays collectHoliday im struggling with the syntax for not letting land on the weekend or holiday.  im trying right now just with it not landing a holiday but im missing a lot i know:

Text Label (Text)

------------------

With({OriginalDaysToAdd: 180},
With({HolidayCount:
CountIf(
ForAll(
Sequence(OriginalDaysToAdd,1,1),
If(
Text(DateAdd(DatePicker.SelectedDate +OriginalDaysToAdd = DateValue(collectHoliday.HolidayDate)ShortDate),
1,0
)}
)
)

[scottmcnitt]

Ok i lied it is not working.  Im on the 10 Day label and have made all the changes but it is displaying 1/16/2023 even though 0116 is set as a holiday.  

[TheRobRush]

I have this on a 10 Day label I just made to check

Text(
    If(
    Text(DateAdd(DateAdd(DatePicker.SelectedDate,10,Days),v,Days),"[$-en-US]mmdd")
    in
                                            [
                                                ///STATIC HOLIDAYS

                                                ///0101 NEW YEARS DAY
                                                ///0619 EMANCIPATION JUNETEENTH
                                                ///0704 INDEPENDENCE DAY
                                                ///1111 VETERANS DAY
                                                ///1225 CHRISTMAS DAY
                                                0102,0116,0213,0220,0331,0529,0619,0704,0904,0922,1110,1110,1124,1125,1225],
                                            Switch( 
                                                    Weekday(DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v,Days)),
                                                    7, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v+2,Days),
                                                    6, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v+3,Days),
                                                    DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v+1,Days)),
                                            Switch( 
                                                    Weekday(DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v,Days)),
                                                    7, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v+2,Days),
                                                    1, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v+1,Days),
                                                    DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),v,Days))),ShortDate)

and this in the onchange of my calendar

Switch(
    Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),
    7, UpdateContext({v:2}), 
    1, UpdateContext({v:1}), 
    UpdateContext({v:0}));

and the date it is returning is the 17th as expected

[TheRobRush]

In case you haven't clicked on the calendar and changed its date before checking your values, remember that when app first starts, all those variables you are assigning in the onchange of your calendar will be Blank() so in that case your weekends will be unaccounted for and it would have shown you the 16th instead of 17th.

If that is what is going on with your app, drop a copy of your onchange code into the onvisible of the screen it is on, so it sets a default variable value for them all when the screen is loaded, based on default selected date of your calendar so they are not blank when app first loads

[TheRobRush]

Also just noticed, in the values you set for your holidays, you have 1110 2x, should one of those be 1010 (Columbus Day)?

[scottmcnitt]

Ive added to OnVisible of main screen, saved, published, refreshed, tried on another computer and still 1/16 i dont get it.  the code i have is exactly as you have it.

[scottmcnitt]

Oh my i found my issue.  i had v set in my 4 month label as well.  what a dummy!!!

[scottmcnitt]

Is there a way i can get it take affect when the screen loads because OnVisible isnt making it happen.  I still have to click on the date picker.  id rather it work right when it loads cause the default on the date picker is Today()

[TheRobRush]

HAHA Yah this has happened to me a few times as well, so many letters to follow in that code due to the number of different dates you are calculating, did not realize there would be that many when we set up first one

If you want to get rid of all that OnChange Chaos you can alternatively make your text labels read

Text(
    If(
    Text(DateAdd(DateAdd(DatePicker.SelectedDate,10,Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0),Days),"[$-en-US]mmdd")
    in
                                            [
                                                ///STATIC HOLIDAYS

                                                ///0101 NEW YEARS DAY
                                                ///0619 EMANCIPATION JUNETEENTH
                                                ///0704 INDEPENDENCE DAY
                                                ///1111 VETERANS DAY
                                                ///1225 CHRISTMAS DAY
                                                0102,0116,0213,0220,0331,0529,0619,0704,0904,0922,1110,1110,1124,1125,1225],
                                            Switch( 
                                                    Weekday(DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0),Days)),
                                                    7, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0)+2,Days),
                                                    6, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0)+3,Days),
                                                    DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0)+1,Days)),
                                            Switch( 
                                                    Weekday(DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0),Days)),
                                                    7, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0)+2,Days),
                                                    1, DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0)+1,Days),
                                                    DateAdd(DateAdd(DatePicker.SelectedDate, 10, Days),Switch(Weekday(DateAdd(DatePicker.SelectedDate,10,Days)),7,2,1,1,0),Days))),ShortDate)

where you replace all the lettering in the formulas with this same switch snippet (but change the ,10, to the value of each label

[TheRobRush]

That's weird, the OnVisible property of the screen is it's loading property, so it should always preset anything you put there. Might have to do with nothing technically being selected on the calendar yet, might change .selected to like .default

[scottmcnitt]

Im going to try it this way on one of them and see how it goes.  I need to learn how to use this logic and add to the business day calculations its much easier than those i have implemented on this.  Im using a preloaded collection for the holidays on those.