OnChange firing on Edit form before form is loaded

[Anonymous]

I have a edit form which has fields from a SharePoint list.  Two of the fields from the list are People fields, "Assigned To" and "Completed By".  The "Assigned To" allows for multiple values, people only.  The "Completed By" allows for single value, also people only.  Both have a formula that sets respective variables to "YES" for the OnChange event for each datacard.

AssignedTo - Set(ChgdAssgndTo, "YES")

CompletedBy - Set(ChgdCmpltdBy, "YES")

Both of these variables are set to "NO" when:

- The App starts

- When changing from the View form to the Edit form.

In effect, the user would select a gallery item to View, showing the View form.  From there, they can click a button to edit the item.

Problem is that the variable for the "Assigned To" datacard value is set to "YES" when the App is loading, even though both variables are set to "NO" on AppStart.  I have even set both variables to "NO" prior to selecting the item from the gallery to edit.

When I changed the SharePoint list so that the "Assigned To" column only allows for single values (instead of multiple values), this false-firing of the OnChange event does not occur.  I have checked the App for all references to variable ChgdAssgnTo and the only place it is being set to "YES" is the OnChange event for field in the data card.

Why is this false-firing happening only when multiple values are allowed?

[VijayTailor]

Hi @Anonymous 

you can set the variable with value no in OnVisible Property for Screen.

Thanks,

Please click "Accept as Solution" if my post answered your question so that others may find it more quickly. If you found this post helpful consider giving it a "Thumbs Up."-Vijay

[Anonymous]

Hi Vijay,

These are both global variables and thus I don't see how any variable can have a visible property set to true or false.  Or are you talking about making the datacard value visible or not?  Making the datacard invisible would then prevent a user from selecting a name for either the "Assigned To" or "Completed By" cards.  

Note: These two variables, ChgdAssgndTo and ChgdCmpltdBy are both being passed to a Flow that is connected to the App, amongst other variables.

[BlessedCobba]

hi bitmaker,

i think what vijay is trying to say is you can try updating the variable using the onvisible property of the screen, works in the same way as the onStart, its just when that screen is visible instead of onStart of the app

as for the actual issue of the "false" firing, I'm not really sure the cause, potentially because the field is blank when its created and it might read the code to populate the field and think its a change

can i assume you are using the default property of the datacard? to load in the items?

[Anonymous]

Thanks for the heads in BlessedCobba.  I did change the OnVisible property of the edit screen to reset these two global variables to "NO".  And yes, I am using the default property on the datacards to load in the items on the Edit screen.  All the values are coming from a SharePoint list and the neither of the two source columns have a default value specified in the List's settings.

But my main concern is that when the app is launching, the OnChange property of fields that set these 2 variables to "YES" is firing.  The setting of these variable to "YES" only happens in one place, on the Edit screen for the to datacards.  Both variables are set to "NO" in AppStart.  The basic flow of the 3 screens is:

#1- Gallery - to display the list of items.  From here the user selects to view an item or can choose to create a new item.  If they choose to create, these two variables are reset to "NO" before navigating to the Edit screen (#3)

#2- View - Screen used to view the selected item form the Gallery.  From here a user may be able to edit the item (depending on the Status of the item).  Choosing to edit proceeds to the Edit screen, #3.  Before navigating to the edit screen, these two variables are reset to "NO".

#3- Edit - Screen to edit the item and save back to SharePoint (simplified description).  On this screen, in the two respective datacards, the OnChange property is the only place these two variables are set to "YES"

Thus, I cannot understand why or how these two variables have a value of "YES" when the app first loads and displays the Gallery.  Why would a tertiary screen have OnChange events fire before that screen is even requested by the app to be loaded/displayed?

[Anonymous]

Hi, did you get a solution to it?

I have the same issue - on page load my dropdown onchange function is triggered without even changing the drop down values. how to tackle it ? TIA

[Anonymous]

Hi TeresaJohn2022,

The OnChange property is really quirky, firing at times when the gallery was being loaded.  What I did was to add a hidden item in the gallery that compares the value of the gallery item to the value from the SharePoint list (i.e. ThisItem.fieldname).  The compare simply sets this hidden field (I named galChgRowYN) to Y or N.

My code:

Text = If(Or(ThisItem.Response <> galrbResponse.SelectedText.Value, ThisItem.EstCmplDt <> dpckEstCmpltDt.SelectedDate), "y", "n")

Note: the 1st gallery item (galrbResponse) is a radio button with 2 to 3 choices.  The 2nd gallery item, (dpclEstCmpltDt) is a date picker.  These are the two editable fields in each gallery row.

Based on the "y" or "n" value of galChgRowYN, I can add/update/remove the values stored in a collection (colCSRItems) that is built for this gallery (collection is generated in my OnStart, code at the bottom).  The two editable fields have their OnChange property set to keep the collection in sync with changes made.  Both editable fields have the same code for their OnChange property:

If(And(varEditCSGallery,galChgRowYN.Text="y"),
   If(ThisItem.ID in colCSRItems.ID,
        Update(colCSRItems, LookUp(colCSRItems, ID = ThisItem.ID),
            {
              ID: ThisItem.ID,
              Response: galrbResponse.Selected.Result,
              EstCmplDt: dpckEstCmpltDt.SelectedDate
           }
        ),
        Collect(colCSRItems,
              {
              ID: ThisItem.ID,
              Response: galrbResponse.Selected.Result,
              EstCmplDt: dpckEstCmpltDt.SelectedDate
              }
         )
),
RemoveIf(colCSRItems,ID = ThisItem.ID)
)

The code above does add to the collection, updates a row in the collection and also removed a row (when a user removes the change for a gallery row.

The collection effectively has the SharePoint ID of each gallery item along with the two editable fields.  The rows in the collection can easily be written to my SharePoint list with a simple use of Patch to patch the entire collection to SharePoint.  In my case, the collection has at most 40 rows so the patch runs quickly.  The formula for the patch is tied to a button on the screen that is not visible unless the are rows in the collection (using CountRows) and the gallery is in edit mode (enabled with a separate button that sets a variable & clears the collection colCSRItems).  I also have a "Discard Changes" button that effectively clears the collection and turns off the editing of the gallery rows.

The OnStart property creates the collection with only the columns I need:

// create collection of CSRItems for use in the editable gallery. Also clear it so that collection is empty.
ClearCollect(colCSRItems,
      ShowColumns(
          Table(Defaults(CSRItems)),
              "ID",
              "Response",
              "EstCmplDt"
      )
);

Doing this also enable me to add an icon to each gallery row that appears if either editable value was changed, letting the user know what rows they changed.  That is simple code for the Visible property of the icon:

And(ThisItem.ID in colCSRItems.ID, varEditCSGallery)

I hope this answers your question.