OnSelect Functions: How much is too much?

[SoConfused]

I am pretty new to this, and I have a few OnSelect functions that seem a bit long to me. Is there a "best practices" in terms of limiting OnSelect functions? I don't know much, and my functions may not be complicated at all, but just wanted to see what ya'll thought. I know I only had to say If() once but I got frustrated trying to figure out how to write it as a continuous function. lol I will go back and fix it at some point. So is this too much? It's working fine so far, but I wanted to check.  Also, if you know of a better way to accomplish this I would be very appreciative!! 

If(VarIsRevr1,Patch('Staff Action Processing', Gallery3.Selected,{Rec1:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr1Comment: TextInput2.Text}));
If((VarIsRevr2,Patch('Staff Action Processing', Gallery3.Selected,{Rec2:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr2Comment: TextInput2.Text}));
If(VarIsRevr3,Patch('Staff Action Processing', Gallery3.Selected,{Rec3:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr3Comment: TextInput2.Text}));
If(VarIsRevr4,Patch('Staff Action Processing', Gallery3.Selected,{Rec4:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr4Comment: TextInput2.Text}));
If(VarIsRevr5,Patch('Staff Action Processing', Gallery3.Selected,{Rec5:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr5Comment: TextInput2.Text}));
If(VarIsRevr6,Patch('Staff Action Processing', Gallery3.Selected,{Rec6:ComboBox3_1.Selected}),Patch('Staff Action Processing',Gallery3.Selected,{Revr6Comment: TextInput2.Text})); SubmitForm(Form2_4);Refresh('Staff Action Processing');Reset(Toggle3_1);Reset(TextInput2);Reset(ComboBox3_1); Navigate(SAPAction);

[TheRobRush]

What exactly is

VarIsRevr1

etc. that the statement is checking?

[SoConfused]

@TheRobRush It's a variable I set OnStart, it compares the currentUser.Email, to the .Email property of several columns in the SPlist. Then it is used to determine which records are displayed, which records are patched, and what status change occurs after each action. 

[TheRobRush]

Is it always one of these options per person (assuming these variables are set to true/false?) or can some people have VarIsRevr1 & VarIsRevr2 true, etc

[SoConfused]

@TheRobRush The person can be at any stage of review (Rev1-Rev6), but will never listed more than once in any given record. Funny enough, when you asked me about VarIsRevr1, I went back and realized I made a huge mistake by placing it OnStart. There was no record for it to identify, so it was returning the value of the first entry in each column. So I'll be starting over with trying to specify the user again. This was disheartening. lol Here is how I set it up, I'm sure you will notice why it "worked" but didn't actually do what I needed it too. 

Set(VarIsRevr1,!IsBlank(LookUp('Staff Action Processing',(Revr1.Email = VarUserEmail)))); 

I can't believe I didn't notice that. I moved it to the OnVisible Property of the screen that contains the form, hopefully it will work now written as:

Set(VarIsRevr1,!IsBlank(LookUp('Staff Action Processing',ID=varID,(Revr1.Email = VarUserEmail))));

It's probably still not the most efficient way, but I am pretty much teaching myself from this forum and google. 

[TheRobRush]

So, if I understand correctly the checks in your If() on Onselect for VarIsRevr1 - VarIsRevr6 are a check on if that person is located in the record for THAT step. So since it is step specific only one at a time should ever be true correct? (When Button etc is pressed and say VarIsRevr4 is true, all others will be false?)

[SoConfused]

@TheRobRush @Yes, because it is checked against the current user. And the current user will only appear on each form one time