Speeding up Patch process

[Carl1291]

HI All,

Thanks in advance for the support but i am currently creating an app which needs to patch multiple lines on a database. Currently this takes around a second or so but want to make it more efficient.

my current formula is;

Patch(Table1_2;LookUp(Table1_2,watch_ID='Device 1 Input'.Text),{'Allocated to':'Colleague Name Input'.Text,Shift:'Shift Box'.Text,status:"Engaged",Time:Now()});Patch(Table1_2;LookUp(Table1_2,watch_ID='Device 2 Input'.Text),{'Allocated to':'Colleague Name Input'.Text,Shift:'Shift Box'.Text,status:"Engaged",Time:Now()});Patch(Table1_2;LookUp(Table1_2,watch_ID='Device 3 Input'.Text),{'Allocated to':'Colleague Name Input'.Text,Shift:'Shift Box'.Text,status:"Engaged",Time:Now()});Reset('Device 1 Input');Reset('Device 2 Input');Reset('Device 3 Input');Reset('RP Number Input');Refresh(Table1_2)

Essentially its looking in 3 different input boxes and then based on that information is matching it up and finding the row, then filling in the relevant data on that row.

I'm not sure if a collection is best, but when trying It doesn't allow me to find the information from the table.

I'm also looking to add into this that whatever info we are patching here is also patched into another table which is being used as a change history.

Any help is much appreciated.

Thanks

[WarrenBelz · Accepted solution]

Hi @Carl1291 ,

This should be quicker - also forget the Refresh - it is not necessary and only degrades performance.

UpdateIf(
   Table1_2,
   watch_ID = 'Device 1 Input'.Text ||
   watch_ID='Device 2 Input'.Text ||
   watch_ID='Device 3 Input'.Text,
   {
      'Allocated to': 'Colleague Name Input'.Text,
      Shift: Shift Box'.Text,
      status: "Engaged",
      Time: Now()
   }
);   
Reset('Device 1 Input');
Reset('Device 2 Input');
Reset('Device 3 Input');
Reset('RP Number Input')

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

[Carl1291]

@WarrenBelz Thanks for this, it worked, Are you able to advise how i would be able to get this to update and add the record i am updating to another table as part of this?

[WarrenBelz]

Hi @Carl1291 ,

Sorry I am not clear on what you want here - are you adding the same records as new items in another table (assuming the same field names)

Patch(
   YourOtherList,
   Defaults(YourOtherList)
   {
      'Allocated to': 'Allocated to',
      Shift: Shift Box'.Text,
      status: "Engaged",
      Time: Now()
   }
)

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps

[Carl1291]

Hi @WarrenBelz, Yes, i am essentially wanting to add any updates i make to another database which tracks all the changes and details of who actioned this. When i added this below, it has slowed down the time it takes to go through all the actions and i'm looking at around 5 seconds now.

[WarrenBelz]

HI @Carl1291 ,

You probably need to stop focussing on speed once this is optimized as best as it can be - you are writing multiple records to two different data sources. I could suggest something like this

With(
   {
      wPatched:
      DateAdd(
         Now(),
         -2.
         Seconds
      )
   },
   With(
      {
         wItems: 
         Filter(
            Table1_2,
             (
                watch_ID = 'Device 1 Input'.Text ||
                watch_ID='Device 2 Input'.Text ||
                watch_ID='Device 3 Input'.Text
            ) &&
            Created > wPatched
         )
      },
      Patch(
         YourOtherList,
         ForAll(
            wItems As aPatch,
            {
               'Allocated to': aPatch.'Allocated to',
               Shift: aPatch.Shift,
               status: aPatch.Status,
               Time: Now()
            }
         )
      )
   )
)

which looks in the other list for items created in the last two seconds (you can adjust this to suit) with the matching criteria and then sends them to the new list as new records.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Visit my blog Practical Power Apps