Solved: Re: Forall / Patch Invalid argument

Anonymous · ‎06-09-2021

Hi There,

I am trying to duplicate records using forall / patch but not being able to apply the function as you can see below.

Can you identify what am I doing wrong, please?

Basically I have a gallery created from my Purchase Order Items table and I need to duplicate these items but with a new Parent ID.

Till this step I am fine... I created a collection and used the UpdateIf to update the new Parent ID.

The next step, where I am having issues, is to use this collection and create new records on my Purchase Order Items table with Forall/patch, but this is what I get.

Appreciate if you can help me.

Cheers,

Leo Couto

RandyHayes · ‎06-09-2021

@Anonymous

Yes, dropping the columns is not relevant in this case because you are specifically defining the record schema in the ForAll.

Ah, change the names of the columns in the record schema (in your ForAll) to be the real names of the columns in the datatable. The collect statement wants to have the real names of the columns. The real names are listed as the "Name" in the column definitions of the table.

However, before going that route, try this with a Patch. I am not recalling which functions require real names and which are the assumed names at this point.

Patch('T-Purchase Order Items',
    ForAll(GalPOItems.AllItems As _item,
        {'T-Purchase Order ID': vPOAmended,
         Item: _item.Item,
         Description: _item.Description,
         'Part#': _item.'Part#',
         Qty: _item.Qty,
         'Unit Value': _item.'UnitValue,
         Total: _item.Total,
         'T-Vessel ID': _item.'T-Vessel ID',
         'T-Account ID': _item.'T-Account ID'
        }
    )
)

If that does nothing, then change to the real column names.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes
Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

CNT · ‎06-09-2021

@Anonymous What's the error?

Anonymous · ‎06-09-2021

Sorry, here it is:

CNT · ‎06-09-2021

@Anonymous Is there any code after this ForAll()

RandyHayes · ‎06-09-2021

@Anonymous

Please consider changing your Formula to the following:

ClearCollect(GPOItems,
    ForAll(GalPOItems.AllItems As _item,
        Patch(_item, {Qty:0, 'T-Purchase Order ID': vPOAmended})
    )
)

ForAll returns a table of records, it is not a development For/Loop function. Use it to populate the collection.

Although it appears you are using collections for datashaping...in which case you can actually avoid all of the collections and just shape your data for the patch/collect to the datasource.

I hope this is helpful for you.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes
Really want to show your appreciation? Buy Me A Cup Of Coffee!

Anonymous · ‎06-09-2021

No.. that's the last line.

Very weird, no?

CNT · ‎06-09-2021

@Anonymous

I did a test. I have a SP List called Employee with 7 records and then I ran this code,

ClearCollect(colEmployee, Employee);
ForAll(colEmployee, Patch(Employee, Defaults(Employee), {Name:"tom"}))

And.... I got 7 Toms!

So, in my opinion the way you are using ForAll seems fine.

Anonymous · ‎06-09-2021

Thanks, Rande.

Noted, you're right. I can use it direct from the gallery instead add a new collection.

But I can't see how it will return the data to my datasource ("T-Purchase Order Items"), can you clarify, please?

It seems that your formula patches back the collection, but I still need to patch that collection to new records on my datasource.

Cheers,

Leo

RandyHayes · ‎06-09-2021

@Anonymous

Then skip the collections all together and change your formula to:

ClearCollect(GPOItems,
    ForAll(GalPOItems.AllItems As _item,
        Patch(_item, {Qty:0, 'T-Purchase Order ID': vPOAmended})
    )
)

Sorry, I'm on my mobile phone and can't seem to edit the above.

It's the first line to change to :

Collect('T-Purchase Order Items',

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes
Really want to show your appreciation? Buy Me A Cup Of Coffee!