OnChange acting weird

[crispybits1977]

Hi all

I have a timesheets app, and in all the hours and minutes boxes on the timesheets in the OnChange property is this code:

If(IsBlank(TL1D.SelectedDate) && IsBlank(TL1ASH.Text) && IsBlank(TL1ASM.Text) && IsBlank(TL1AFH.Text) && IsBlank(TL1AFM.Text) && IsBlank(TL1PSH.Text) && IsBlank(TL1PSM.Text) && IsBlank(TL1PFH.Text) && IsBlank(TL1PFM.Text),Set(TL1Error,false),
If(!IsBlank(TL1D.SelectedDate) && !IsBlank(TL1ASH.Text) && !IsBlank(TL1ASM.Text) && !IsBlank(TL1AFH.Text) && !IsBlank(TL1AFM.Text) && IsBlank(TL1PSH.Text) && IsBlank(TL1PSM.Text) && IsBlank(TL1PFH.Text) && IsBlank(TL1PFM.Text),Set(TL1Error,false),
If(!IsBlank(TL1D.SelectedDate) && !IsBlank(TL1ASH.Text) && !IsBlank(TL1ASM.Text) && !IsBlank(TL1AFH.Text) && !IsBlank(TL1AFM.Text) && !IsBlank(TL1PSH.Text) && !IsBlank(TL1PSM.Text) && !IsBlank(TL1PFH.Text) && !IsBlank(TL1PFM.Text),Set(TL1Error,false),
If(!IsBlank(TL1D.SelectedDate) && IsBlank(TL1ASH.Text) && IsBlank(TL1ASM.Text) && IsBlank(TL1AFH.Text) && IsBlank(TL1AFM.Text) && !IsBlank(TL1PSH.Text) && !IsBlank(TL1PSM.Text) && !IsBlank(TL1PFH.Text) && !IsBlank(TL1PFM.Text),Set(TL1Error,false),
Set(TL1Error,true)))));


If(((TL1AMF-TL1AMS)+(TL1PMF-TL1PMS))<15,Set(TL1Error,true),false);
If(IsBlank(Inp_TSEntryTotalHours.Text),Set(TL1Error,true),false);
If(IsBlank(TextInput1.Text),Set(TL1Error,true),false)

The TL1Error variable is how the app determines if the "Submit" button is disabled or not.

The trouble I'm having is if I leave TextInput1 blank then the timesheet should not be able to be submitted, thanks to the last line in that code turning TL1Error true. However if I use the app when I make a change in any of the minutes or hours fields TL1Error becomes false regardless of if TextInput1 has anything entered in it, enabling the button, and only becomes true again when I tab out of that field or click into another field. This is allowing submissions without the information required in TextInput1.

I don't understand why it's doing this. Surely if the OnChange code is running for the first section of the code to change TL1Error to false, then it should continue to run and find the line that says to make it true if TextInput1 is blank and do that. Can anyone see any reason why it should change TL1Error to false in the first section because the right combo of hours/minutes/date boxes are not blank for a valid entry, but then not run the code below that changes it back to true? (line breaks added between the lines of code just to make explaining it here easier)

[crispybits1977]

PS I have also tried If(Len(TextInput1.Text)=0,Set(TL1Error,true),false) and it didn't resolve the problem - have read some other posts that say there's sometimes issues if there is a default set (which in my case there is a variable set as default for TextInput1 but it's 0 characters long unless I activate a checkbox which is not activated in this scenario)

[v-jefferni · Accepted solution]

Hi @crispybits1977 ,

You should set DisplayMode of the submit button directly based on the conditions of all those controls:

If(
    IsBlank(TextInput1.Text) || ((TL1AMF-TL1AMS)+(TL1PMF-TL1PMS))<15 || IsBlank(Inp_TSEntryTotalHours.Text) || !(IsBlank(TL1D.SelectedDate) && IsBlank(TL1ASH.Text) && IsBlank(TL1ASM.Text) && IsBlank(TL1AFH.Text) && IsBlank(TL1AFM.Text) && IsBlank(TL1PSH.Text) && IsBlank(TL1PSM.Text) && IsBlank(TL1PFH.Text) && IsBlank(TL1PFM.Text)) || (!IsBlank(TL1D.SelectedDate) && !IsBlank(TL1ASH.Text) && !IsBlank(TL1ASM.Text) && !IsBlank(TL1AFH.Text) && !IsBlank(TL1AFM.Text) && IsBlank(TL1PSH.Text) && IsBlank(TL1PSM.Text) && IsBlank(TL1PFH.Text) && IsBlank(TL1PFM.Text)) || (!IsBlank(TL1D.SelectedDate) && !IsBlank(TL1ASH.Text) && !IsBlank(TL1ASM.Text) && !IsBlank(TL1AFH.Text) && !IsBlank(TL1AFM.Text) && !IsBlank(TL1PSH.Text) && !IsBlank(TL1PSM.Text) && !IsBlank(TL1PFH.Text) && !IsBlank(TL1PFM.Text)) || (!IsBlank(TL1D.SelectedDate) && IsBlank(TL1ASH.Text) && IsBlank(TL1ASM.Text) && IsBlank(TL1AFH.Text) && IsBlank(TL1AFM.Text) && !IsBlank(TL1PSH.Text) && !IsBlank(TL1PSM.Text) && !IsBlank(TL1PFH.Text) && !IsBlank(TL1PFM.Text)), 
    DisplayMode.Disabled, 
    DisplayMode.Edit
)

Maybe the conditions are not correct in my formula, and you need to adjust it, but the point to this question is you need to list all the conditions that when the button CANNOT be interacted in a single If statement. 

Best regards,

[crispybits1977]

Thanks @v-jefferni - sometimes it's the obvious solution you just don't see.

(The system originally had 7 lines they could put data into so I had TL1Error, TL2Error, etc but now there's only a single line input but I was still trying to force it to work the old way and wasn't thinking about the fact the system had changed and something easier was now viable.)