Patch dropdown values

[AOZ]

Good day,

I have my sharepoint list with the column Department being of type CHOICE.

In powerapps i am collecting the values (last line):

Collect(ColItemsToKeep, 
{
Order_No: DataCardValue5.Text,
Covid_choice: DataCardValue37.Value,
Je_Respecte: DataCardValue60.Value, 
EPI_ND: DataCardValue35.Text, 
Acces_cabine: DataCardValue61.Value,
Je_Realise: DataCardValue104.Value,
Autres_Commentaires: DataCardValue6.Text,
Department: DataCardValue13.SelectedItems
}
);

Then i am patching some values along with the Department value collected to the sharepoint list (still last line):

ForAll(ColItemsToKeep,Patch('Take5 V1',Defaults('Take5 V1'), 
{
Title: Order_No,
Covid_Choice: Covid_choice,
Je_Respecte_Les_Regles: Je_Respecte, 
EPI_ND: EPI_ND, 
Je_Dois_Acceder_a_la_Machine: Acces_cabine,
'Sanitize Cabin': Sanitize_cabin,
'Sanitize Keys': Sanitize_Keys,
'Autre(s) Risque(s)': Autres_risques,

'I Plan': Je_Planifie,
I_Plan_Comments: Je_Planifie_Comment,

SAFE: Je_Realise,
'General Comments': Autres_Commentaires,
Department:Department

 }
));

 I am however getting an error:

The type of this argument 'Department' does not match the expected type 'Record'. Found type 'Table'.

Help please...all other values are correctly being collected and patched.

Thanks.

[RandyHayes]

@AOZ 

Your Choice column is a single selection column.  You are trying to set the column to SelectedItems - which is a table.

You need to collect the value of the selection, not the table of selections.

It appears you are using a form as I see a lot of DataCardValue control names.  You should really save yourself a TON of unneeded work by using the submit on the form.  I know you are also doing your app for offline use, so you should be collecting records directly from the Form from the Updates property.  This will have Everything in it for the record and will not only keep you from having to define all the columns but also be able to completely reduce your final patching formula down to a simple line.

Ex. :   To collect the form record - Collect(ColItemsToKeep, yourForm.Updates)

then to patch - Collect('Take5 V1', ColItemsToKeep)

This would save you a ton of trouble!

I hope this is helpful for you.

[AOZ]

@RandyHayes 

Hi again! Yes i understand your point. As i new and have reached quite far in the coding...a bit difficult for me to revert back. I will keep all your precious advices for another app which i will be developing.

But for now, can you indicate how to collect the "value" and not the table of selections?

And also, good syntax for the patching?

P.S: Pens down today!

[RandyHayes]

@AOZ 

No pens...too bad!  Yes, I'm all about getting people to go simple with PowerApps.  It makes a world of difference and keeps traction moving with this platform.

Yes...so then your collection statement would be:

Collect(ColItemsToKeep, 
{
Order_No: DataCardValue5.Text,
Covid_choice: DataCardValue37.Value,
Je_Respecte: DataCardValue60.Value, 
EPI_ND: DataCardValue35.Text, 
Acces_cabine: DataCardValue61.Value,
Je_Realise: DataCardValue104.Value,
Autres_Commentaires: DataCardValue6.Text,
Department: DataCardValue13.Selected.column
}
);

Since the "column" to specify in the above is unique to your combobox, you need to replace it with the appropriate name.  Ex. if your Items property is Choices function bases, then replace above with Value.  If it is Distinct based, then replace with Result.  If it is based on a datasource, then replace with the column name you want.

For your Patch - you don't need to use patch.  Collect will do what you want, create new records:

Collect('Take5 V1',
    ForAll(ColItemsToKeep,
        {
         Title: Order_No,
         Covid_Choice: Covid_choice,
         Je_Respecte_Les_Regles: Je_Respecte, 
         EPI_ND: EPI_ND, 
         Je_Dois_Acceder_a_la_Machine: Acces_cabine,
         'Sanitize Cabin': Sanitize_cabin,
         'Sanitize Keys': Sanitize_Keys,
         'Autre(s) Risque(s)': Autres_risques,
         'I Plan': Je_Planifie,
         I_Plan_Comments: Je_Planifie_Comment,
         SAFE: Je_Realise,
         'General Comments': Autres_Commentaires,
         Department:Department
        }
    )
)

[AOZ]

@RandyHayes 

Maybe i have wrongly explained myself...i don't have the selected.column as you advised...

Here are some screenshots of the sharepoint list "Department" column...

[RandyHayes]

@AOZ 

You have explained well and I understand the issue completely.  This actually nothing to do with your column, this is everything to do with the property you are selecting in your formula.  You are using SelectedItems - that property is a Table of records of items selected.  You need to specify the Record selected.  This is in the Selected property.  But then you need (depending on the Items property of the control) to specify the column of that record.  This is the record as it is in your App, nothing to do with the column definition in your list.

A Choice column in SharePoint is a record.  It has a Value column.  

BUT, what you choose is completely dependent on the Control Items property.

So...what is your Items property on the control named : DataCardValue13 ??

[AOZ]

@RandyHayes 

Here you are:

Choices([@'Take5 V1'].Department)

[RandyHayes · Accepted solution]

@AOZ 
Perfect!  Then the Choices function will already be providing everything you need.  The ONLY thing you need to change in the collect formula is to change .SelectedItems to .Selected

Because again, SelectedItems is a table, and your column is not defined to allow multiple values.  Selected is a record...and it will already have the schema signature necessary to supply to your datasource when you use it to make new records in the other formula.

[AOZ]

@RandyHayes 

OK thanks - but it still says that the function Collect has some invalid arguments.

Incompatible type. The type you're trying to put into a collection has a type that's not compatible with the collection.

Collect(ColItemsToKeep,
{
Order_No: DataCardValue5.Text,
Covid_choice: DataCardValue37.Value,
Je_Respecte: DataCardValue60.Value,
EPI_ND: DataCardValue35.Text,
Acces_cabine: DataCardValue61.Value,
Sanitize_cabin: DataCardValue11.Value,
Sanitize_Keys: DataCardValue12.Value,
Sanitize_vehicle: DataCardValue2.Value,
Sanitize_knobs: DataCardValue1.Value,
Sanitize_int_ext: DataCardValue3.Value,
Sanitize_others: DataCardValue4.Value,

Compétences: DataCardValue42.Value,
Manuels_Techniques: DataCardValue43.Value,
Instructions: DataCardValue44.Value,
Outils: DataCardValue45.Value,
EPI_Pas_Dispo: DataCardValue46.Value,
Sortie_secours: DataCardValue47.Value,
Places: DataCardValue48.Value,
Environnement: DataCardValue49.Value,
Machine_pas_propre: DataCardValue50.Value,
Autres: DataCardValue7.Value,

Des_Machines: DataCardValue51.Value,
Dautres_Personnes: DataCardValue52.Value,
De_Lelectricite: DataCardValue53.Value,
Des_Bruits: DataCardValue54.Value,
Des_charges: DataCardValue55.Value,
Produits_chimiques: DataCardValue56.Value,
des_vehicules: DataCardValue57.Value,
la_hauteur: DataCardValue59.Value,
Autres_risques: DataCardValue58.Value,

Je_Planifie: DataCardValue16.Value,
Je_Planifie_Comment: DataCardValue38.Text,

Je_Realise: DataCardValue104.Value,
Autres_Commentaires: DataCardValue6.Text,
Department: DataCardValue13.Selected

}
);

[RandyHayes]

@AOZ 

Yep...just another "plus one" for why not to do this kind of thing!  It's not only way too much work, but it is fraught with issues and compatibility.

Now (off the soap box), since you're sticking with this, the question is with the issue that the error is related to - is is in fact complaining about the Department column?  Remove that from your collect formula and see if the error goes away.  If it doesn't, then you need to find which column it is complaining about.

If it does go away, then you need to look at EVERY other place that you are doing anything with that collection in your app to see if you are setting that column to a different type.