SP List Not Updating When Power App Form is Submitted

[golfnutt82]

Good morning,
I have a power app form that is pulling in data from my "Roles" list into my "Access Request" form.
There are only three fields being populated manually.
1. LU_Role Name
2. Requestor
3. Justification

All other fields are populated based on the key field LU_Role Name

I am using this expression in the OnChange property of the LU_Role Name control to update the fields on the right side of the form. 

The issue is that only the Requestor and Justification field is being added to the SP List "Access Requests"
I need all fields on this form to be included.
The logic for the "Submit" button is as follows - 

What am I doing wrong?

[golfnutt82]

The people I am working with say its too much of a hasle to scroll through all the roles and would like to filter it.
First they were talking about a mid string function to search for any combination of text but then I found solution that I show which captures the first chars of the string.
I am going to try and keep that functionality in the form and get rid of the controls outside the form.
Is that ok?

[RandyHayes · Accepted solution]

@golfnutt82 

Yes, I would say take it a step at a time.  You can move the search directly to the dropdown with the filter statement that you have now on the Dropdown1_1 control.

HOWEVER...there will be an alteration to be made.  

Your Dropdown outside of the form has an Items property that contains Records from the Roles list directly.

The Dropdown inside your form is using the Choices function.  This will have records that have an Id and Value column only.  They are different, but the change is easy to implement.

So, for your Dropdown in the Form...

Items property: Filter(Roles, StartsWith(Role, TextSearch1.Text))

For the Default property: LookUp(Roles, ID=ThisItem.'LU_Role Name'.Id, Role)

For the Update property on the datacard:

    With(DataCardValue4.Selected, {Id: ID, Value: Role})

The above on the Update is important as you need to convert from the Roles record to a LookUp record.

[golfnutt82]

Hi Randy and good morning,
I believe I am almost there! Hoorah!
The only thing that is keeping this from working is when I enter the logic in the OnChange property used to populate the read only fields on the right. I get an error.

Any ideas?
Thank you!

[RandyHayes · Accepted solution]

@golfnutt82 

Great! Sounds like progress!!

So, my suggestion there is to get rid of the OnChange formula all together.

Think about it this way, you're double data-dipping.  You've already gone through the expense of getting all the records for the Dropdown, so you already have the data.  Why do another lookup to get it again?

The formula on the Items property - Filter(Roles, StartsWith(Role, TextSearch1.Text)) is going to return the record for each role in it.  Therefore, the Selected property of that will have all the columns of that record.

So first, doing the Selected.Value is not going to be valid unless you have a Value column in your Roles records...which you  don't.

All you need to do is reference the dropdown for the controls on the right.

So, for example, the Associated Site textinput control.  You currently have RoleInfo.'Associated Site' as you are referencing that variable that you are maintaining.  Just change the Default to: DataCardValue11.Selected.'Associated Site'  

Then do the other ones where you were using that variable to the same, but with their column name.

Doing it this way, you only access data once and have no variable that has to be maintained in your app.

[golfnutt82]

Yes, that totally makes sense and I understand now.
The form now works as expected!
Thank you Randy for your mentorship!
An excellent learning opportunity!

[RandyHayes]

@golfnutt82 

Happy to help and glad we got to that point before the holiday!!

Have a Happy New Year!

[golfnutt82]

Happy New Year to you and yours!