uploading collection contents online

[AOZ]

Dear all,
I have to upload the images (and also some form values) into sharepoint.
The ColItemsToKeep are correctly synchronised to the sharepoint list. Even if i have 2 records in the collection, sharepoint is correctly updated with 2 records.

However for the ColImage, sharepoint is updating my site with only the last record.
Both collections however contains all records and photos.

The above are used only when working offline. Items are saved in 2 collections and then via power automate, the items are synchronised to list and sharepoint site.
When online, everything works fine - all records and images are correctly created.

Here is the code:

ForAll(ColItemsToKeep,Patch('Take5 V1',Defaults('Take5 V1'),
{
Title: Order_No,
Covid_Choice: Covid_Choice,
Je_Respecte_Les_Regles: Je_Respecte,
EPI_ND: EPI_ND,
Je_Dois_Acceder_a_la_Machine: Acces_cabine,
'Sanitize Cabin': Sanitize_cabin,
'Sanitize Keys': Sanitize_Keys,
'Air Vehicle': Sanitize_vehicle,
'Sanitize Knobs': Sanitize_knobs,
'Sanitize Interior': Sanitize_int_ext,
'Sanitize all other': Sanitize_others,

Compétences: Compétences,
Manuels_Techniques: Manuels_Techniques,
Instructions: Instructions,
Outils: Outils,
EPI_Pas_Disponible: EPI_Pas_Dispo,
Sortie_De_Secours: Sortie_secours,
Places: Places,
Environnement_pas_securisé: Environnement,
Machine_pas_propre: Machine_pas_propre,
Autres_Moyens: Autres,

'Des Machines': Des_Machines,
'Dautres Personnes': Dautres_Personnes,
'De lElectricité': De_Lelectricite,
'Des Bruits': Des_Bruits,
'Des charges lourdes': Des_charges,
'Des Produits Chimiques': Produits_chimiques,
'Des Véhicules': des_vehicules,
'La Hauteur': la_hauteur,
'Autre(s) Risque(s)': Autres_risques,

'I Plan': Je_Planifie,
I_Plan_Comments: Je_Planifie_Comment,

SAFE: Je_Realise,
'General Comments': Autres_Commentaires
}
));

ForAll(ColImage,
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3.Text,DataCardValue36.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_1.Text,DataCardValue36_1.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_2.Text,DataCardValue36_2.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_3.Text,DataCardValue36_3.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_4.Text,DataCardValue36_4.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_5.Text,DataCardValue36_5.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_6.Text,DataCardValue36_6.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_7.Text,DataCardValue36_7.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_8.Text,DataCardValue36_8.Image),false);
If(Label8.Text= "Connected",UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_9.Text,DataCardValue36_9.Image),false);
)

[RandyHayes]

@AOZ 

First, you can highly simplify your Formula by having the column names in your collection match the real column names in your SharePoint list.  When the column names match correctly, you can replace your entire first formula with :   Collect('Take5 V1', ColItemsToKeep)

Now, to the second formula, you may be iterating through a collection (ColImage), but you are referencing TextInput controls and an Image control (datacardvalue36_x) in your formula.  This will only give you the current values of those items.

If your iterations are over the ColImage collection, then you should really have the image and text in your collection.

Then your formula would be:

If(Connection.Connected, 
   ForAll(ColImage, 
       UploadaphototoSharePointfromPowerApps_1.Run(ImageTextColumnFromColImage, 
          ImageColumnFromColImage)
   )
)

So, the point being...when you are collecting into ColImage, collect the image and text as well.

I hope this is helpful for you.

[AOZ]

Dear @RandyHayes 

Thanks for helping out.

Thanks for the tip for the column names.

For the second issue - i am indeed collecting the image and text:

Collect(ColImage,
{
    File: DataCardValue36.Image, Name: TextInput3.Text,
    File2: DataCardValue36_1.Image, Name2: TextInput3_1.Text,
    File3: DataCardValue36_2.Image, Name3: TextInput3_2.Text,
    File4: DataCardValue36_3.Image, Name4: TextInput3_3.Text,
    File5: DataCardValue36_4.Image, Name5: TextInput3_4.Text,
    File6: DataCardValue36_5.Image, Name6: TextInput3_5.Text,
    File7: DataCardValue36_6.Image, Name7: TextInput3_6.Text,
    File8: DataCardValue36_7.Image, Name8: TextInput3_7.Text,
    File9: DataCardValue36_8.Image, Name9: TextInput3_8.Text,
    File10: DataCardValue36_9.Image, Name10: TextInput3_9.Text
    }
    )

Then when running the flow, i have adapted it as per your advice. Is it OK? 

If(Label8.Text="Connected",
ForAll(ColImage,UploadaphototoSharePointfromPowerApps_1.Run(TextInput3.Text,DataCardValue36.Image));
ForAll(ColImage,UploadaphototoSharePointfromPowerApps_1.Run(TextInput3_1.Text,DataCardValue36_1.Image));
)

 I think there may be a problem somewhere because only the last recorded photos are being created...

[RandyHayes]

@AOZ 

So your issue then is that you are not using the values in your collection.  You are referencing values from the screen.

Your formula should be more like this (based on your collection):

If(Label8.Text="Connected",
    ForAll(ColImage,
        UploadaphototoSharePointfromPowerApps_1.Run(Name1,File));        
        UploadaphototoSharePointfromPowerApps_1.Run(Name2,File2));
        etc...
    )
)

But this is really redundant!!

You would be better off collecting your data as follows:

Collect(ColImage,
    {File: DataCardValue36.Image, Name: TextInput3.Text},
    {File: DataCardValue36_1.Image, Name: TextInput3_1.Text},
    {File: DataCardValue36_2.Image, Name: TextInput3_2.Text},
    {File: DataCardValue36_3.Image, Name: TextInput3_3.Text},
    {File: DataCardValue36_4.Image, Name: TextInput3_4.Text},
    {File: DataCardValue36_5.Image, Name: TextInput3_5.Text},
    {File: DataCardValue36_6.Image, Name: TextInput3_6.Text},
    {File: DataCardValue36_7.Image, Name: TextInput3_7.Text},
    {File: DataCardValue36_8.Image, Name: TextInput3_8.Text},
    {File: DataCardValue36_9.Image, Name: TextInput3_9.Text}
)

Then have your upload when connected as:

If(Label8.Text="Connected",
    ForAll(ColImage,
        UploadaphototoSharePointfromPowerApps_1.Run(Name,File));        
    )
)

This will return a table of Flow results.

[AOZ]

Dear @RandyHayes 

Thanks - this works out perfectly now!

Am really new to all this.

Last thing maybe - the collection is still displaying the contents of the image control although i clear the collection. As soon as i save only 1 photo, all the others get into the collection also...is there a way to delete the contents of all the image control once the form is loaded? this is to ensure that the image controls are really blank each time the form loads.

[RandyHayes]

@AOZ 

I need to know a little more about the setup of your screen that you are showing.  Is this a gallery or have you hand made all of the controls that I see individually?

[AOZ]

Hi @RandyHayes 

All the images are managed manually - image = camera1.photo

I then collect all these images (only when the checkbox becomes true).

The problem is that even if the checbox is false and that a previous photo was taken when it was true, the image remains in the background and goes to the collection.

Checkbox (Visible state):

If(DataCardValue42.Value = true,true,false)

[RandyHayes]

@AOZ 

I cannot tell if you are working with Forms or something else.  You state DataCardValues, and those are typical names for controls in forms. 

In general, with this many photos and checkboxes, you would be better served with a Gallery.

But, I'd need to know more about the flow and process that you have in your app to suggest anything substantial. 

What is it that you are trying to achieve overall with the app?

Also, you have a flow associated with this app, what is it doing?

Nice pen by the way! 🤣🤣

[AOZ]

@RandyHayes 

Thanks for the compliment 😂

In fact it is an app which will allow mechanical technicians to answer a kind of questionnaire before beginning a work on a machine.

He needs to create a new form, fill in comments and answer questions (there are 5 sections in the form).

Most of the time no internet connection is available on site - this is why we need to store all in collections and then when he reaches home and connects to the internet, he pushes a button to upload to sharepoint.

So basically he needs to activate some checkboxes when necessary, the camera is activated - he takes the picture and the textbox above the picture stores the name of the picture.

As regards the flow associated, there is only 1 which creates and copies the images to a sharepoint library. This flow is run when internet is active.

Hope this helps for better understanding.

[RandyHayes]

@AOZ 

Yes, very clear....I've made this app now I don't know how many times!  For my clients this is often requested for field technicians to take photos of equipment, tags, etc.

I was wondering about the flow in terms of seeing if you were using a document library for your photos...and you are.

So, the key part of this is that your Image collecting and information is all separate from the Form.  The form is doing its thing and then you just happen to be collecting the Updates property of the form in your collection (as opposed to how you might be manually doing it now).  This will then have the full record with all the proper columns and values that you can then just collect to your data source.

Collect(colOffline, yourForm.Updates)

later...

Collect(yourList, colOffline)

So, since the images are separate from the form information.  My next question would be this...how are you associating the image with the master record collected?  I don't see that in your formulas.