cancel
Showing results for 
Search instead for 
Did you mean: 
Reply

Power Apps collection Patch creates duplicate rows in the sharepoint list with data from the last row of the collection

Newbie.  Confused.  Collection Creation:

 

NewForm(Form1);ClearCollect(ActionDetails, {Action: "", State: "", ItemType: "", ItemCode: "", Pieces: 0, SFBFt: 0, From: "", To: "", Remarks: "", ShowSave: true});Navigate(NewActivity,ScreenTransition.Cover)

Collection:

cpill1220_1-1663955435046.png

 

 

OnSuccess of Form1:

ForAll(ActionDetails, Patch(DailyActivityDetails, Defaults(DailyActivityDetails), {Action: ddAction.Selected, State: ddState.SelectedText, ItemType: ddIType.SelectedText, ItemCode: ddICode.SelectedText, Pieces: Value(tPieces.Text), SFBFt: Value(tSFBFt.Text), From: cbFrom.Selected.location, To: cbTo.Selected.location, Remarks: tRemarks.Text, MasterID: Form1.LastSubmit.ID}))

 

SharePoint List:

cpill1220_2-1663955575944.png

 

Could someone help me? Is this enough info to tell what I did wrong to cause the SharePoint list to create the exact number of rows from my collection, but with duplicate data from the last row/record of the Collection?

 

I GREATLY appreciate any help.

 

 

 

 

1 ACCEPTED SOLUTION

Accepted Solutions

@cpill1220 

Okay, so the collection is only needed as a basic "base" for the gallery.  You don't need to do anything special with it.  It just needs to have the primary key (ID) of the records in it (or blank if none).  Patch will do the rest.

 

So. this means you are referencing the wrong data when you Patch!

You are referencing the controls in the gallery in your Patch.  When you do that out of context of the gallery, all you will get is the last selected item in the gallery...THIS explains why you are seeing the same records repeated.

 

Your Formula needs the context of the Gallery!!

It should be:

Patch(DailyActivityDetails, 
    ForAll(yourGallery.AllItems, 
       {ID: ID, 
        Action: ddAction.Selected, 
        State: ddState.Selected.Value, 
        ItemType: ddIType.Selected.Value, 
        ItemCode: ddICode.Selected.Value, 
        Pieces: Value(tPieces.Text), 
        SFBFt: Value(tSFBFt.Text), 
        From: cbFrom.Selected.location, 
        To: cbTo.Selected.location, 
        Remarks: tRemarks.Text, 
        MasterID: Self.LastSubmit.ID
      }
   )
)

 

That is it!

 

Now, I notice you have some provisions for delete in your gallery - That needs to be addressed separately.  

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

View solution in original post

10 REPLIES 10

@cpill1220 

To start, your formula has the ForAll backward. You are trying to use it like a ForLoop in some development language - which PowerApps is not.  ForAll is a function that returns a table of records based on your iteration table and record schema.

It is more efficient to use the function as intended and will provide better performance - sorry there is no For Loop in PowerApps - that would be development!

 

Also - you are using SelectedText in your formula - this is a deprecated property and should be avoided.  Instead use the .Selected and the proper column name form your Selected record.  For the rest of the formula shown below, I will assume a Value column.

 

So your formula would be:

Patch(DailyActivityDetails, 
    ForAll(ActionDetails, 
       {Action: ddAction.Selected, 
        State: ddState.Selected.Value, 
        ItemType: ddIType.Selected.Value, 
        ItemCode: ddICode.Selected.Value, 
        Pieces: Value(tPieces.Text), 
        SFBFt: Value(tSFBFt.Text), 
        From: cbFrom.Selected.location, 
        To: cbTo.Selected.location, 
        Remarks: tRemarks.Text, 
        MasterID: Self.LastSubmit.ID
      }
   )
)

 

 

NEXT - are you stating that exactly prior to doing a SubmitForm(Form1), the Collection only has the two rows you showed and that after that, your list has three rows?

 

Also - What is your Submit formula?

 

Questions, questions 😁

 

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Bless you so much Randy.  Very educational and helpful.  

The the number of records created after SubmitForm(Form1) in the List is always the same as the number of rows in the Collection.  The the data in all the created List records matches the last row of the Collection.  So I'll have 3 unique records in the Collection, and 3 duplicate records in the List that match the 3rd record of the Collection.

cpill1220_0-1663961259776.png

 

 

 

 

@cpill1220 

Where are these values coming from?

In second look at your formula - it really doesn't make must sense as you are iterating in the ForAll on the collection, but all of your record values are referencing controls (i.e. ddAction).  Where are those controls??

I am guessing a gallery, but please confirm.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Yes, all the controls except MasterID are in a gallery.  

-ddAction is a dropdown with choices defined in the Items property

-ddState dropdown choices come from a sharepoint list with Items property:

Ungroup(
Table(
{Value: Blank()},
{Value: Distinct(Daily_Sheet_Filters, STATE)}
),
"Value"
)

-ddIType and ddICode choices come from same sharepoint list and have a 'cascading' items property formula

-tPieces, tSFBft, tRemarks ...single and multiline text inputs

-cbFrom and cbTo are combobox controls with a SQL connector datasource

 

I changed the order of Patch and ForAll in the OnSuccess formula with no error, but when I try to Selected.Value or Selected.Result on the State, there's an "Invalid argument type (Table). Expecting a Record Value." error

 

Same error on ItemType.  Here's the ddItemType control Items property formula:

Ungroup(
Table(
{Value: Blank()},
{Value: Distinct(
Filter(
Daily_Sheet_Filters,
STATE = ddState.Selected.Result
),
ITYPE
)}
),
"Value"
)

 

@cpill1220 

So what is the collection???  If this is coming from a Gallery, there is no need for a collection!

 

Yes, you are going to get those errors because your formulas on the Items properties are not correct!

 

Your ddState control Items should be:

Ungroup(
    Table({Value: Table({Result: Blank()}) },
          {Value: Distinct(Daily_Sheet_Filters, STATE)}
    ),
    "Value"
)

Your previous formula making Value a Record AND a Table.  They both need to be tables to ungroup properly.

 

Then your ddItemType Items property should also be fixed:

Ungroup(
    Table({Value: Table({Result: Blank()}) },
          {Value: Distinct(Filter(Daily_Sheet_Filters, STATE = ddState.Selected.Result), ITYPE)}
    ),
    "Value"
)

 

You have to provide table to table with column to column records being identical, or else the Upgroup to add a Blank is not going to work properly.

 

However...before introducing these changes into the your Patch formula...I need to know about the Gallery and what part the collection plays in anything you are doing.

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Need users to enter data into the below form.  The top 5 entries will populate a master sharepoint list when Form1 is submitted, with a unique record id.  The gallery entries need to populate the details sharepoint list, all with the same 'master id' that's generated Form1 submission.  

cpill1220_0-1663970522829.png

 

Thank you so much for the help.

@cpill1220 

Okay, so the collection is only needed as a basic "base" for the gallery.  You don't need to do anything special with it.  It just needs to have the primary key (ID) of the records in it (or blank if none).  Patch will do the rest.

 

So. this means you are referencing the wrong data when you Patch!

You are referencing the controls in the gallery in your Patch.  When you do that out of context of the gallery, all you will get is the last selected item in the gallery...THIS explains why you are seeing the same records repeated.

 

Your Formula needs the context of the Gallery!!

It should be:

Patch(DailyActivityDetails, 
    ForAll(yourGallery.AllItems, 
       {ID: ID, 
        Action: ddAction.Selected, 
        State: ddState.Selected.Value, 
        ItemType: ddIType.Selected.Value, 
        ItemCode: ddICode.Selected.Value, 
        Pieces: Value(tPieces.Text), 
        SFBFt: Value(tSFBFt.Text), 
        From: cbFrom.Selected.location, 
        To: cbTo.Selected.location, 
        Remarks: tRemarks.Text, 
        MasterID: Self.LastSubmit.ID
      }
   )
)

 

That is it!

 

Now, I notice you have some provisions for delete in your gallery - That needs to be addressed separately.  

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

YOU.HAVE.CHANGED.MY.LIFE!! 

Thank you Sir.

@cpill1220 

LOL...happy to help!! 

 

There is still one "gotcha" in your scenario.  You have a delete icon in your gallery.  There needs to be some special actions to make that happen properly (i.e. remove from your datasource).  If the gallery is just showing what would be new records (i.e. you're not editing existing records), then all is good.  Otherwise, there are some other steps for that to work properly.

 

If that becomes an issue...just let me know!

_____________________________________________________________________________________
Digging it? - Click on the Thumbs Up below. Solved your problem? - Click on Accept as Solution below. Others seeking the same answers will be happy you did.
NOTE: My normal response times will be Mon to Fri from 1 PM to 10 PM UTC (and lots of other times too!)
Check out my PowerApps Videos too! And, follow me on Twitter @RandyHayes

Really want to show your appreciation? Buy Me A Cup Of Coffee!

Helpful resources

Announcements

Community will be READ ONLY July 16th, 5p PDT -July 22nd

Dear Community Members,   We'd like to let you know of an upcoming change to the community platform: starting July 16th, the platform will transition to a READ ONLY mode until July 22nd.   During this period, members will not be able to Kudo, Comment, or Reply to any posts.   On July 22nd, please be on the lookout for a message sent to the email address registered on your community profile. This email is crucial as it will contain your unique code and link to register for the new platform encompassing all of the communities.   What to Expect in the New Community: A more unified experience where all products, including Power Apps, Power Automate, Copilot Studio, and Power Pages, will be accessible from one community.Community Blogs that you can syndicate and link to for automatic updates. We appreciate your understanding and cooperation during this transition. Stay tuned for the exciting new features and a seamless community experience ahead!

Summer of Solutions | Week 4 Results | Winners will be posted on July 24th

We are excited to announce the Summer of Solutions Challenge!   This challenge is kicking off on Monday, June 17th and will run for (4) weeks.  The challenge is open to all Power Platform (Power Apps, Power Automate, Copilot Studio & Power Pages) community members. We invite you to participate in a quest to provide solutions in the Forums to as many questions as you can. Answers can be provided in all the communities.    Entry Period: This Challenge will consist of four weekly Entry Periods as follows (each an “Entry Period”)   - 12:00 a.m. PT on June 17, 2024 – 11:59 p.m. PT on June 23, 2024 - 12:00 a.m. PT on June 24, 2024 – 11:59 p.m. PT on June 30, 2024 - 12:00 a.m. PT on July 1, 2024 – 11:59 p.m. PT on July 7, 2024 - 12:00 a.m. PT on July 8, 2024 – 11:59 p.m. PT on July 14, 2024   Entries will be eligible for the Entry Period in which they are received and will not carryover to subsequent weekly entry periods.  You must enter into each weekly Entry Period separately.   How to Enter: We invite you to participate in a quest to provide "Accepted Solutions" to as many questions as you can. Answers can be provided in all the communities. Users must provide a solution which can be an “Accepted Solution” in the Forums in all of the communities and there are no limits to the number of “Accepted Solutions” that a member can provide for entries in this challenge, but each entry must be substantially unique and different.    Winner Selection and Prizes: At the end of each week, we will list the top ten (10) Community users which will consist of: 5 Community Members & 5 Super Users and they will advance to the final drawing. We will post each week in the News & Announcements the top 10 Solution providers.  At the end of the challenge, we will add all of the top 10 weekly names and enter them into a random drawing.  Then we will randomly select ten (10) winners (5 Community Members & 5 Super Users) from among all eligible entrants received across all weekly Entry Periods to receive the prize listed below. If a winner declines, we will draw again at random for the next winner.  A user will only be able to win once overall. If they are drawn multiple times, another user will be drawn at random.  Individuals will be contacted before the announcement with the opportunity to claim or deny the prize.  Once all of the winners have been notified, we will post in the News & Announcements of each community with the list of winners.   Each winner will receive one (1) Pass to the Power Platform Conference in Las Vegas, Sep. 18-20, 2024 ($1800 value). NOTE: Prize is for conference attendance only and any other costs such as airfare, lodging, transportation, and food are the sole responsibility of the winner. Tickets are not transferable to any other party or to next year’s event.   ** PLEASE SEE THE ATTACHED RULES for this CHALLENGE**   Week 1 Results: Congratulations to the Week 1 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge. Community MembersNumber of SolutionsSuper UsersNumber of Solutions @anandm08  23 @WarrenBelz  31 @DBO_DV  10 @Amik  19 AmínAA 6 @mmbr1606  12 @rzuber  4 @happyume  7 @Giraldoj  3@ANB 6 (tie)   @SpongYe  6 (tie)     Week 2 Results: Congratulations to the Week 2 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge. Community MembersSolutionsSuper UsersSolutions @anandm08  10@WarrenBelz 25 @DBO_DV  6@mmbr1606 14 @AmínAA 4 @Amik  12 @royg  3 @ANB  10 @AllanDeCastro  2 @SunilPashikanti  5 @Michaelfp  2 @FLMike  5 @eduardo_izzo  2   Meekou 2   @rzuber  2   @Velegandla  2     @PowerPlatform-P  2   @Micaiah  2     Week 3 Results: Congratulations to the Week 3 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge.   Week 3:Community MembersSolutionsSuper UsersSolutionsPower Apps anandm0861WarrenBelz86DBO_DV25Amik66Michaelfp13mmbr160647Giraldoj13FLMike31AmínAA13SpongYe27     Week 4 Results: Congratulations to the Week 4 qualifiers, you are being entered in the random drawing that will take place at the end of the challenge.   Week 4:Community MembersSolutionsSuper UsersSolutionsPower Apps DBO-DV21WarranBelz26Giraldoj7mmbr160618Muzammmil_0695067Amik14samfawzi_acml6FLMike12tzuber6ANB8   SunilPashikanti8

Check Out | 2024 Release Wave 2 Plans for Microsoft Dynamics 365 and Microsoft Power Platform

On July 16, 2024, we published the 2024 release wave 2 plans for Microsoft Dynamics 365 and Microsoft Power Platform. These plans are a compilation of the new capabilities planned to be released between October 2024 to March 2025. This release introduces a wealth of new features designed to enhance customer understanding and improve overall user experience, showcasing our dedication to driving digital transformation for our customers and partners.    The upcoming wave is centered around utilizing advanced AI and Microsoft Copilot technologies to enhance user productivity and streamline operations across diverse business applications. These enhancements include intelligent automation, AI-powered insights, and immersive user experiences that are designed to break down barriers between data, insights, and individuals. Watch a summary of the release highlights.    Discover the latest features that empower organizations to operate more efficiently and adaptively. From AI-driven sales insights and customer service enhancements to predictive analytics in supply chain management and autonomous financial processes, the new capabilities enable businesses to proactively address challenges and capitalize on opportunities.    

Updates to Transitions in the Power Platform Communities

We're embarking on a journey to enhance your experience by transitioning to a new community platform. Our team has been diligently working to create a fresh community site, leveraging the very Dynamics 365 and Power Platform tools our community advocates for.  We started this journey with transitioning Copilot Studio forums and blogs in June. The move marks the beginning of a new chapter, and we're eager for you to be a part of it. The rest of the Power Platform product sites will be moving over this summer.   Stay tuned for more updates as we get closer to the launch. We can't wait to welcome you to our new community space, designed with you in mind. Let's connect, learn, and grow together.   Here's to new beginnings and endless possibilities!   If you have any questions, observations or concerns throughout this process please go to https://aka.ms/PPCommSupport.   To stay up to date on the latest details of this migration and other important Community updates subscribe to our News and Announcements forums: Copilot Studio, Power Apps, Power Automate, Power Pages

Users online (2,262)